Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47B64C433EF for ; Wed, 25 May 2022 12:59:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6BB9842DB; Wed, 25 May 2022 14:59:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="h+tj81Vf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9AC94842E9; Wed, 25 May 2022 14:59:16 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 542D9842D9 for ; Wed, 25 May 2022 14:59:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id j6so17211268qkp.9 for ; Wed, 25 May 2022 05:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uVUeKWXaJ6vNlZ6bXrWhwoRgfYa4pz0mklMsFOIS+Mc=; b=h+tj81Vf06oVr4M1g4K9KQyuzwrWxdDsx5PWlRqwFpznw87gpyeDxkwyvbO/x0I931 wEOB/lvxK9Qj10BYX+Cw3TXrtu6dPN4pjRFrJ3fOJyi9AbMc5YbSinn8UFOme9MrChhY 7gbaBI3tnsDquD0LgbcIIrUsiDUU8ML+FRVPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uVUeKWXaJ6vNlZ6bXrWhwoRgfYa4pz0mklMsFOIS+Mc=; b=8Ee/vt/RGSNGR+hXDuF32HyO0DTrNriFdu8gEmE0JpNjEDYvewKu+d4pzVsGd835J1 4XcYjMS6WK8n9B1MjqjBthgQRjM9Tc1shMtglRew2ulUjISkXVMpKOnKFlT4OumLI1dp iI9kaI7zYHY0Rb6CAh/ciu7+FoL3arAMLHRKwP2YPKQXRdUAytJvIbeLgL3X7BvlDHlR MlH7Z2CGNUjkMCiUMF7R8oPr0+a86SGXpBR+Q7HGw7Fc6b+VMH4tVEVjdtB8+w+7UJLO 6j5ThDlQWwzlwCs5RwxY2JwcIy+m9AJHSw3n1/SU7Xe6AycIvUQI5T1JvdmTNI7bVtzu vDdw== X-Gm-Message-State: AOAM530ReWVFjdLQxFecF7Bft/P5Lzh0h1x6MJmnwTCNL++IAs+iAL/7 AlhdjDN7G8x0CKZQUbqipho4ug== X-Google-Smtp-Source: ABdhPJxELISkeH9AAr0W2aT2RK3BcZFP+RplrYC+fG961iXs0A0RHPq4zNloICAFiqqhs1rYIVE88g== X-Received: by 2002:a37:de0c:0:b0:69e:cd37:7646 with SMTP id h12-20020a37de0c000000b0069ecd377646mr21099368qkj.449.1653483552047; Wed, 25 May 2022 05:59:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-25fd-0000-0000-0000-1003.res6.spectrum.com. [2603:6081:7b00:25fd::1003]) by smtp.gmail.com with ESMTPSA id cc9-20020a05622a410900b002f92a5a396esm1348108qtb.3.2022.05.25.05.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 05:59:11 -0700 (PDT) Date: Wed, 25 May 2022 08:59:09 -0400 From: Tom Rini To: Sean Anderson Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Subject: Re: [PATCH] net: Add missing PCI dependency for CONFIG_E1000 Message-ID: <20220525125909.GJ13239@bill-the-cat> References: <20220523084149.3715-1-pali@kernel.org> <0cbb7e46-26cc-801b-145a-1c9ef7512b99@seco.com> <20220524171652.yocerscdwgm3spyp@pali> <504ad9c4-304c-6bd1-24c5-2efff1bb1858@seco.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="95nVhCDQCgPWiQqT" Content-Disposition: inline In-Reply-To: <504ad9c4-304c-6bd1-24c5-2efff1bb1858@seco.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --95nVhCDQCgPWiQqT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 24, 2022 at 01:32:08PM -0400, Sean Anderson wrote: >=20 >=20 > On 5/24/22 1:16 PM, Pali Roh=E1r wrote: > > On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote: > >> Hi Pali, > >>=20 > >> On 5/23/22 4:41 AM, Pali Roh=E1r wrote: > >> > Signed-off-by: Pali Roh=E1r > >> > --- > >> > drivers/net/Kconfig | 1 + > >> > 1 file changed, 1 insertion(+) > >> >=20 > >> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > >> > index 7fe0e00649cf..84d859c21eb8 100644 > >> > --- a/drivers/net/Kconfig > >> > +++ b/drivers/net/Kconfig > >> > @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186 > >> > =20 > >> > config E1000 > >> > bool "Intel PRO/1000 Gigabit Ethernet support" > >> > + depends on PCI > >> > help > >> > This driver supports Intel(R) PRO/1000 gigabit ethernet family of > >> > adapters. For more information on how to identify your adapter,= go > >> >=20 > >>=20 > >> This appears to be a duplicate of [1]. > >>=20 > >> [1] https://lore.kernel.org/u-boot/20220426183533.3224252-1-sean.ander= son@seco.com/ > >>=20 > >> --Sean > >=20 > > Interesting... this is my second duplicate patch this week. > >=20 > > Any idea why above patch was not accepted yet? >=20 > Looks like Ramon has not done a pull request since mid April [1]. Though > based on the past pattern, it seems like he just makes one PR each releas= e. > Perhaps Tom can pick this up? >=20 > [1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKU= YjeRhLDzxacXQ@mail.gmail.com/ Sure. It didn't stand out as a critical thing so I was assuming at the time it would come in eventually. I've put it in my bundle of stuff to not forget. --=20 Tom --95nVhCDQCgPWiQqT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKOKB0ACgkQFHw5/5Y0 tyyzNgwAiZNxAKr8c97cDs82Prr2apJ9UT2o2fu86t6cR9DGFDT0ODG4KcLOJi1o 0vxqB3ic80h3Q13kpfe/lsXl2VdjPtNSSpnG7Xavb1Cc+1PFyIsk+LtQ+wROQ4AP hiPYEPawhmWWVTW/eBtFPNk4pCPNoS0tuC5xGeR2dMknGjHdR7ndyuDy/oOufWC8 r5Y1HRU92YiJlp3pk1VFITAF2Tnm3OhZyofCx1mRzKj0FSNHMeIepzSUVt8DQOSD B1DUfm11v0Ome/HTTI9SNR7J0D8WoAXNU/v377jDl7+MWnicAUJVrzk+getlylVJ BFHGkPXT/J35RqWGlkvIC8j971Nh1H0xOAjkMCgTBcAEumjtvBiKhK0hRYhTf2LI 2HHbmLJ6dlgzjssLgli5H71IKRg/oIaDzu6Wxbe1QlXSSVkfZHXqCh+wg7UIb6O9 zDtfoQgoVW23qMl3qRyi9sQ3MIRghFcxl8uhcpDUW4zXX8WeTEPmFHgmcZ/h6ZuP 1l5gzANE =MZpZ -----END PGP SIGNATURE----- --95nVhCDQCgPWiQqT--