Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FF50C433F5 for ; Sat, 28 May 2022 21:37:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B26FA8435F; Sat, 28 May 2022 23:37:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ey2NoQTV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BDFF08435F; Sat, 28 May 2022 23:37:07 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9B2D284354 for ; Sat, 28 May 2022 23:37:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id s5so6977447qvo.12 for ; Sat, 28 May 2022 14:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PCu4Xvu9KEa6MmV8rnUos/45Z/sIpYch2ItT8ZuriLM=; b=Ey2NoQTVZfLnk2JBU3TmnPQGbrOspygkzo4rXmB9YtKDSuRR9DQI1ELqflJM2PbWuP 4/39AmGZPMtr5X0nmrzQRXMmnmQ0InMRFBPyVGYtUJGMeH2XH7kazCA2cWoepR9nb54+ Qf4ZvfmbajGqPzY2MqJJtdHf3PWMqsihsB+Fw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PCu4Xvu9KEa6MmV8rnUos/45Z/sIpYch2ItT8ZuriLM=; b=HEc1r+kN/Ns2OcY38RReDhMoui7Pgm35+ad/rbA6jYz2TO2vAU4eLHk4L2N5jE+DCz rtl14mw8zMBoKIzD8qXY9WFdsLxnmYXcj2t95a1ImrbXuFQmYDjJfW5Op8ciYl7TcW7w k/fd+vcKAdPGdaDlXv91y11eo+g6e6idrfkfUMXl8WRO8teFUbXXzRKhT1eStFX2qI34 ukxmeptNl0deL0TUoiu5+sAWtrd2doLaHwmAKbhUwoqeTlOGc8es1SHRoSFaRX1IBv4M FaxWWJhyTtu+4mqcyQthOe3htftZxqZlrzWrKLs3U/q+HO87wRGJLvYd4+weymgDg3DN cbdw== X-Gm-Message-State: AOAM533M4AqnWyW1V5AfygQZuQ6FNzwBZZnkiqY4NaF+wwhM2e2oo+ib KvALjPBEQAZ+yLdT1kUyU0MWFA== X-Google-Smtp-Source: ABdhPJxgrAQt+4eqoOr2bZMwT366KUlcLGHPWfPxd75nLxQK91HoOGUuw6Uh73O1kt0KYZ477GRpjw== X-Received: by 2002:a05:6214:23c9:b0:461:c9e7:9cd6 with SMTP id hr9-20020a05621423c900b00461c9e79cd6mr39961517qvb.116.1653773822312; Sat, 28 May 2022 14:37:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-25fd-0000-0000-0000-1003.res6.spectrum.com. [2603:6081:7b00:25fd::1003]) by smtp.gmail.com with ESMTPSA id bp9-20020a05622a1b8900b002f77a8bc37fsm5328854qtb.51.2022.05.28.14.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 14:37:01 -0700 (PDT) Date: Sat, 28 May 2022 17:36:59 -0400 From: Tom Rini To: Chris Packham Cc: u-boot , Mario Six , Chris Packham , Stefan Roese Subject: Re: Converting CONFIG_SPL_BOOT_DEVICE to Kconfig in U-Boot Message-ID: <20220528213659.GN25375@bill-the-cat> References: <20220528165218.GM25375@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 29, 2022 at 09:35:59AM +1200, Chris Packham wrote: > Hi Tom, >=20 > On Sun, 29 May 2022, 4:52 AM Tom Rini, wrote: >=20 > > Hey folks, > > > > As part of converting outstanding CONFIG symbols to Kconfig, I've run in > > to CONFIG_SPL_BOOT_DEVICE and while I think I see how to do it, it > > would be better I think if someone that has the hardware and can test > > the logic out, does it. > > > > In short, I believe we need to: > > - SPL_BOOT_SPI_NOR_FLASH / SPL_BOOT_SDIO_MMC_CARD become a choice > > section in arch/arm/mach-mvebu/Kconfig, guarded by !SECURED_MODE_IMAGE > > - KWB_CFG_SEC_BOOT_DEV in arch/arm/mach-mvebu/Makefile gets updated > > based on how the Kconfig logic now works. > > - In the case of CONFIG_SPL_BOOT_SDIO_MMC_CARD (or whatever it's named) > > and MMC_SDHCI we just have that value defined and drivers/mmc/sdhci.c > > is updated to check it for SPL. Or if this is possibly useful outside > > of SPL, we make use of CONFIG_VAL and have > > 'SPL_FIXED_SDHCI_ALIGNED_BUFFER' be set for the current case. > > - CONFIG_SPL_BOOT_DEVICE is removed > > > > I think that covers everything, but please let me know if I missed > > something or I got the logic wrong or something. Thanks! > > >=20 > I can give it a go. All the boards I have access to boot from SPI but I c= an > at least compile test the MMC support. Thanks! --=20 Tom --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKSlfAACgkQFHw5/5Y0 tywcjwwAjrkeKbo4+kxfC73SktTpdL7yaLdeDijnyKPPQRA7pXmaKSWXsMKLCNOz JZABtlvVKAjXGKlQHxx0L2QBxuy7wgGPuj1wQTkUHPQyqfZxshjkqhYSnY5yIOJu oFHTeQPXLGi0UY4wM6YnCMjdPqGXmmaAexfEMD+TNM43SpGV1e1b9t9r9GZqhdt4 06W8OQG26305Dwc6XuZN0VanJONfOA826BSoka2+ELhxu8B5rAXOp+Q0CIhY5SEz pyjd73wIldXiHOMbkLQgdMGy2Ta04BbL+0dj5qby+n3Y1e69VT/2wMGBhRPzVeBt oYmb7uAfAQ8ARc6CFbepuU93Ua5jbSWUjfxvFEoxphFwRR3qGtoJlGbzGThPBF0Y EpeffKxh/+tghoY5ddRLZ2JwW3vJTIWNITbYxFUgdr/+dV/hbIiCxh9flMBL8+Ur s6q7jomyrsZVIEEX+5XSs6mwS53DNtuERTCBCIJZWIxqerquAW4VZdCVBhKv2AAD frFPWXaa =xvzG -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN--