Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5450C433F5 for ; Sat, 28 May 2022 22:09:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D16E84382; Sun, 29 May 2022 00:09:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Wwf84zaF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4750B8437D; Sun, 29 May 2022 00:09:13 +0200 (CEST) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2367E84384 for ; Sun, 29 May 2022 00:09:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id t2so8155251qkb.12 for ; Sat, 28 May 2022 15:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0daWM6inzJr3dR/QtfmlNzFaW8BuIxM9uQ0BufH1JVc=; b=Wwf84zaFgtFKRwmq2yV49NhZ/QN8YCYIZjS81eV/oMzjt4FAQ6an+bv9GB5vyf8bvP JzllXF9L9Lg9efpAtnOtZr4PDSYY4HVRtJx9+cs1kmADeJVwzehaMiWSThjaLRbslUGO BZkQLtBKY1/dMoGTUOy5t+4AZbobPjjFfHy/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0daWM6inzJr3dR/QtfmlNzFaW8BuIxM9uQ0BufH1JVc=; b=b/Kxm/hzdjY4zMLUi/kLlUrqTLfW+j/zqyXktsi40bThB7ERXpUEBqTWQ5CAdIuCaK VEJpiNUdvsSi4gQYy3KJQahubhRRl/Q5FlYeuRlCGTj/iSl9A8mLeOCZRnOQdi5AvMOp wJ7zIaE0xd5v5sZDSMFkU6Fha5h47U8yiTli2qaLgC9hZEVx63eKMG0im2vKrCdagnUq THArauSWs6G3ULOkLPrqXZXYQtpJX9GvpVRN9lLg3fgjY8pKhFtFurL8fugN1UolFypk Dg3ZC+jvxOuYu9s4xrDWuKdExiTM2ewCxTTa2Veq7gDR9Ay3q2C0kIcMGD7wR+xrIRke 7duw== X-Gm-Message-State: AOAM530EMVSaiafWGbKOFeeKZiClLnIfy6VXe58RANA0BhLID7JMd2SN jOJio097ZnmEDGRNoJbfuHaYug== X-Google-Smtp-Source: ABdhPJzdmb28nJP+uPWAZo45taZmWwyZbZlalCxpHGzRm44wUf0IEpnaIDc8GsvFMJHv8liTXitAKQ== X-Received: by 2002:a37:456:0:b0:6a3:6f0d:7fb7 with SMTP id 83-20020a370456000000b006a36f0d7fb7mr25059893qke.57.1653775743768; Sat, 28 May 2022 15:09:03 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-25fd-0000-0000-0000-1003.res6.spectrum.com. [2603:6081:7b00:25fd::1003]) by smtp.gmail.com with ESMTPSA id i1-20020a05620a150100b006a5d4f32e5dsm3525754qkk.128.2022.05.28.15.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 15:09:02 -0700 (PDT) Date: Sat, 28 May 2022 18:09:00 -0400 From: Tom Rini To: Chris Packham Cc: u-boot , Mario Six , Chris Packham , Stefan Roese , Baruch Siach Subject: Re: Converting CONFIG_SPL_BOOT_DEVICE to Kconfig in U-Boot Message-ID: <20220528220900.GO25375@bill-the-cat> References: <20220528165218.GM25375@bill-the-cat> <20220528213659.GN25375@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zHDeOHGDnzKksZSU" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --zHDeOHGDnzKksZSU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 29, 2022 at 10:07:20AM +1200, Chris Packham wrote: > On Sun, May 29, 2022 at 9:37 AM Tom Rini wrote: > > > > On Sun, May 29, 2022 at 09:35:59AM +1200, Chris Packham wrote: > > > Hi Tom, > > > > > > On Sun, 29 May 2022, 4:52 AM Tom Rini, wrote: > > > > > > > Hey folks, > > > > > > > > As part of converting outstanding CONFIG symbols to Kconfig, I've r= un in > > > > to CONFIG_SPL_BOOT_DEVICE and while I think I see how to do it, it > > > > would be better I think if someone that has the hardware and can te= st > > > > the logic out, does it. > > > > > > > > In short, I believe we need to: > > > > - SPL_BOOT_SPI_NOR_FLASH / SPL_BOOT_SDIO_MMC_CARD become a choice > > > > section in arch/arm/mach-mvebu/Kconfig, guarded by !SECURED_MODE_= IMAGE > > > > - KWB_CFG_SEC_BOOT_DEV in arch/arm/mach-mvebu/Makefile gets updated > > > > based on how the Kconfig logic now works. > > > > - In the case of CONFIG_SPL_BOOT_SDIO_MMC_CARD (or whatever it's na= med) > > > > and MMC_SDHCI we just have that value defined and drivers/mmc/sdh= ci.c > > > > is updated to check it for SPL. Or if this is possibly useful ou= tside > > > > of SPL, we make use of CONFIG_VAL and have > > > > 'SPL_FIXED_SDHCI_ALIGNED_BUFFER' be set for the current case. > > > > - CONFIG_SPL_BOOT_DEVICE is removed > > > > > > > > I think that covers everything, but please let me know if I missed > > > > something or I got the logic wrong or something. Thanks! > > > > > > > > > > I can give it a go. All the boards I have access to boot from SPI but= I can > > > at least compile test the MMC support. >=20 > Actually it looks even easier. >=20 > Baruch already did most of the work in ad105f5f8694 ("mvebu: > consolidate SPL boot device config symbols"). I think the only thing > left is converting the remaining 3 boards. Oh nice. And then FIXED_SDHCI_ALIGNED_BUFFER still needs to be taken care of :) --=20 Tom --zHDeOHGDnzKksZSU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKSnXkACgkQFHw5/5Y0 tywFXwv+Mi+zfty0c1mg0CUy2YgdUWAt0GmIpG2y0GVeWOUOpzlTXgQbRh3EmX86 KURXOnzEDmS9ldHp6p44ztglRyC7Wh0H0RWR1Nyq29K1iA09Ln6pEGg33jaH5KMg PtWh5xVJmFzldOu0yITry4THrxbvW/hBXXEsJeUvK0br/3o1WD67eE3xrCWmzi3n c6nD+of5GHwRA5DF7fRLGDLAA3Z0ZMA2vTZUe1QtHwMQfzzI3cwLA/7cUk4+skqB chhet+zID+nbUMElt/1DsMMHxB5uJy9mSkovri4RQLzFYcF2qSp+PmMv3GJdMUjv ZVffrhRqzr/JmLvAY0bGYnGkDljD8mnS1eQMhOwYLzZrobgi5cGtKpd0NwMNX3ii hDTH+HVNs/f35P8i1cnAPRQ5RP+4kVrmd87ItfL09iLIeEm5wEHYaZDOrDzAQumM G6BfwaFH4zeLhpl+CiKNsg5MQbOIUKJNxisanmjM/rXd6yvYE6VBrPYzVoVi7LQ2 JBeQ0aX9 =Ai8Z -----END PGP SIGNATURE----- --zHDeOHGDnzKksZSU--