Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5487C433EF for ; Mon, 30 May 2022 13:46:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AF9991F17; Mon, 30 May 2022 15:45:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AF9991F17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653918393; bh=r0fIl1paJppCtESdUdyUAQ98xxiKIcSO5MMEPsCXkb4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z2PpbZWmE7WG5arDS2ANwMW83VXlQ0lKttVz/PL/uF6yQSdPNiOTxWQ5Ei5W3KuIv kXcambzzXm9yS91YlpDJ9TMQOANJ4t/Z1rq/cQdGflszz/KXzIB6Y6/WSxXMX/KBSa lyw5aLfH4A+4qaoIgjYn3+7uyqNHG66LAdr6djXM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 34CEEF8012F; Mon, 30 May 2022 15:45:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 70851F800DE; Mon, 30 May 2022 15:45:41 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E8F65F800DE for ; Mon, 30 May 2022 15:45:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E8F65F800DE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kZOvhyi3" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BF4660F22; Mon, 30 May 2022 13:45:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E89F3C3411F; Mon, 30 May 2022 13:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653918336; bh=r0fIl1paJppCtESdUdyUAQ98xxiKIcSO5MMEPsCXkb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kZOvhyi3tcmCeh4Eyo2M93ZAXZswYDx21A1weOcgby0iPYyH6CPRh7yOxd7mWne31 7jB6BUas77oCmBHwtPCFlhaAZmmec7RsImY1XevrFiJlkwD71t9QzYMBDcWMw3tkqc 4pnMaYRyg97bgTHfFxZM4B8fwdQCnGwxYFO41iGnUhvQR0cC13FBQbobP0Q4DIcI6J 1+kj0nkmB4J8ImWhUqtq9tnkgB4/r/Xy3al5jjJJ1tnqhI1j68IuyozvyEiqK1Vn1V VASe0KUu4o5++k1dgrT41HyVfVj/oKZhzXazdl1rzKyxouObrN0AMmhSY/b3vQ2dK9 TTBdgZ3jYz2zw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 40/76] ASoC: dapm: Don't fold register value changes into notifications Date: Mon, 30 May 2022 09:43:30 -0400 Message-Id: <20220530134406.1934928-40-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530134406.1934928-1-sashal@kernel.org> References: <20220530134406.1934928-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit ad685980469b9f9b99d4d6ea05f4cb8f57cb2234 ] DAPM tracks and reports the value presented to the user from DAPM controls separately to the register value, these may diverge during initialisation or when an autodisable control is in use. When writing DAPM controls we currently report that a change has occurred if either the DAPM value or the value stored in the register has changed, meaning that if the two are out of sync we may appear to report a spurious event to userspace. Since we use this folded in value for nothing other than the value reported to userspace simply drop the folding in of the register change. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220428161833.3690050-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-dapm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 417732bdf286..f2f7f2dde93c 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3427,7 +3427,6 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, update.val = val; card->update = &update; } - change |= reg_change; ret = soc_dapm_mixer_update_power(card, kcontrol, connect, rconnect); @@ -3529,7 +3528,6 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol, update.val = val; card->update = &update; } - change |= reg_change; ret = soc_dapm_mux_update_power(card, kcontrol, item[0], e); -- 2.35.1