Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 647A3C433FE for ; Mon, 30 May 2022 13:53:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 98BF01F81; Mon, 30 May 2022 15:52:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 98BF01F81 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653918822; bh=8Ic3YfIspf4SZu0wJZZZYDsTRyDu74+FGba6hXMd06o=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y+JgViX1vaq2GFxghZJXV4d85jETEOvjeV39cyFsdfDqXP9El0DNrwwLh3bjGDi1N iiNJ/wRqDxDeFSOAZuC5b57rnclmZfL9yRnuVCq66O2+GrYXM0D5t6Rh9pgPeubTWJ gNcM+3KxC6lxLBnFW74zvAPK3Vc5r/U3BfNR07pE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3BECEF801F5; Mon, 30 May 2022 15:52:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 243FDF804BD; Mon, 30 May 2022 15:52:51 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6755F800E5 for ; Mon, 30 May 2022 15:52:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6755F800E5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UyyBvc0p" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 748A161048; Mon, 30 May 2022 13:52:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67A44C3411A; Mon, 30 May 2022 13:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653918767; bh=8Ic3YfIspf4SZu0wJZZZYDsTRyDu74+FGba6hXMd06o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UyyBvc0ptK8QLKyVC6+wzbgsJ/476g3AKw/OSjyRweURMvw0R4RPwspxmixcV5miS xMRNfRZUgWjZmYv+Ybe5jl7mAbz0jpccNqJZ7XAr1SLUnd/2T+bJvJ9mVKtB4UQBzc hl/+bRVfzbEPYOUTdaoWog9KMackKXXOfna7bwuf3qyn3qPa0dGoq71jauLdSa9nMb +6XLMijwdi9aN+a7FenaQfVlfSlQ+MmZkCWa+/+wTe9UeXP04OkbfNe8LHhcFK37R2 2RVnh4JLTUZfN2+6dY3Dej7Jxq3wkMs8S2cnbDvG3eklyBqpZiMFidykQEE3j4UbCg dTE3s4BUQw5Eg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 14/24] ASoC: dapm: Don't fold register value changes into notifications Date: Mon, 30 May 2022 09:52:01 -0400 Message-Id: <20220530135211.1937674-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530135211.1937674-1-sashal@kernel.org> References: <20220530135211.1937674-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit ad685980469b9f9b99d4d6ea05f4cb8f57cb2234 ] DAPM tracks and reports the value presented to the user from DAPM controls separately to the register value, these may diverge during initialisation or when an autodisable control is in use. When writing DAPM controls we currently report that a change has occurred if either the DAPM value or the value stored in the register has changed, meaning that if the two are out of sync we may appear to report a spurious event to userspace. Since we use this folded in value for nothing other than the value reported to userspace simply drop the folding in of the register change. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220428161833.3690050-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-dapm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 878a4fc97f04..40bf50cd87bc 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3165,7 +3165,6 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol, update.val = val; card->update = &update; } - change |= reg_change; ret = soc_dapm_mixer_update_power(card, kcontrol, connect); @@ -3270,7 +3269,6 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol, update.val = val; card->update = &update; } - change |= reg_change; ret = soc_dapm_mux_update_power(card, kcontrol, item[0], e); -- 2.35.1