Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65647C433EF for ; Wed, 1 Jun 2022 14:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=juIZP0ExL4vNLv4BGK06sKhp3ZIUzjrjgcSeO3FVLX4=; b=h24QRQwMBYSTpb xuapHmuIsVfGdg6NEnwfGmMilA+atOPw9cW5903jSZiQJKNrumRyXpLEVSmLBem+N57H9vlGWaKQY 9gaEg7gkEk2fv1P/r3kIGA/5K+iRwf7hZMY1IJai1nAkToShXFAlZ/kPexWmLljkf9xUmze1EpWmm sOyp7pErF+pZSTKIYUCrhacaTTdIPACHkV/L/kAtR5tOJpUtW7Gk47/NeNHfknEeJmLhhF/IZ8n4g t7086Qk6xh1CvErUadXGWh2xSl92dV4LSyn7Ktjl3Ct1kYYXbd0OoQr4EYrW37HIdDIGsFHglAeKf wPrejA4QBYOVxWuUQOnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOt0-00GSQb-3z; Wed, 01 Jun 2022 13:59:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwOpy-00GQdD-GC for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 13:56:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F3C66162A; Wed, 1 Jun 2022 13:56:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33450C385A5; Wed, 1 Jun 2022 13:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654091797; bh=85vm1vrtGgzFH8G8lTONTiZh58r6Wicm/naQSPQ/3OI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fegC8XnKGfkXbX1CoCvYsycdkZ4KwEtE5koNJNZiCqNRcV6KDPV6KHJl2Pk29tqro CZaiHg+ezzpLsFQd7VNQmmVGQXPTR6BFP9sqFEw002DH3sAEbvopH6ImAFGQ6WuXRY SAxIZjcE3i1t1lWmf5dnpetM0gPjk1S2uBOONz744HUEtY0+KeDmsLL2TzzD/i7m+S vNkt08PsLuda2ZYD75Vx0EATySk7o4krUvnYUF71+tp8ISPhv46SX7EGEs3Ol6hJRn iL1M44KCu0BYqz91o2fbEKy2INgDTnoyKXqSh0KkS97RgYeLZB4OIJXLKz8HmD21VN VRYWsS9zxy7hA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: QintaoShen , Nishanth Menon , Sasha Levin , kristo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 09/37] soc: ti: ti_sci_pm_domains: Check for null return of devm_kcalloc Date: Wed, 1 Jun 2022 09:55:54 -0400 Message-Id: <20220601135622.2003939-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220601135622.2003939-1-sashal@kernel.org> References: <20220601135622.2003939-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_065638_595266_BFE19830 X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: QintaoShen [ Upstream commit ba56291e297d28aa6eb82c5c1964fae2d7594746 ] The allocation funciton devm_kcalloc may fail and return a null pointer, which would cause a null-pointer dereference later. It might be better to check it and directly return -ENOMEM just like the usage of devm_kcalloc in previous code. Signed-off-by: QintaoShen Signed-off-by: Nishanth Menon Link: https://lore.kernel.org/r/1648107843-29077-1-git-send-email-unSimple1993@163.com Signed-off-by: Sasha Levin --- drivers/soc/ti/ti_sci_pm_domains.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c index 8afb3f45d263..a33ec7eaf23d 100644 --- a/drivers/soc/ti/ti_sci_pm_domains.c +++ b/drivers/soc/ti/ti_sci_pm_domains.c @@ -183,6 +183,8 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) devm_kcalloc(dev, max_id + 1, sizeof(*pd_provider->data.domains), GFP_KERNEL); + if (!pd_provider->data.domains) + return -ENOMEM; pd_provider->data.num_domains = max_id + 1; pd_provider->data.xlate = ti_sci_pd_xlate; -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel