Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5875C43334 for ; Sun, 5 Jun 2022 16:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351313AbiFEQ5N (ORCPT ); Sun, 5 Jun 2022 12:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbiFEQ5N (ORCPT ); Sun, 5 Jun 2022 12:57:13 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 762E025C0 for ; Sun, 5 Jun 2022 09:57:10 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id u12so24864135eja.8 for ; Sun, 05 Jun 2022 09:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4gqvv7SB+vS5l3sqUpll/2cHcxIjp6YvEKZyVVCwBAk=; b=PJUDXWiCMxR7AxgHes6RlyFPB4Hqhx0E/apkUeoejAP+4Qn4En61gOevroQ0A8O9tb U9S6gjEE35m0eRzkqnebWnEBkovvW9Dv6AjjQp86oGqgVON44begcZjF5JB8hgoU7XXq LvO9+z7uUIIXRoy28HKyqrMLWUWgpHl0BWRRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4gqvv7SB+vS5l3sqUpll/2cHcxIjp6YvEKZyVVCwBAk=; b=Sm8JxLox89AWPXMIuaNifGpcNBjAvR6+W8ES0GbxKZOUVJrp56Y/YuQIUWDagUE9Df E9BwUcI3do79agNzo5oSUeDZ76PeKqEAxVPHCNRcVOEEexZ0kyPkxuk2PrOYSEAb6JVU wKVGRK25mWKei3Pw6IvLr/0gG8S80749toQMpXzwD8SqT/dV4KVMJf/yaM0KrXjp1bHI JnTRwxg5eZnm4+dg0kJjZ5fMK4eRxAKKrK/GvWMexkYSpRiuG5BOdAmWmKYaPKN3C0Vr fNV6FykJfLSOgV4h0zQEpA8uI3YWmzVh2C5QD25btrsJivrMfxPW1FrK6GtoknL3eHiz k0iw== X-Gm-Message-State: AOAM532FRwkZmU7s6hFysdwuhR1tej6B6Vt+VT2hWy+3CtoLv25ixngQ m6dT58z+0oJd0HQah2bPznfaaQ== X-Google-Smtp-Source: ABdhPJwMquTNTd2K8G7UERrgOxRkssN9xrKIq+cVSgfXCiGbnl4ACZB2UjmWZBzzwjwGLTrluADy0g== X-Received: by 2002:a17:906:c797:b0:711:8c01:32d4 with SMTP id cw23-20020a170906c79700b007118c0132d4mr4733057ejb.205.1654448229001; Sun, 05 Jun 2022 09:57:09 -0700 (PDT) Received: from localhost.localdomain (mob-83-225-9-201.net.vodafone.it. [83.225.9.201]) by smtp.gmail.com with ESMTPSA id b12-20020a170906660c00b0070e3f58ed5csm3260761ejp.48.2022.06.05.09.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 09:57:08 -0700 (PDT) From: Michael Trimarchi To: Matti Vaittinen , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list) Cc: Dario Binacchi , linux-amarula@amarulasolutions.com, linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list) Subject: [RFC PATCH 1/3] clk: bd718x7: Clean up the code, no functional changes Date: Sun, 5 Jun 2022 18:57:01 +0200 Message-Id: <20220605165703.1565234-2-michael@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220605165703.1565234-1-michael@amarulasolutions.com> References: <20220605165703.1565234-1-michael@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Signed-off-by: Michael Trimarchi --- drivers/clk/clk-bd718x7.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c index ac40b669d60b..04cc0beb67df 100644 --- a/drivers/clk/clk-bd718x7.c +++ b/drivers/clk/clk-bd718x7.c @@ -81,27 +81,28 @@ static int bd71837_clk_probe(struct platform_device *pdev) struct bd718xx_clk *c; int rval = -ENOMEM; const char *parent_clk; + struct device *dev = &pdev->dev; struct device *parent = pdev->dev.parent; struct clk_init_data init = { .name = "bd718xx-32k-out", .ops = &bd71837_clk_ops, + .num_parents = 1, }; enum rohm_chip_type chip = platform_get_device_id(pdev)->driver_data; - c = devm_kzalloc(&pdev->dev, sizeof(*c), GFP_KERNEL); + c = devm_kzalloc(dev, sizeof(*c), GFP_KERNEL); if (!c) return -ENOMEM; - c->regmap = dev_get_regmap(pdev->dev.parent, NULL); + c->regmap = dev_get_regmap(parent, NULL); if (!c->regmap) return -ENODEV; - init.num_parents = 1; parent_clk = of_clk_get_parent_name(parent->of_node, 0); init.parent_names = &parent_clk; if (!parent_clk) { - dev_err(&pdev->dev, "No parent clk found\n"); + dev_err(dev, "No parent clk found\n"); return -EINVAL; } switch (chip) { @@ -119,7 +120,7 @@ static int bd71837_clk_probe(struct platform_device *pdev) c->mask = CLK_OUT_EN_MASK; break; default: - dev_err(&pdev->dev, "Unknown clk chip\n"); + dev_err(dev, "Unknown clk chip\n"); return -EINVAL; } c->pdev = pdev; @@ -128,15 +129,15 @@ static int bd71837_clk_probe(struct platform_device *pdev) of_property_read_string_index(parent->of_node, "clock-output-names", 0, &init.name); - rval = devm_clk_hw_register(&pdev->dev, &c->hw); + rval = devm_clk_hw_register(dev, &c->hw); if (rval) { - dev_err(&pdev->dev, "failed to register 32K clk"); + dev_err(dev, "failed to register 32K clk"); return rval; } - rval = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get, + rval = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &c->hw); if (rval) - dev_err(&pdev->dev, "adding clk provider failed\n"); + dev_err(dev, "adding clk provider failed\n"); return rval; } -- 2.25.1