Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C000CCA473 for ; Mon, 6 Jun 2022 18:36:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C68388421F; Mon, 6 Jun 2022 20:36:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rB8bZ/X0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8E1E983C61; Mon, 6 Jun 2022 20:36:27 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 00D4183C61 for ; Mon, 6 Jun 2022 20:36:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id az35so4335110qkb.3 for ; Mon, 06 Jun 2022 11:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7jO6w1XEtyix7/ooqegPNWQ+v1E7KnM0JQ5KKPHC8M4=; b=rB8bZ/X0772hR5XhYSLEl7hNFfVDTMPRWb4lDPfeJ8fxjsFMuVjcftg7LTZIMh+QiZ sfrkSHU3BVAenUW0jdn+X0d6H9uxZ+cywim710JyioI8CHj5N0qX7NTDa8t0LRyGMe5u ae+GgD16V8X7eDiieIcys3u3qQj40uNM4pxio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7jO6w1XEtyix7/ooqegPNWQ+v1E7KnM0JQ5KKPHC8M4=; b=0V8SjvYNCVWKyk78+7sOjgplBYGUQYWevUrDor49O4laUXtWQghD0eWb7NSR2yGYtF OlLcaLOW80tRyfCg708Cm1OHakeo07+T38dZIl0R+a8qQeIIBqbelszKL3bBQPHbZOqs y1N46qoPt68S7IHLgpJIeik0JOr9dWcvbI6O/8KMfnRcTKYImpZc6Ju8x59kxBKP4vV6 COtTmFm3DIfmLLXJ3Pvd9JZvti8amGQFfgsV53SDY0lQTPwRmkTuSzrIO/LvLrE3K5P9 0TJ2x5OaXRabHaFwP/kEsZ9KI89ZPlOEd+doWz6mHdSXG0Lgla58Nm2LdHYdPQ7BFd8v DI+w== X-Gm-Message-State: AOAM531PAAzE1YSdyq0JKOYt69k5yS+lkuZFbfWNnHS38HiNa9ogGqse V4qtVhHGO3okRQ3DT3wt76e8Sw== X-Google-Smtp-Source: ABdhPJw7L3pPiJ5yqDwOXOaFnAQuNzdEJFcmu36B0E5DbKI6XF4wrWrUyOIxUamdQR+NmbLNX/lJqQ== X-Received: by 2002:a05:620a:4723:b0:6a5:8d56:cad9 with SMTP id bs35-20020a05620a472300b006a58d56cad9mr17565966qkb.134.1654540583718; Mon, 06 Jun 2022 11:36:23 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id f28-20020ac840dc000000b00304d8ddf416sm9455059qtm.94.2022.06.06.11.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 11:36:22 -0700 (PDT) Date: Mon, 6 Jun 2022 14:36:20 -0400 From: Tom Rini To: Rasmus Villemoes Cc: Stefan Roese , u-boot@lists.denx.de, Gaurav Jain , dullfire@yahoo.com Subject: Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash() Message-ID: <20220606183620.GA1958597@bill-the-cat> References: <20220429133444.419224-1-sr@denx.de> <111657a7-ea22-e306-8498-c6d3be218e71@prevas.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sDhuxz86kt5qlkuV" Content-Disposition: inline In-Reply-To: <111657a7-ea22-e306-8498-c6d3be218e71@prevas.dk> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --sDhuxz86kt5qlkuV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2022 at 07:43:52PM +0200, Rasmus Villemoes wrote: > On 29/04/2022 15.34, Stefan Roese wrote: > > While working on an LX2160 based board and updating to latest mainline > > I noticed problems using the HW accelerated hash functions on this > > platform, when trying to boot a FIT Kernel image. Here the resulting > > error message: > >=20 > > Using 'conf-freescale_lx2160a.dtb' configuration > > Trying 'kernel-1' kernel subimage > > Verifying Hash Integrity ... sha256Error: Address arguments are not = aligned > > CAAM was not setup properly or it is faulty > > error! > > Bad hash value for 'hash-1' hash node in 'kernel-1' image node > > Bad Data Hash > > ERROR: can't get kernel image! > >=20 > > Testing and checking with Gaurav Jain from NXP has revealed, that this > > alignment check is not necessary here at all. So let's remove this > > check completely. >=20 > Any chance this could make it into 2022.07? I've put this in my -rc5 queue now. --=20 Tom --sDhuxz86kt5qlkuV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKeSSAACgkQFHw5/5Y0 tyzf8Av/UD+JXKP24524sQmKPkToU1YWEzocUVB16LntgS8SqiBnH2BV+1Ltatzk DJCIEWnSOmCxLi1ktQM+ZcPmsTWUqt/T/scRdomqNZI1PHQLBeBSjp3DApvj97zS bgVTmEEQvK8bAHbIXhx84IGbcXwKxb7es/dGzkxND+hCVU4L7bGopjsj5fgokSKd vaOOsx9/5zzIlI9VKVuf7hY1w5XUnSK1g1y6RX0KfxGPTys7IoNJoR9bMiPVfYKK POJANrdrA0LWshGqXd1g7oIGbHU1SY4Uu+WVQTCn9jjnpzk+y3D104kUV5G02Um0 99TfzgIijibwzgu7jaTLWCYGceDeLABrWwUgXpOvoMM0xatb8UOB2yCWtFBoHIdb 8mRMJgM/bTaI/Dxp881ktnZO6xiiN5h0/LCJMJK0AoWzfM2dgOF9NzXnQwruCG1c zOSwUrmmnR+ofCUY52KFMPmsVDHy6opf+XsmelIFAu3o1ASg6PeNTUEqnlSoDQwQ tK7T1fWC =jI3X -----END PGP SIGNATURE----- --sDhuxz86kt5qlkuV--