Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0351BC433EF for ; Thu, 9 Jun 2022 19:21:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 183C4843AF; Thu, 9 Jun 2022 21:21:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="N6nLpscs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 955A98432E; Thu, 9 Jun 2022 21:21:18 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DFB9F843CC for ; Thu, 9 Jun 2022 21:21:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id f13so4429427qtb.5 for ; Thu, 09 Jun 2022 12:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uBssnF5z/F+vKL6rc/tBqPi111Yz8pNAZQQVO/Gl+dM=; b=N6nLpscsSTa8P40s3Y2d7WZH28gSycr3kjpqRwK3lRFJNfkH4XFVEVsSwo60UNAhDD taECJj4I3aKr9r2x3kIUGmWkuK9/eEEuR7RC+xNmaDXBPOvc1Xy5Qk8Xg+n2gT4YGEcw EQj2SihqeRNWrnhWlPsO2pxcw0Sf4O9yKlvxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uBssnF5z/F+vKL6rc/tBqPi111Yz8pNAZQQVO/Gl+dM=; b=1U8AnHQSzFw542/P1Jvk4opPG90yv3EuffUxdR8Pr/EiZe2FklEj20Jg3H5Ta7zeAb mjSW6E+wToKlhkUl1gDerV/Qmml6j1ITWPVf462k27pdRncdqqdgbCuj+lZCtWRaYh8N Agp/kmfegkCP77U9w9P+Z7EpXg+yYfGnoNf2XYq/iGfiV7UhbsjNLcoNzCNq6B/KEcY+ vKhC1rLMoFqZZeDUTSChrA6LE+XnIAoexZPM/y6AqdVtnQxzkaDMOCv4oWJ19fZ3RxyH xyK7H3Ogv7DBj5QN0WY1u5epTaSPl4nww3Syq2a9unvUqB9tJ4omQAfzKBLB1GLxqW1n TqOQ== X-Gm-Message-State: AOAM531A11+/IdPmq2OWtr+Xt4sfe3aOEtVafYhYF9gzvUftKzq0u+Zl 9TTl/hmE9W9nDspQq7dNuNLASwvFEaa58Q== X-Google-Smtp-Source: ABdhPJxxcytIZvrGB8fAmsS5ZeGqxy2WfE5asqkNiA3BDevWuLqEOGn28A3Y9vekpeghwPNjHe+b+w== X-Received: by 2002:ac8:5b87:0:b0:2f3:cef0:cd7d with SMTP id a7-20020ac85b87000000b002f3cef0cd7dmr33285473qta.428.1654802474424; Thu, 09 Jun 2022 12:21:14 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id de13-20020a05620a370d00b006a6d7c3a82esm7133392qkb.15.2022.06.09.12.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 12:21:13 -0700 (PDT) Date: Thu, 9 Jun 2022 15:21:11 -0400 From: Tom Rini To: Minkyu Kang Cc: u-boot@lists.denx.de Subject: Re: [PATCH 07/18] Convert CONFIG_USB_XHCI_EXYNOS et al to Kconfig Message-ID: <20220609192111.GG2484912@bill-the-cat> References: <20220608122440.4114272-1-trini@konsulko.com> <20220608122440.4114272-7-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aDj5WtVma0yWCzS8" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --aDj5WtVma0yWCzS8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 09, 2022 at 10:12:20AM +0900, Minkyu Kang wrote: > Hi, >=20 > 2022=EB=85=84 6=EC=9B=94 8=EC=9D=BC (=EC=88=98) 21:26, Tom Rini =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: >=20 > > This converts the following to Kconfig: > > CONFIG_USB_XHCI_EXYNOS > > CONFIG_USB_EHCI_EXYNOS > > > > Signed-off-by: Tom Rini > > --- > > drivers/usb/host/Kconfig | 16 ++++++++++++++++ > > include/configs/exynos5250-common.h | 5 ----- > > include/configs/exynos5420-common.h | 2 -- > > include/configs/odroid.h | 3 --- > > include/configs/odroid_xu3.h | 3 --- > > include/configs/smdk5420.h | 1 - > > 6 files changed, 16 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > > index 5d0855ffcc79..413bec0f4a1a 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -32,6 +32,14 @@ config USB_XHCI_DWC3_OF_SIMPLE > > Support USB2/3 functionality in simple SoC integrations with > > USB controller based on the DesignWare USB3 IP Core. > > > > +config USB_XHCI_EXYNOS > > + bool "Support for Samsung Exynos5 family on-chip xHCI USB > > controller" > > + depends on ARCH_EXYNOS5 > > + default y > > + help > > + Enables support for he on-chip xHCI controller on Samsung Exy= nos5 > > + SoCs. > > + > > config USB_XHCI_MTK > > bool "Support for MediaTek on-chip xHCI USB controller" > > depends on ARCH_MEDIATEK > > @@ -157,6 +165,14 @@ config USB_EHCI_ATMEL > > ---help--- > > Enables support for the on-chip EHCI controller on Atmel chip= s. > > > > +config USB_EHCI_EXYNOS > > + bool "Support for Samsung Exynos EHCI USB controller" > > + depends on ARCH_EXYNOS > > + default y > > + ---help--- > > + Enables support for the on-chip EHCI controller on Samsung Ex= ynos > > + SoCs. > > + > > config USB_EHCI_MARVELL > > bool "Support for Marvell on-chip EHCI USB controller" > > depends on ARCH_MVEBU || ARCH_KIRKWOOD || ARCH_ORION5X > > diff --git a/include/configs/exynos5250-common.h > > b/include/configs/exynos5250-common.h > > index 82cb8aff7b52..8d91a7de5cde 100644 > > --- a/include/configs/exynos5250-common.h > > +++ b/include/configs/exynos5250-common.h > > @@ -13,11 +13,6 @@ > > > > #define CONFIG_SYS_SDRAM_BASE 0x40000000 > > > > -/* USB */ > > -#define CONFIG_USB_EHCI_EXYNOS > > - > > -#define CONFIG_USB_XHCI_EXYNOS > > - > > /* DRAM Memory Banks */ > > #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */ > > > > diff --git a/include/configs/exynos5420-common.h > > b/include/configs/exynos5420-common.h > > index 5e1aba7692e0..35bf3c2fb4a7 100644 > > --- a/include/configs/exynos5420-common.h > > +++ b/include/configs/exynos5420-common.h > > @@ -27,6 +27,4 @@ > > #define CONFIG_LOWPOWER_FLAG 0x02020028 > > #define CONFIG_LOWPOWER_ADDR 0x0202002C > > > > -#define CONFIG_USB_XHCI_EXYNOS > > - > > #endif /* __CONFIG_EXYNOS5420_H */ > > diff --git a/include/configs/odroid.h b/include/configs/odroid.h > > index dec658dd13a3..11a4a409dbaf 100644 > > --- a/include/configs/odroid.h > > +++ b/include/configs/odroid.h > > @@ -149,9 +149,6 @@ > > /* Security subsystem - enable hw_rand() */ > > #define CONFIG_EXYNOS_ACE_SHA > > > > -/* USB */ > > -#define CONFIG_USB_EHCI_EXYNOS > > - > > /* > > * Supported Odroid boards: X3, U3 > > * TODO: Add Odroid X support > > diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h > > index 8d24a03b722d..476bde53572d 100644 > > --- a/include/configs/odroid_xu3.h > > +++ b/include/configs/odroid_xu3.h > > @@ -16,9 +16,6 @@ > > > > #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 = MB > > */ > > > > -/* USB */ > > -#define CONFIG_USB_EHCI_EXYNOS > > - > > /* DFU */ > > #define DFU_DEFAULT_POLL_TIMEOUT 300 > > #define DFU_MANIFEST_POLL_TIMEOUT 25000 > > diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h > > index f8d2fafd2788..48f6e27006f0 100644 > > --- a/include/configs/smdk5420.h > > +++ b/include/configs/smdk5420.h > > @@ -20,7 +20,6 @@ > > #define CONFIG_SYS_SDRAM_BASE 0x20000000 > > > > /* USB */ >=20 >=20 > Why don't you delete this line too? Missed that one, thanks. --=20 Tom --aDj5WtVma0yWCzS8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKiSCEACgkQFHw5/5Y0 tyzNggv/SL6Os77hYyVi9N6pcmdGrZZ62plRqE3bjmUnH1n/1qGzLtG6Az0C/R1e EGrONVqETmz9TBzYSX6GrEZ/msyH6nf5Gwq+Lpg+XGL2vQm07TTrYwdg+kc2xADz 8TTwun5JyjMSj3g8dCjNJZVjRmAEjL8iUvjla1Z7LNIfiB5xwIwGVy+coo58SEbz cI9K+X+7yCdJxM9pzfkajrBSgQiXmmTxp2lqtRGYSFkyWzLMZRoIceLTicWYpOfh mue/mZjkmlniGo1k+4QBY83jy7RPs/JDZuGM8GkTVBLQ9wb6yKSm4y/hJUB/faZg vgPZadvnEZZedsW25sfZ04FLMioDstyqJ+D58EeKkFJoRbdmJFRn9fx8sY49cSUy lqdyMdK7mOWFWEFo5xNQ2CGkIXdAx47r9rNSa24vT270w6StFF6ba96XnMmueUKe uPVdjMVFBAa0rgwWYRwZnpmILXFxmi9DA6RzNtAu1HWl+BVx5w98NkBxnfvmVgRn QZqMAQk/ =D8h9 -----END PGP SIGNATURE----- --aDj5WtVma0yWCzS8--