Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B61EC433EF for ; Mon, 13 Jun 2022 12:35:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D5F958443D; Mon, 13 Jun 2022 14:35:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655123736; bh=QMbSh00FXBXgT/H8IEyVuSmU4EU91cKHxSs7xX4vuKA=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=cWLyFQ9y6u2+Zi1dcvraKwQG7Lft9KiLsjTb39Mv5BuaQZm8rwlLsRbXH0g8kpxHG SkPsGPEyPkorZFCkex6ORM9I2x72XJs69bfNbUxlvv0pQa4ltJWpZksGS/JgErdEL1 ayBDCXpcOil+lQF3vXGlaFnPuzYVG31gJU0S12hfa4fPcCyGL1jLBeqy7Fu00/+Ke7 RwpYF30trGkOp4nWh0RQd7f8TGb66Ip8rX3rM/oHaqpu4KSsHLmiD3rY68nhBIg1JW zizuH9PDDd3ix5EtevBHG6UuX56TeLjUNQ/CbLNGLZV0J8OplwG2b4j6PZyg44hOXk GmDdCyUxjnkKw== Received: from tr.lan (ip-86-49-12-201.net.upcbroadband.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 4444E8443D; Mon, 13 Jun 2022 14:35:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655123734; bh=QMbSh00FXBXgT/H8IEyVuSmU4EU91cKHxSs7xX4vuKA=; h=From:To:Cc:Subject:Date:From; b=bEcI8nP7+wweD/NIulZIyXzPEOBu9lgHrzefPdLH4U10U3RxY3T8mWJRZHlUZbD6Z DIYm2FdILwA7ZuEUF37CzxzkDIfshEBzzUQBh192boZtuR8mdNTIjbnV9mZ1g8CnGH or/+yTyFZsU9MsKwBpTkfmFU8mRgNGPSv9XrAqHhmJlj3fcHckeedTJci2G5ADpx6K fkr3u79NEHcqnlHJwy5REk5QM4SFFWaFwa05Z2oC+9Cu6qLWNtgenoKuxCbdQeTTT4 qkvGxfAV3OrgOVubn7xdpWj6rQZk/fS/NbH9cqY+Lx4aBrpaXA90OYZUc7crykLUOP zGQS3vPC+Z+YQ== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan , Stefano Babic Subject: [PATCH] spi: nxp_fspi: Fix clock imbalance Date: Mon, 13 Jun 2022 14:35:25 +0200 Message-Id: <20220613123525.106686-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean The nxp_fspi_default_setup() is only ever called from nxp_fspi_probe(), where the IP clock are initially disabled. Drop the second disabling of clock to prevent clock enable/disable imbalance reported by clock core: " clk qspi_root_clk already disabled " Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- drivers/spi/nxp_fspi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index 607c953987b..579d6bac9b1 100644 --- a/drivers/spi/nxp_fspi.c +++ b/drivers/spi/nxp_fspi.c @@ -866,9 +866,6 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f) u32 reg; #if CONFIG_IS_ENABLED(CLK) - /* disable and unprepare clock to avoid glitch pass to controller */ - nxp_fspi_clk_disable_unprep(f); - /* the default frequency, we will change it later if necessary. */ ret = clk_set_rate(&f->clk, 20000000); if (ret < 0) -- 2.35.1