Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1C55C433EF for ; Wed, 15 Jun 2022 14:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kTiqRNaPyS9xTv63T9xe5mlqP+okjbw08upAEOe+zbA=; b=hd6sgXRbuo6oTM QO+HvsU+HgR1AIJK2Pvh75ZK8oCxGClmIZU3s29xAoH6GO8Tu7BBymzkDyA7fCass5HgQGmz+RBFG B42PgbMv5vsLdlF9l/WjjAf/LO7/Z6dT91G/JWnnkoOTfPx0ghEDcemDOmZj+oXZMC9CWMWKDZWM2 Eaf6ZxRJTWFh44iKUQ0jzK/abqk9m6yU+LE+0QV33BdxoDsdI/tLhDwNnmlnA18DIumorKItATY9m AD2EoHeCW7p4z6419CzZsdmdEv6Pbu4OcVwQon9OZsSQY2zlvGEQiOev5G2Tz8t/GH2Y62N+4s4t6 P7uPT+l0KyYGLjjRkLwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UTB-00F5fn-KV; Wed, 15 Jun 2022 14:58:09 +0000 Received: from m15112.mail.126.com ([220.181.15.112]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UT8-00F5ej-5c for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 14:58:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=0jHX1 o4T3dntA4QQGKBVqsC0i9BdSq13vyJ3pRtuELc=; b=jo77HEeM5iwfk8mkwfhif aiqq26y6WzJjk4uwj2CPx9ecJiJqBaj0jvzwd1LhTbBogRGsimK2Fo7DMT8EvghO rV1N98RNCAdtiv5AChaUgilxPwZHGATPj/SE3O1NUbDMdV4tJzh/PaN3OEqEgRqN Y0Uycx8sLVmWlTpLM5+iIA= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp2 (Coremail) with SMTP id DMmowAD3IQVo86liwUE+DQ--.47882S2; Wed, 15 Jun 2022 22:57:44 +0800 (CST) From: Liang He To: linux@armlinux.org.uk, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, windhl@126.com Subject: [PATCH] arm: mach-imx: Add missing of_node_put() in cpu-imx5.c Date: Wed, 15 Jun 2022 22:57:43 +0800 Message-Id: <20220615145743.3969705-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: DMmowAD3IQVo86liwUE+DQ--.47882S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF4rJryfZr43Cw45XryxXwb_yoWxKrX_t3 WfW3srJFWrJF4FvryUua1rWF4Fqws3Wr1rXFyIya1Yk3yqvrnxCrnFv3WIqry7Zr1agFW5 WF9rCr4Ykw1YkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMpnQ3UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGgMhF1-HZTdFJwACsF X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_075807_001638_1B6904A5 X-CRM114-Status: UNSURE ( 7.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In imx5_read_srev_reg(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/arm/mach-imx/cpu-imx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-imx/cpu-imx5.c b/arch/arm/mach-imx/cpu-imx5.c index ad56263778f9..103bf5be9b1b 100644 --- a/arch/arm/mach-imx/cpu-imx5.c +++ b/arch/arm/mach-imx/cpu-imx5.c @@ -30,6 +30,8 @@ static u32 imx5_read_srev_reg(const char *compat) iim_base = of_iomap(np, 0); WARN_ON(!iim_base); + of_node_put(np); + srev = readl(iim_base + IIM_SREV) & 0xff; iounmap(iim_base); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel