Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A2E8C43334 for ; Thu, 16 Jun 2022 14:01:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8034F113CBA; Thu, 16 Jun 2022 14:01:07 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B811113BB7 for ; Thu, 16 Jun 2022 14:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655388065; x=1686924065; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=j9vLcatMVJPnnXhtjMqwe5obhQ+DNLhDiaXCkSbfWX8=; b=LbB+tCprul2ghcNNZeQ4njZ6i+KDreFA8/3XkNf9KzW5cs6nbHbZ9+9x 3l4V31rU+1OngNclKcf+mBgYFy7ql1rc3plCNqFPcVWWO7rO44kiwwCGN PYig3ZIl3kmbiE9F8pQuT3luGogtM+yED+7IYB2LyLbXZOTOw1+r5tbxa DtCtPUJNe5ldFw/QUxrjngQCRH3XpXv3xDSo8eabkw7KfSJEXNXeTzw1Y DWJcjFillcmnuwcVXXfU6sFXWaJvJYSUFgjT9yhppj1RSoNh/snhlkvNA I5UazYlQbo4sY1tOvpJ4T42q3OBCiSNjALsCwm7UAVWanxfDVGN+ECZD6 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="262273824" X-IronPort-AV: E=Sophos;i="5.92,305,1650956400"; d="scan'208";a="262273824" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 07:01:04 -0700 X-IronPort-AV: E=Sophos;i="5.92,305,1650956400"; d="scan'208";a="613168543" Received: from mstokes1-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.213.198.82]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 07:01:02 -0700 From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org Date: Thu, 16 Jun 2022 15:00:56 +0100 Message-Id: <20220616140056.559074-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-gfx] [PATCH] drm/i915/fdinfo: Don't show engine classes not present X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Tvrtko Ursulin Stop displaying engine classes with no engines - it is not a huge problem if they are shown, since the values will correctly be all zeroes, but it does count as misleading. Signed-off-by: Tvrtko Ursulin Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via fdinfo") Cc: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_drm_client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c index 18d38cb59923..b09d1d386574 100644 --- a/drivers/gpu/drm/i915/i915_drm_client.c +++ b/drivers/gpu/drm/i915/i915_drm_client.c @@ -116,8 +116,9 @@ show_client_class(struct seq_file *m, total += busy_add(ctx, class); rcu_read_unlock(); - seq_printf(m, "drm-engine-%s:\t%llu ns\n", - uabi_class_names[class], total); + if (capacity) + seq_printf(m, "drm-engine-%s:\t%llu ns\n", + uabi_class_names[class], total); if (capacity > 1) seq_printf(m, "drm-engine-capacity-%s:\t%u\n", -- 2.34.1