Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C25A9C433EF for ; Fri, 17 Jun 2022 12:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sLX5wis+2UrByATUvN9W2cej8t9koQahgFYi2xx/hBk=; b=lMUeqA/5CHsyzD gfZqDpdn5BVtwuM5LhoYyWe11Wq90nmM9NdgbAj9J9RptAMnS1VWcdm/CymclR8eqWY/UGsyfKTvy 1Afy430XgqAs44XFu11XkY7mAkC5cc8pRQDs3BO1nwutDBbm42R7DsH7Bqngy9fJNvoKOUsfUxcZ8 y02S7vXmyEnhVlTAlTMrZHAz9JrapVKuYPTmC3bjLJuW9aqkhvP+x40qiMc1FB8rAxU3GZYfzjG+C 8UgbwrMW3dw6suho6iudF8sa6YCrwLX2A3e3S9Iq0T0CjefdPa4OD8324ZJBnZShthVzKL+i3uI/z mK/Yh9f5ag2ybIz16DZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Amq-007ZeB-OR; Fri, 17 Jun 2022 12:09:16 +0000 Received: from m15111.mail.126.com ([220.181.15.111]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Amm-007Zc0-Pn for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 12:09:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=TU2B9 l3UgYA6rfXiP8LSC5IMRVHoUDGy3g/V+/PidVk=; b=VHIIQ7hmoYv8Cd80eUAvj 4K/6vJW4qa/N7Nd6aHk2gH75i9iKFqFtA3l1IwqmRTsvggeSGIdEV8jaKpDxja0H u3QiqSf3INUpAGru3BzteqItFA1djU7NUWuw6CKL6A55Jbhz6WaaCVpWYrmSe9h/ KO0dhs6Z4vByn3HKmzcYkw= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp1 (Coremail) with SMTP id C8mowAAnKiY6bqxiHzkiEw--.31307S2; Fri, 17 Jun 2022 20:06:19 +0800 (CST) From: Liang He To: dinguyen@kernel.org, linux@armlinux.org.uk Cc: windhl@126.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm: mach-socfpga: Fix refcount leak bug in socfpga Date: Fri, 17 Jun 2022 20:06:18 +0800 Message-Id: <20220617120618.4047441-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: C8mowAAnKiY6bqxiHzkiEw--.31307S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruFyfGr18WFyxAryfuF4DJwb_yoWDWFc_XF 9agay7XryrAa9YgrW7ua1agan7C393Cwn0qr10vr1qkw4YqF47Ar9IkF92qryUWr4akFWf XanrJF1Yv392yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUIztUUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi2hwjF1uwMOTj7gAAsA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_050913_301550_80454726 X-CRM114-Status: UNSURE ( 8.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In socfpga_sysmgr_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/arm/mach-socfpga/socfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c index 9e4cb2ffd580..c561b3b7a9ee 100644 --- a/arch/arm/mach-socfpga/socfpga.c +++ b/arch/arm/mach-socfpga/socfpga.c @@ -36,12 +36,15 @@ static void __init socfpga_sysmgr_init(void) sync_cache_w(&socfpga_cpu1start_addr); sys_manager_base_addr = of_iomap(np, 0); + of_node_put(np); np = of_find_compatible_node(NULL, NULL, "altr,rst-mgr"); rst_manager_base_addr = of_iomap(np, 0); + of_node_put(np); np = of_find_compatible_node(NULL, NULL, "altr,sdr-ctl"); sdr_ctl_base_addr = of_iomap(np, 0); + of_node_put(np); } static void __init socfpga_init_irq(void) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel