Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67595C433EF for ; Sat, 25 Jun 2022 22:44:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1012D83E38; Sun, 26 Jun 2022 00:44:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="oJVJIvdV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2374083E65; Sun, 26 Jun 2022 00:44:21 +0200 (CEST) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A6FFE83D9C for ; Sun, 26 Jun 2022 00:44:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id 59so9851984qvb.3 for ; Sat, 25 Jun 2022 15:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kkUlKLaF23rxVHjjo/YGgOgQ762sMMRgABDfJqJjY40=; b=oJVJIvdVtYSm6chtnbrFBhVremK96kiRMrCiVO0eIvDBU8Xl3jaYf0hqEHs//c2pBy ntf0kx6S2drbOeSPe5DqnCvRC7ndLZmC3z5/RGyZT78Gug2bKe8RpcVEYjKrLo88GMy/ hCg9O0/lmCxXPJtJWQ3moV6gEf5fgcnMEWiSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kkUlKLaF23rxVHjjo/YGgOgQ762sMMRgABDfJqJjY40=; b=b+9Wws4cYfEUSqBuYY/+WVufLUnbDSHOe+/9xSSJ+fyJHxGdoBy7+TpWFwS2mrhW5h CIttr3rSE/D3scaS9JX3smQ+xq0OsHjcji7DnvWi+wvR7GYucYLOv2wwSueNv6GJ5ByK 7VvF1E+9ryfVnwO/I44X1DPCoIr5YCcd9C3OwBQnXR0+pKy0nMj39hyrcMPog5lNeVu8 wjTSCIcx911Dr6G592W8n/IAy7MRNwT+RLT6N/FxUaAFIrsTuAbbLf2i+deHCoL2QYaU 02xtEaHVtohPgYhsthOUnJvvItsAITLkRNlAROSpcLEpA4ouh/mBXcMrxPpU1EM1jYI5 0FAw== X-Gm-Message-State: AJIora+KJ0DScIRpKpTvSMFbk8mNVtXcRe6BuuIIxDchYoLBFbpwFkCy HIxZ4f0X65OCyswfsGSr8v/oAA== X-Google-Smtp-Source: AGRyM1tZ7mjKqylPoVIK0hxKo6pdU6mEM7U9h/MuBsp7gFFo7HoJJES22dldzTJShETcli9+RblDTg== X-Received: by 2002:ac8:58c2:0:b0:305:2ef6:3d68 with SMTP id u2-20020ac858c2000000b003052ef63d68mr4667499qta.381.1656197057247; Sat, 25 Jun 2022 15:44:17 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id c7-20020a05620a268700b006aef1e5eb87sm5224574qkp.24.2022.06.25.15.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 15:44:15 -0700 (PDT) Date: Sat, 25 Jun 2022 18:44:12 -0400 From: Tom Rini To: Soeren Moch Cc: u-boot@lists.denx.de Subject: Re: [PATCH 20/20] Convert CONFIG_SYS_BOOTM_LEN to Kconfig Message-ID: <20220625224412.GS2484912@bill-the-cat> References: <20220625150250.1398291-1-trini@konsulko.com> <20220625150250.1398291-20-trini@konsulko.com> <241c17fc-22dd-0fe8-62ba-37c2cfdfde8d@web.de> <20220625185136.GR2484912@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ml9GZqNpjY4wbe7i" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ml9GZqNpjY4wbe7i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 26, 2022 at 12:01:23AM +0200, Soeren Moch wrote: >=20 > > > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > > > > index 892d7c60d283..f0ecfd049d65 100644 > > > > --- a/configs/tbs2910_defconfig > > > > +++ b/configs/tbs2910_defconfig > > > > @@ -35,6 +35,7 @@ CONFIG_CMD_BOOTZ=3Dy > > > > # CONFIG_BOOTM_PLAN9 is not set > > > > # CONFIG_BOOTM_RTEMS is not set > > > > # CONFIG_BOOTM_VXWORKS is not set > > > > +CONFIG_SYS_BOOTM_LEN=3D0x1000000 > > > For tbs2910 there is another value set here - not the old default, not > > > the new one. Why? > > > This looks like a carefully chosen value, but very likely it is not. > > >=20 > > > Probably also this value is fine for this board, but for me it makes = no > > > sense to set a board specific value here. > > I don't follow you, sorry. Since tbs2910 isn't X86 or PPC or ARM64, > > it's using the current value instead. Before this patch > > include/configs/tbs2910.h includes include/configs/mx6_common.h which > > sets it to 0x1000000. > OK, I missed that part in the long patch, my bad. >=20 > As I wrote, all possible values are probably good for this board. > I just would prefer to use some default value (as before), since there > is no special requirement for this board in particular. To keep the > old value in this conversion of course makes sense. > > Which means I probably could put a || ARCH_MX6 in > > the Kconfig entry and drop out another 84 files (3 MX6 platforms set > > 0x4000000 instead today). > >=20 > That would make it more obvious that the old default is used for > these boards. But if you prefer the board specific defconfig > setting, that of course is also a valid solution. To be clear, here (and unless I otherwise note, all of the other conversions I've been doing) the intention is the same values on every platform, before and after. Many times the patches end up small because I can do a few default A if B lines and cover the vast majority if platforms. Sadly sometimes we get cases like this where in hindsight, a bigger default, or a more consistent default for every architecture should have been used, but wasn't. We can clean it up after but it needs to be separate so that someone can bisect a problem back to when the value was changed, not when it was migrated, if there's a problem. So this isn't a super platform dependent value, and should probably be something like 96MiB for 32bit ARM (I forget what the practical maximum image size is, I know I talked with rmk about it about a decade ago I think), and some other similar sane maximum for other platforms. But, a follow up to do that. --=20 Tom --ml9GZqNpjY4wbe7i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmK3j7MACgkQFHw5/5Y0 tyzgegv/bw9kfd0+cGOghtwMcdQBEkeVycWELKGfvlj7d5Tp8BwqMe+safnMkJmu o5dxpjyGbatEQsiLDNYe/pnOjmc2WOEiGlGQCbnpPXGJQZ1SiADJfLGJzYzM4RAB bTeg6WU0dOlZW1IkB0sK4DtqfcLX+x+YBo2dgVtJQ6imZdEIOsET3y5GovMmk/o8 nnoB6yZuq7augZ8hhaeZqCX0VShTNoMwSCziiI2XVw3wZ57Atl1Nxc1kvZb8liWq i824WAsD58PiORwr+CA81KcOZBnSi2NiGYHZoyBvhWdgL8G8lRxQkMT0enOAK1Lg gPm7STwjK8MO3bIdcVwqK5N7UIZ9E4el4ysizzRUAIVf23DoYjncQ53Ak8P+sH5t UVSgwldOnUPXGPHioxY4ChNUe0cSrebTaMeCfIkNTcLUEK/+T68ut49yG4MSNfLQ i7eBROi7lgpQ3lKfW6emxXaQHBmwE/RYgaeel47Wc4xCmV8goDpQ/1GKqqeOar2I 1gvBypnA =w7VH -----END PGP SIGNATURE----- --ml9GZqNpjY4wbe7i--