Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93AFA7A for ; Tue, 28 Jun 2022 02:20:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91363C385A9; Tue, 28 Jun 2022 02:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382849; bh=fnbjg2y5q4ORZyOyzWa2ckHS44WEdmOAUqXEWcMqugI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ka2Up4koD9AAuSD6T8RqcnF0V/6UYnJG6MyPk2oUtP8uC6Z/dm/0kn5Vc9NWWA0ZS jeaH3+Bpi6ZO/LMf3Ct++cIciM+sUXUe3s/ce539vInxug7CDqKBt43F7dm/wj2hI5 E8DD/vlnyDEmpZG86C2DWTvMFsn+9lKT+ZFzXaqITIwbVa0UdC+d12ap7bh6djbEqi TnC1lEa1EJJoJIJMjKbMV3zfgGJ8MFURdfg2bVtQG8PLf8hSAn8H3QSn3jtvSdnRuM clx5Fywu0BWJg7TYQUjsNaObkJq5L9tP8/8cmM55X+s8Snu0n07LqyvG8+A9tNNGnz 4Ur0Q6aVLl5yQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kees Cook , Nick Desaulniers , Tom Rix , llvm@lists.linux.dev, "Gustavo A . R . Silva" , Nathan Chancellor , Jakub Kicinski , Sasha Levin , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, leon@kernel.org, jiri@nvidia.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 49/53] hinic: Replace memcpy() with direct assignment Date: Mon, 27 Jun 2022 22:18:35 -0400 Message-Id: <20220628021839.594423-49-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628021839.594423-1-sashal@kernel.org> References: <20220628021839.594423-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Kees Cook [ Upstream commit 1e70212e031528918066a631c9fdccda93a1ffaa ] Under CONFIG_FORTIFY_SOURCE=y and CONFIG_UBSAN_BOUNDS=y, Clang is bugged here for calculating the size of the destination buffer (0x10 instead of 0x14). This copy is a fixed size (sizeof(struct fw_section_info_st)), with the source and dest being struct fw_section_info_st, so the memcpy should be safe, assuming the index is within bounds, which is UBSAN_BOUNDS's responsibility to figure out. Avoid the whole thing and just do a direct assignment. This results in no change to the executable code. [This is a duplicate of commit 2c0ab32b73cf ("hinic: Replace memcpy() with direct assignment") which was applied to net-next.] Cc: Nick Desaulniers Cc: Tom Rix Cc: llvm@lists.linux.dev Link: https://github.com/ClangBuiltLinux/linux/issues/1592 Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Tested-by: Nathan Chancellor # build Link: https://lore.kernel.org/r/20220616052312.292861-1-keescook@chromium.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/huawei/hinic/hinic_devlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c index 60ae8bfc5f69..1749d26f4bef 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c @@ -43,9 +43,7 @@ static bool check_image_valid(struct hinic_devlink_priv *priv, const u8 *buf, for (i = 0; i < fw_image->fw_info.fw_section_cnt; i++) { len += fw_image->fw_section_info[i].fw_section_len; - memcpy(&host_image->image_section_info[i], - &fw_image->fw_section_info[i], - sizeof(struct fw_section_info_st)); + host_image->image_section_info[i] = fw_image->fw_section_info[i]; } if (len != fw_image->fw_len || -- 2.35.1