Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A2DCC433EF for ; Tue, 28 Jun 2022 18:07:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BA246842E3; Tue, 28 Jun 2022 20:07:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="SyFPlwQp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A0C48843CE; Tue, 28 Jun 2022 20:07:56 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D52AA842DF for ; Tue, 28 Jun 2022 20:07:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCA2161AD5; Tue, 28 Jun 2022 18:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA1CBC341C6; Tue, 28 Jun 2022 18:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656439672; bh=9hSrLHQtMC6tB8w2jUl5nvWrj94Dqa+oevxL1+N5t0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SyFPlwQp15qrH0Edj7E3nwrRdG6iHKOvWftwAY4HWvTZmybfSU54KlqtEFydqLBr/ ZcIcT6+D+9RpySVbTvbExIQQl92YQVBmPwlIh7yXnSlLAC9eZFC0i04bXjX0PK6dkd ohNlt6sEd+/WOCSrv/4XTEvjfmsd9MJMMSb2j4nWyGEZgWtGJ4ePUcDVXswBGFrA5o GSJ+f3hghS/7kn5JauRaFUOnJdzFAMlGqQ+poSbYi8Q3ZQsGoOfoebZ9lNBiVQq0ZG tm6USn1E0KzAI35vuMOezQ6FsjquO06PGPn4SI30CbaBGmwyDSgvnNU4PNGeV5WjmY uHtWKvw00rZOQ== Received: by pali.im (Postfix) id 1A6527AE; Tue, 28 Jun 2022 20:07:49 +0200 (CEST) Date: Tue, 28 Jun 2022 20:07:48 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Priyanka Jain (OSS)" , "Peng Fan (OSS)" , Tom Rini Cc: Qiang Zhao , Shengzhou Liu , Alexander Graf , Bin Meng , Wolfgang Denk , Sinan Akman , "u-boot@lists.denx.de" Subject: Re: [PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector Message-ID: <20220628180748.rhigdsaik7a64trr@pali> References: <20220405134032.704-1-pali@kernel.org> <20220405134032.704-2-pali@kernel.org> <20220425123614.zh3vijo25z5b4plw@pali> <20220511205928.4bdkyxprz3u2z5yb@pali> <20220518105320.kv7vimvnu4xp3szc@pali> <20220604130238.k7ivwvmbxvvfcdjj@pali> <20220623171755.2qkrxy55qrbuvxbr@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220623171755.2qkrxy55qrbuvxbr@pali> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thursday 23 June 2022 19:17:55 Pali Rohár wrote: > On Saturday 04 June 2022 15:02:38 Pali Rohár wrote: > > On Wednesday 18 May 2022 12:53:20 Pali Rohár wrote: > > > On Wednesday 11 May 2022 22:59:28 Pali Rohár wrote: > > > > On Monday 25 April 2022 14:36:14 Pali Rohár wrote: > > > > > On Monday 25 April 2022 05:25:34 Priyanka Jain (OSS) wrote: > > > > > > >-----Original Message----- > > > > > > >From: U-Boot On Behalf Of Pali Rohár > > > > > > >Sent: Tuesday, April 5, 2022 7:11 PM > > > > > > >To: Priyanka Jain ; Qiang Zhao ; > > > > > > >Shengzhou Liu ; Alexander Graf ; > > > > > > >Bin Meng ; Wolfgang Denk ; Sinan > > > > > > >Akman > > > > > > >Cc: u-boot@lists.denx.de > > > > > > >Subject: [PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre- > > > > > > >PBL eSDHC boot sector > > > > > > > > > > > > > >QorIQ U-Boot binary for SD card booting compiled during build process (either u- > > > > > > >boot.bin or u-boot-with-spl.bin) cannot be directly loaded by QorIQ pre-PBL > > > > > > >BootROM. Compiled U-Boot binary first needs to be processed by Freescale > > > > > > >boot_format tool as described in doc/README.mpc85xx-sd-spi-boot > > > > > > > > > > > > > >BootROM requires that image on SD card must contain special boot sector. > > > > > > >Implement support for generating this special boot sector directly in U-Boot start > > > > > > >code. Boot sector needs to be at the beginning of the image, so when compiling > > > > > > >only proper U-Boot without SPL then it needs to be in proper U-Boot. When > > > > > > >compiling SPL with proper U-Boot then it needs to be only in SPL. > > > > > > > > > > > > > >Support can be enabled by a new config option > > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR. > > > > > > >Via other two additional options FSL_PREPBL_ESDHC_BOOT_SECTOR_START and > > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR_DATA it is possible to tune how final U-Boot > > > > > > >image could be stored on the SD card. > > > > > > > > > > > > > >Signed-off-by: Pali Rohár > > > > > > >--- > > > > > > > > > > > > Kindly rebase the series to master. > > > > > > > > > > > > Regards > > > > > > Priyanka > > > > > > > > > > Hello! Both patches still applies cleanly on master, just they depend > > > > > on another patch series (powerpc: mpc85xx: Fix and cleanup mpc85xx code) > > > > > which I mentioned in cover letter and therefore needs V2 patch of > > > > > "powerpc: mpc85xx: Set TEXT_BASE addresses to real base values" which I > > > > > sent recently. > > > > > > > > I sent a new version v2 of this patch, see email: > > > > [PATCH v2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector > > > > > > Priyanka: PING > > > > PING? > > PING? PING? V2 now and still applies cleanly on top of next branch https://patchwork.ozlabs.org/project/uboot/patch/20220511185731.3000-1-pali@kernel.org/ And why v2 has "Changes Requested" state in above patchwork? I do not see any comment for v2 on mailing list nor on patchwork. So what is requested from me?