Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0BB0C433EF for ; Wed, 29 Jun 2022 13:47:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9E9AE83E68; Wed, 29 Jun 2022 15:47:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ZarvTkIL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F3CDB83E68; Wed, 29 Jun 2022 15:47:09 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9CAF2842C0 for ; Wed, 29 Jun 2022 15:47:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id z16so7160452qkj.7 for ; Wed, 29 Jun 2022 06:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+z5tsu2JmR/rNQ3JEMALWTuRDWyRQUF/SRmxLl1XSfE=; b=ZarvTkILHlC0JVxm1ZEN614rHHoPONtEWl0tvhziWbHtRq28VZPzaCP/nGweV1TOHH ptf5Bxfwgvm86PikGynqSrc4tG5y3dkKl7/Wd/cZ+FJ755L/SBCcqtEmKYel863r3TzY 93/2Z9pOwT/hSuOsNjByfVBVfAI96DKwBdzdc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+z5tsu2JmR/rNQ3JEMALWTuRDWyRQUF/SRmxLl1XSfE=; b=fvLvg024BUdH6g5VFJio7Md3qY8dkkT4NNlOi1vni/2Ddgpir3eKvLskgPtrhMYYKm hR1hKc6mIRsak5f9QVhs+C3rtu9enB50nEquIOYUHOzyR1E0Lv8uGQqPWKN9DVRPC+hL p2Tqt4bqX3PwKOCbLzDRhNSQnm7QIaGby2GUsxIHtm924HKqUnCEh1luOtI8OBH/pHKZ uAsatn6ncHIBuwX3lh+1W1u/YYhLJbgY6xchV9SBHsrBd469mJppylQOpauW1bjtPlFh 7GVtvS6wsxD69r1FvsD1V4jztTtxTe8F5f49ZfsTlP2kLJzbWjgaZmbaK15684NLa6bC R/Qw== X-Gm-Message-State: AJIora9zPQ0ky/MnOA06xbvp3j60S23dtvVaQbGctRaGZcl7WiEfemeq zOmQkvwBTRwni6weGIk5+HkZtg== X-Google-Smtp-Source: AGRyM1v20mvbzGMvGWHaws7ovrtJxRVRrS1cySQD0HbYjvRrow3wpIuu03ynSMjw69LB4I81eYp0IQ== X-Received: by 2002:a05:620a:2942:b0:6af:f7e:7b40 with SMTP id n2-20020a05620a294200b006af0f7e7b40mr2128962qkp.330.1656510426246; Wed, 29 Jun 2022 06:47:06 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id u3-20020a05620a454300b006aef6a244a4sm14302741qkp.129.2022.06.29.06.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 06:47:05 -0700 (PDT) Date: Wed, 29 Jun 2022 09:47:03 -0400 From: Tom Rini To: Michael Trimarchi Cc: u-boot@lists.denx.de, Ye Li , Han Xu , Andrea Scian , Stefano Babic Subject: Re: [PATCH] mtd: mxs_nand_spl: fix nand_command protocol violation Message-ID: <20220629134703.GF1146598@bill-the-cat> References: <20220621200510.15988-1-michael@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="R6d/YZw7aFPcgCGm" Content-Disposition: inline In-Reply-To: <20220621200510.15988-1-michael@amarulasolutions.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --R6d/YZw7aFPcgCGm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2022 at 10:05:10PM +0200, Michael Trimarchi wrote: > From: Andrea Scian >=20 > mxs_nand_command() implementation assume that it's working with a > LP NAND, which is a common case nowadays and thus uses two bytes > for column address. >=20 > However this is wrong for NAND_CMD_READID and NAND_CMD_PARAM, which > expects only one byte of column address, even for LP NANDs. > This leads to ONFI detection problem with some NAND manufacturer (like > Winbond) but not with others (like Samsung and Spansion) >=20 > We fix this with a simple workaround to avoid the 2nd byte column address > for those two commands. >=20 > Also align the code with nand_base to support 16 bit devices. >=20 > Tested on an iMX6SX device with: > * Winbond W29N04GVSIAA > * Spansion S34ML04G100TF100 > * Samsung K9F4G08U00 >=20 > Tested on imx8mn device with: > * Windbond W29N04GV >=20 > Signed-off-by: Andrea Scian > CC: Stefano Babic > Signed-off-by: Michael Trimarchi > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! --=20 Tom --R6d/YZw7aFPcgCGm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmK8V9cACgkQFHw5/5Y0 tyy23wv+LhgusfhTcFz43Sisssi+UBH6kz7vFexB0THaS3EL2xJnS2gL+qyRYiF5 l6ofaP8qFWNwlDRXEWusDx2IHIz6KMZmLjS+nDBwHwldYjns5MIc5rbP6Jj8gPEw ibvNwFjGsZnDP9ApEE2j+avztrBkw9yELoBmQheembx7iZ+TH+VCTz9Ag2sl6pQK 0xOr9nQ4JNq7qeRLwE8LAwchnKl5jhFZLsTmyRZDrsaC9La+d6950Ybnv3ewTkky +4GgGDRUE2BI/I2nvZ9AftnB4haDSOqfu8PF6EofiMLZe5GJQCsoV19W44NHcUwO 9aBCxsWmvk1XXf7l8j0r5OBE/7dzs3HW6diqv5KmZxy1ast3HWHf/Rqpce20842S u75yordJMcFyIZpnJ9+H9885rPvolP+i5DZ5SqfkRC25LMlo1F0nlsnx91Pgcs2R YUwe2dFL06QM1gJuqfqvcJupoZMmcpmYRF6eAMPzCI7kOaWW3/0hJa0BgFfIoE1U IkW76Arf =rr4H -----END PGP SIGNATURE----- --R6d/YZw7aFPcgCGm--