Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 173DCC43334 for ; Sun, 3 Jul 2022 00:08:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 681D78448C; Sun, 3 Jul 2022 02:08:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JMY1RsgG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 129C5844AC; Sun, 3 Jul 2022 02:08:34 +0200 (CEST) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 68F33842C2 for ; Sun, 3 Jul 2022 02:08:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id b133so4422883qkc.6 for ; Sat, 02 Jul 2022 17:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tgxiIs4QqvWdL6hdcML+6nJf+kfUHKH8o861gwD1+e0=; b=JMY1RsgGu4KNorb2ckmySRbQTWWdQt/3wSuhSOI6xWLmjg8U1CvN1zCB1EzNVa8CID txgSaK6e8pqMeDUwIF8ax0oQZnTsOYQ2pY/vy9yjB4fediL2cFjFqrgwauDiBdxE82mk Dio2gpsIsuOXSKbFrrUnx+uu4+FVmE703P/1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tgxiIs4QqvWdL6hdcML+6nJf+kfUHKH8o861gwD1+e0=; b=kO20/4Dsyxg+VSqIhGfHYHI5xWqulAmSKBrkCOpiSXrcN0/GDUlwbD6ndinK6ozg8K ySHWuSGMq0bWAVmxWE26GJ94Zb/sh5fssaps+UnvxMwKbPtpATOVBdN8x0bJAOyDrwVz 6TJijmrAS7zs6YVu6cPbtvIm9jLl0nKI3EeVELMavtrE9TCPnwg51gxDIpSBYjesoiJ0 g4FQj0g4o96cEvW3kgng2ehHpcu1DTlTKz+PaFZ8Iunwz+SRC+1QDwbEoxxOdwm+1HzP PYIJGZkmG0K0pNKLvvG2nptdXl+IC1QXBUYERh4BlhKgG0PpHd1IupjwKK1LUDn0+an4 UN2A== X-Gm-Message-State: AJIora+CarJXVtYRE4WXhlj7V+LuD2BPnfdHyTA2Gf5a9BwWB/k7FIpa xfNKmcYgNAaucVOZzYVly76S3g== X-Google-Smtp-Source: AGRyM1sPgyK6mA5n+9PoQ4/GxRdDlAeHZ6vy+GBRKihPFYSnNvNqnVybxhZ0j7oouNBWvoHspMlwaQ== X-Received: by 2002:a05:620a:211d:b0:6af:9e8:f08d with SMTP id l29-20020a05620a211d00b006af09e8f08dmr15146472qkl.458.1656806909936; Sat, 02 Jul 2022 17:08:29 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id x5-20020a05620a448500b006a6d4261f40sm4850724qkp.111.2022.07.02.17.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 17:08:29 -0700 (PDT) Date: Sat, 2 Jul 2022 20:08:27 -0400 From: Tom Rini To: Marek Vasut Cc: Andre Przywara , Simon Glass , Patrice Chotard , u-boot@lists.denx.de Subject: Re: [PATCH] usb: host: ehci-generic: Fix error check Message-ID: <20220703000827.GV1146598@bill-the-cat> References: <20220702004510.10147-1-andre.przywara@arm.com> <937a67f7-1b0b-b3b8-1a9d-c6767fc84e0d@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QkXThh+LsIUYhkMH" Content-Disposition: inline In-Reply-To: <937a67f7-1b0b-b3b8-1a9d-c6767fc84e0d@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --QkXThh+LsIUYhkMH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 02, 2022 at 11:42:17PM +0200, Marek Vasut wrote: > On 7/2/22 02:45, Andre Przywara wrote: > > Commit 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks > > optional") improved the error check to cover the reset property being > > optional. However this was using the wrong error variable for the > > check, so would now never fail. > >=20 > > Use the correct error variable for checking the result of > > reset_get_bulk(), to actually report genuine errors. > >=20 > > Fixes: 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks o= ptional") > > Signed-off-by: Andre Przywara > > --- > > Hi, > >=20 > > apologies for messing up this simple patch of mine last month. I got > > confused by the mixed usage of "ret" and "err" in this function. This > > might endorse some cleanup, but I don't dare to touch this file again, > > especially not that late in the cycle. >=20 > Tom, can you pick this patch directly ? OK. --=20 Tom --QkXThh+LsIUYhkMH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLA3fQACgkQFHw5/5Y0 tyyZpAv+JSVSyan6Kpg+sLgSEH/5v8fSJ+doozCL9JgHLQJQAA1AUJu4/UnWcMqm 25QIGYMgJt+BoTyDXgEIoySlxObiQWtX7Va0QR5hqBKv88OMb3Gye0Q4YJ7njEEF lJ1tSFP0D40eXuPrICK9cyRnooSWAX2FZxZOj0+q6ojgUOy4HesifS/N9mT9x3Qc RLGCECkYY+XX6UPMiBuvOqa9VLaOtTY9vyuxXkvUbKwqwFGefAUkR7UEjvwZKXnI baHRRhAFuwsVKvaruDtrcnfmVfoTJOo6e/JSRiI8U7Zah+lxh7m/9BuIHDrAi6aX MjJVPSlLgrD9jtokkaA5yqLKEMwPugkeEivtxMbMdLYjuMqtute0bLS9c5j2l7k+ uRWfflHfjXzN3HRNEHrU5RInjJp5+MnR4gaQlQdzHdDMjFeNtnOe6GS2lt196zYx lvIDzWrK72y348LQ+zVou8XHMoxMTS/WhMWiAtZl1btyThAuYB0rBMwcQq8pUUwg KOqc6wWH =4K7N -----END PGP SIGNATURE----- --QkXThh+LsIUYhkMH--