Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59142C43334 for ; Mon, 4 Jul 2022 12:19:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49270844B1; Mon, 4 Jul 2022 14:19:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="sAbHW1uM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 019DD844B1; Mon, 4 Jul 2022 14:19:37 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 359EC844BF for ; Mon, 4 Jul 2022 14:19:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id b125so6639803qkg.11 for ; Mon, 04 Jul 2022 05:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ujonjm+4BGQdazyfWNM5D/2QjxiiRb60MT/coX/qW6Q=; b=sAbHW1uMRVw543/zfnzRezRdRiB2L+gNnVUVGbA6qdVamvC4ye+YR1xMM8+nKz5LOk qXyyuk71jyZJAywteWdXWvzaY9kpp/B3LzJtGx59FkMNhDJNRRm06IkOO5tInghAhiou pLUQU8BchKeJW4MIReMDj/kdc9al1g0T2Z1hM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ujonjm+4BGQdazyfWNM5D/2QjxiiRb60MT/coX/qW6Q=; b=Fk+FYhnJeBzhWOWYC/ZVbRIqFo4OBW4w050wEWbbXprO7JDA3+if0chmAgoWR184pS V+S1Jh67C64vYHiyNquff3xfohMCmdMTJQkOQ9hzPvlhO/pjMJHj4rK/8TGkbVFwIVqR mUVfVqyqSA88OTa1gI1cR63c7sk9OWK/MILd33OF7mcBDriTRgXMIWmfE+M9fGgOi0R8 Qh/Bj3DEOVDHJKfgN2RkPsS+SKtHBCAfflCjjuBONei2pg/owk0HTJslXgyyNeKojhIy pynAkwE1CqnvQJimuAvkkv30UeiAMr1thyH9fCrglLqf1FPgeYjAGC1VRMPUGcpdu26m iTtw== X-Gm-Message-State: AJIora+0Pu2zkUfpnDd5xFfCJiLZUslM7aVvvh/h0JFWBy+BAFuKuYHa cqITj18zZIWL/aRbr6igyZIdrg== X-Google-Smtp-Source: AGRyM1tMGCkayGDAXlYbQcX06d45X7qIcC71tNudjHM790F2Y43kfODKWhwNfGD+sCL5h+ZY7qJDSA== X-Received: by 2002:a05:620a:44c9:b0:6b2:1f49:f0f5 with SMTP id y9-20020a05620a44c900b006b21f49f0f5mr15545161qkp.327.1656937173012; Mon, 04 Jul 2022 05:19:33 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id u4-20020a05620a430400b006a6d7c3a82esm24521128qko.15.2022.07.04.05.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 05:19:32 -0700 (PDT) Date: Mon, 4 Jul 2022 08:19:30 -0400 From: Tom Rini To: Andre Przywara Cc: Marek Vasut , Simon Glass , Patrice Chotard , u-boot@lists.denx.de Subject: Re: [PATCH] usb: host: ehci-generic: Fix error check Message-ID: <20220704121930.GG1146598@bill-the-cat> References: <20220702004510.10147-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dvv5THrRrdqidt0E" Content-Disposition: inline In-Reply-To: <20220702004510.10147-1-andre.przywara@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --dvv5THrRrdqidt0E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 02, 2022 at 01:45:10AM +0100, Andre Przywara wrote: > Commit 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks > optional") improved the error check to cover the reset property being > optional. However this was using the wrong error variable for the > check, so would now never fail. >=20 > Use the correct error variable for checking the result of > reset_get_bulk(), to actually report genuine errors. >=20 > Fixes: 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks opt= ional") > Signed-off-by: Andre Przywara Applied to u-boot/master, thanks! --=20 Tom --dvv5THrRrdqidt0E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLC2tIACgkQFHw5/5Y0 tyxJ6Av5AQcWdvoZSTIc5WbI8ujZgs25AULFSJ+V1K8RonQ9hG8HJqyZEQlBsi0O cER2CVlbqINhwVubSKE36c6iFRjipTlzthFgm8Qjrh6psgG1ymKUXwMof9Ir26Ya H0fzt5k++Nlzt+/u1HGpuPLiMZCbjCJkVzjh0aPVWSOEYCZccrRAWh4kIn46Kiip B3by5OKrDAfYIE9f5Qa5J9ZSpO2wXr6d10Fj+Bk1nTw+aoJKt5lPq9H70gteS1uG WY5pUoEScrO8yEWa6ZOlFMMYisJKkLHfg1+4oqJ/Pzh6k4Smrf/c0fJ5OvX/5TaC WXboMw/3zVjoUQdZ2zrls0hCrjaUG1GWbFpLa5ixW9y3Kpb6bWH7/IrqK0Nk8JOJ 4S8HMYSn40vM+E8tWhigTqh9jDqyj1XdIoarQXm6Gvt22SnaXrrrXfgDMgZdMAhd VRSW+Hv9LXn4kzAHIPLS2E8yHnUF0j8K8qfmtX92WFkpOJT6OkIiv6NLvDZDrJfJ kcXSsa9o =2/Xa -----END PGP SIGNATURE----- --dvv5THrRrdqidt0E--