Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22AB8C433EF for ; Tue, 5 Jul 2022 11:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vJ59T2iwE8due8AsuTLV7SjmvVVLAYu2lQJQp3chQNA=; b=OsTanL/GI1yLeY hoErCDSRHWmQ8EcwCB5jVoBnlGh2iMAkpuxOQWXQwBC5zCcYLjBE6f1bBF2pYQm0CFux8YH6k11DY q1az7+IVoHIlPW2F3aiUqzOfytkhzn6zyWqGVrET9UrDojHQ9IXvv16NUMB82eCX6f3q2y41O7/4k QHsIgUHuQgeUpdzmWE3rn53To6Mm8Mpr1O3G63/hLxJUaCvLAJPjE80QA2l+jBpDF6qBHbbI2pVIA KZUwWlpC1aajO/nFLmInbtQNXUT6glom9cSKIYvWFNprxTYjPuNqLl2lW1rdf7e9QwsEuZiI+q60X vdNrZEiREA4rf3x0ZMlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8gk8-00HQ4h-KH; Tue, 05 Jul 2022 11:29:24 +0000 Received: from mail-m964.mail.126.com ([123.126.96.4]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8gk5-00HPvh-1y for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 11:29:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=JgG9U 1F/vxQ6PIWIZofa/NdAGx1dlcD8LIEj7MxfDGk=; b=P+ECRgkfarVlcpku9fFte FKrUFnvzb6ndZG7NmET1r3GZvO1zxGiedxFVC3zQyeQuHKQ0ub+Ld4r3aJXbWU+k DgtzMilZIot/8O9aMfTGRI5KQwHvL9z9kqQLRLTjn6+SQfNgnht+3SGYYpzOpkST qUPBDUjkHe+y0G0jzLHqRU= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp9 (Coremail) with SMTP id NeRpCgCX3clQIMRiOymuGA--.45822S2; Tue, 05 Jul 2022 19:28:18 +0800 (CST) From: Liang He To: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, windhl@126.com Subject: [PATCH] soc: brcmstb: pm: Add of_node_put() when the iteration breaks Date: Tue, 5 Jul 2022 19:28:15 +0800 Message-Id: <20220705112815.282835-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: NeRpCgCX3clQIMRiOymuGA--.45822S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur4fAr1ktFWrWw13Jr47urg_yoW8Xryfpr Wjkayaqry8WF4fKrZIy348uFWYk3WxK34vyFy7Kas3ursrJa4Fyr4S9a45Arn5tryrJw13 try8t34xuFnrZF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0z_MKu7UUUUU= X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi2hI1F1uwMWOJtAAAsu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_042921_485513_3C356EF3 X-CRM114-Status: UNSURE ( 8.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In brcmstb_pm_probe(), we should call of_node_put() when the for_each_matching_node() iteration breaks as the for_each_xx OF APIs will automatically increase and decrease the refcount in each iteration. Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") Signed-off-by: Liang He --- Patched file has been compiled test in 5.19rc5. drivers/soc/bcm/brcmstb/pm/pm-arm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c index 70ad0f3dce28..f5573d6efae3 100644 --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c @@ -732,11 +732,13 @@ static int brcmstb_pm_probe(struct platform_device *pdev) i = ctrl.num_memc; if (i >= MAX_NUM_MEMC) { pr_warn("too many MEMCs (max %d)\n", MAX_NUM_MEMC); + of_node_put(dn); break; } base = of_io_request_and_map(dn, 0, dn->full_name); if (IS_ERR(base)) { + of_node_put(dn); if (!ctrl.support_warm_boot) break; @@ -752,12 +754,14 @@ static int brcmstb_pm_probe(struct platform_device *pdev) for_each_matching_node(dn, brcmstb_memc_of_match) { base = of_iomap(dn, 0); if (!base) { + of_node_put(dn); pr_err("error mapping DDR Sequencer %d\n", i); return -ENOMEM; } of_id = of_match_node(brcmstb_memc_of_match, dn); if (!of_id) { + of_node_put(dn); iounmap(base); return -EINVAL; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel