Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F52FC433EF for ; Fri, 8 Jul 2022 09:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4gDe+WbQ9XtbsN8vAVQzpHYXxWT7+wtjvu9Gnj33trs=; b=rwD8Hw+YY3V9bh T4KGuGs5TAA+QpQJekdAKekExpzpSfsyxKgt2ofCrfU56a506cTn36xAuTX8xieRwMb5CI7aHepf7 gM99m+d0KVEMn7FCCIbr6br29OlK0rPoGEVYM3tH8nrDEGnTQ1AOMLRfa+aPTy1eQRrWZIF6hCV0x RR1IDAUl1DmRDr2jYiXqKv/dgjz7hDkFk+i/g57rfkZHya9KIDbdV8c7M+QnWMKbxBJ2MNaEDlMWk TBherxW+h4Ie3E4Ewvvr/1m8cppAgdAO+RqIjgItF1JQTUcVOZaYCjwCEeCGlbBS0+ntN2TF1ZiHk hnq44QGvWxQ29X6ma6Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9kbT-0030fm-CJ; Fri, 08 Jul 2022 09:48:51 +0000 Received: from m15113.mail.126.com ([220.181.15.113]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9kbM-0030Z5-6F for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 09:48:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=v4vlh uSnRdQ0BZa89rKzUPma8qh4sHzKBw+qaXTnors=; b=iuYrZmrj2C5ze99A9tmQp EutmNcceVGcSmchfW7YnlmfBXl9gLjUfvkDR7vBgppupJbX8xC9TysNXqVYDLpSH 4DRV922YXiqrwFEAdFL7SoBBbPchZX/67Ku1ulFMjgDad68kYZz6rBGFZwjkjIms E+TlAtf3CcFm+YZ/jx4v10= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp3 (Coremail) with SMTP id DcmowADHXY8b_cdil7SHEg--.20943S2; Fri, 08 Jul 2022 17:47:08 +0800 (CST) From: Liang He To: okaya@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org, linux-arm-kernel@lists.infradead.org, windhl@126.com Subject: [PATCH] dmaengine: qcom: hidma_mgmt: Remove redundant 'child' assignment. Date: Fri, 8 Jul 2022 17:47:07 +0800 Message-Id: <20220708094707.312292-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: DcmowADHXY8b_cdil7SHEg--.20943S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF4DuF17ZF1fGFW3ZrW5Wrg_yoWfGwc_K3 W8XrW3WF4qyFW0kF4kGr4Yqrn0vFykZF95ur40gFWaqFy5XFsrXrs8Zr18JrWkua17AFZY kr4kWryrKrWrKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_lApDUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbiuB04F2JVkRHbnQAAs7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_024844_610665_2E3BF505 X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In hidma_mgmt_of_populate_channels(), 'new_pdev->dev.of_node = child;' is not needed as it has been correctly done in platform_device_register_full(). Fixes: 9da0be80be6e ("dmaengine: qcom_hidma: configure DMA and MSI for OF") Signed-off-by: Liang He --- drivers/dma/qcom/hidma_mgmt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index 62026607f3f8..4655b15f93ff 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -387,7 +387,6 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) ret = PTR_ERR(new_pdev); goto out; } - new_pdev->dev.of_node = child; of_dma_configure(&new_pdev->dev, child, true); /* * It is assumed that calling of_msi_configure is safe on -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel