Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B12DAC433EF for ; Fri, 8 Jul 2022 10:07:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D8AC311387B; Fri, 8 Jul 2022 09:58:33 +0000 (UTC) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AD23113877 for ; Fri, 8 Jul 2022 09:58:32 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2E8AC32009AA; Fri, 8 Jul 2022 05:58:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 08 Jul 2022 05:58:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1657274310; x=1657360710; bh=Z0 DJz7H9tFVgAf3yqEQVf0DsRD1q9j47oH4cHKJNqCo=; b=Mqyr9J8nm3BDTCvIC/ /Qhe+PGyRhZ+HLECgWHGHE58qcAwACjwievIIOSS4uULe9J+nK12w+nJbtGuAcBR Z5Cytp8UcZdDcF/FmctgNv3dPmprZIr6FEmXp0723RS51Pu/DZVHmW1dU1mKiACu 742bNbf50THW4qKF2PewEIts4NBkUFhZ8DFC1k9kPnYmnbv63c9cwLkMLejJ2Kt3 O7u6mcOjP1OoLb2x/vhLhPk9UQfAEYcfroGtrTfqhRP5PW13WAqr4oBOUbl7lM+B T67t9/nhAKwBIfBQcK0EPDiJGjeu5i7wjrYFGhdgtemk824PLCK4JnRFH33PBhcm SHMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657274310; x=1657360710; bh=Z0DJz7H9tFVgA f3yqEQVf0DsRD1q9j47oH4cHKJNqCo=; b=stoGr4IPCFl5ZtbjJ8K/gPQAp07IT YCTdAvuf2XBpigRBFQ0bZdlAzVdCqdFPrs3rn63K5wbHSlYKoM66a9L0K5/O1scw 4iX5ui7XADHm1H3qptB/Ogkpm3hqqced6MUKnZntZ1YXgvFDzQjSGPNi8bI9r3H9 iX6caiXunwzOBW+/AQ5qKuFmm0nGYHZitSM41KXpSP9tGRRjIHcmXwvMBlF0ikT2 cB3/U63UueOMKoCLElbMX9RvDh6keHE7Oa8VxbffPhfPZ8FfunA/b+CGT9eyx96o pdwch7ZWDu1+dDqJuMCp5+GjK3pYfd68lrCeurSfw+GycDjFYZyfwU7+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeefteduhfekjeeihfetudfguedvveekkeetteekhfekhfdtlefgfedu vdejhfenucevlhhushhtvghrufhiiigvpeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 05:58:30 -0400 (EDT) From: Maxime Ripard To: Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Subject: [PATCH v4 27/69] drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call Date: Fri, 8 Jul 2022 11:56:25 +0200 Message-Id: <20220708095707.257937-28-maxime@cerno.tech> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708095707.257937-1-maxime@cerno.tech> References: <20220708095707.257937-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Dave Stevenson Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since we have a managed call to create our panel_bridge instance, the call to drm_of_panel_bridge_remove() at unbind is both redundant and dangerous since it might lead to a use-after-free. Acked-by: Thomas Zimmermann Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 7028a789919d..f18b05cee8bc 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -329,8 +329,6 @@ static void vc4_dpi_unbind(struct device *dev, struct device *master, { struct vc4_dpi *dpi = dev_get_drvdata(dev); - drm_of_panel_bridge_remove(dev->of_node, 0, 0); - drm_encoder_cleanup(&dpi->encoder.base); clk_disable_unprepare(dpi->core_clock); -- 2.36.1