Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C75CC433EF for ; Fri, 8 Jul 2022 10:14:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6AE11138D4; Fri, 8 Jul 2022 10:00:28 +0000 (UTC) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3D181138D4 for ; Fri, 8 Jul 2022 10:00:27 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8CEAB32009EA; Fri, 8 Jul 2022 06:00:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 08 Jul 2022 06:00:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1657274426; x=1657360826; bh=yk Jw2SEo4XpqErhqLa15PfxvMmjlMgg0/ajy7y8+cdI=; b=fj8+u8s3a2arZG0Rrk lThifzTcpYrIJLEA5CHuFFQkFCq/QMhfsPB45PzglsO/aWj4Q0COTFLCbMidjMeB J+trMkYuWCS1cHc642PgRe/c7RiktIDzYpqq6YelYYgyXJvIAyGcY2189FobZViG YrpkhNAmAyOWUDLrs043ftRC+INIKWY+aQFIEYFMCu9Pcav9zgzVAdWDpRB8mOnB KLCysFF3prDpdw1omYa8D4f0SRas/iDqs7It2Sdq89JICRS6RHbjnh55kZLSsmG9 nyPfvUgksTi1WyLX8YDkbW77CigNDqweZJClNMBfV15/n1nGM+WoU2A4PuDopv3V SfvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657274426; x=1657360826; bh=ykJw2SEo4XpqE rhqLa15PfxvMmjlMgg0/ajy7y8+cdI=; b=Quz8AvNGCzBKWF3auIc6yxFABPEIt YAul/MiE4SFJNxBeyWW6tyl+NTOcrn2rgTmT4C8IUiHz3Z0fPkyxD7nqNk5H5zTb ScyB1SxcNqNfM0atNhy690kjnVR2qGao5baYS7FvRnE7HSpfVVbNno+y5H0D1AHC Qqyy+9NBPyVwgRm7W1TglVRbAjA98jZqwslCXLBuHjz5Zk+gZQ4pzdVxVK3Yyb8Z hF8DyA69v5guHJuSGFlKS5qLMPsrucBMxsBSNmwg+QgQjt90hPl2z3A8u4aPAkHz 9CQJ3VD6i3HnC0hCrkKb6vTZAEaxQmbZl5iVp0euPQIpXIqWjk7VtXg8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeefteduhfekjeeihfetudfguedvveekkeetteekhfekhfdtlefgfedu vdejhfenucevlhhushhtvghrufhiiigvpeduvdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 06:00:25 -0400 (EDT) From: Maxime Ripard To: Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Subject: [PATCH v4 66/69] drm/vc4: perfmon: Add missing mutex_destroy Date: Fri, 8 Jul 2022 11:57:04 +0200 Message-Id: <20220708095707.257937-67-maxime@cerno.tech> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708095707.257937-1-maxime@cerno.tech> References: <20220708095707.257937-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" vc4_perfmon_open_file() will instantiate a mutex for that file instance, but we never call mutex_destroy () in vc4_perfmon_close_file(). Let's add that missing call. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_perfmon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_perfmon.c b/drivers/gpu/drm/vc4/vc4_perfmon.c index 79a74184d732..c4ac2c946238 100644 --- a/drivers/gpu/drm/vc4/vc4_perfmon.c +++ b/drivers/gpu/drm/vc4/vc4_perfmon.c @@ -133,6 +133,7 @@ void vc4_perfmon_close_file(struct vc4_file *vc4file) idr_for_each(&vc4file->perfmon.idr, vc4_perfmon_idr_del, NULL); idr_destroy(&vc4file->perfmon.idr); mutex_unlock(&vc4file->perfmon.lock); + mutex_destroy(&vc4file->perfmon.lock); } int vc4_perfmon_create_ioctl(struct drm_device *dev, void *data, -- 2.36.1