Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5332C433EF for ; Fri, 8 Jul 2022 20:22:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 28931845AA; Fri, 8 Jul 2022 22:22:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OkHR8hwZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3947E845C5; Fri, 8 Jul 2022 22:22:06 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAFD084594 for ; Fri, 8 Jul 2022 22:22:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id r2so8354572qtx.6 for ; Fri, 08 Jul 2022 13:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZwBDfLg67Ww8tNOcRd5KyMjYTLrd6X08mxZOs0fmfgk=; b=OkHR8hwZjz/mir8DxTT4Vew1NeleANzXXQvsyDfDD3XzfYemfmt9TnlZz/p0X6SNHX O19OoorTp+tNyDztlwEs+SAI3c8BLNcZTnWa1WkLv00rkkojb14MJTwo5ldckXd9HUfH huAOl8WofV3GSLEVyEIYmKNxnYeFEAxug1uNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZwBDfLg67Ww8tNOcRd5KyMjYTLrd6X08mxZOs0fmfgk=; b=D0VGeFe3ITvN7frYwCUVmuRv5nW/1zGJLihX6YhuKeT62f+ZNmQ+EELjj4eBt83SPo Z/8nMTCQbFjM97+I2dTwfWbZlxZv9REAF+x4jPRcTP7bGqUcTWe8W1xrg8X/etS0F8zg EVVevbeJYiTl/qZ3lMFsmsTv1+JSpCcNigApqh0xMQ9s9gNP3eCnulQVyVtFakyw5m8z 4jz7bd6/ezeqSDn5s6fBQ8zmFBfZNSMoxwxjoeCgjbN5sACCd8t6ivuBFVZMo85o5+Jx eVNMjTrik7YmDH8zXsm6xzhL5n4gt+BPUhZo1MozuUt7hbEV6o8QUYdOjdu2aBz3weRj /OpA== X-Gm-Message-State: AJIora+0OfZ+ORgY0F3njAmNAvRNnaaCD+dQufKRT34GX2oFXjAiiexp DSzYgFOOxVxdfcmknYaewoBR6Q== X-Google-Smtp-Source: AGRyM1uj8Pxfj8drkd46yp4QCzu853DeGTjdOUm3Y1nuNBrMU6nSRjJQEzjKrA7P/ICF3gXvhp7OyQ== X-Received: by 2002:a0c:aa4d:0:b0:470:90f6:12aa with SMTP id e13-20020a0caa4d000000b0047090f612aamr4184134qvb.60.1657311722658; Fri, 08 Jul 2022 13:22:02 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id ci27-20020a05622a261b00b00316dc1ffbb9sm22509284qtb.32.2022.07.08.13.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 13:22:01 -0700 (PDT) Date: Fri, 8 Jul 2022 16:21:59 -0400 From: Tom Rini To: Paul Barker Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: Re: [RFC PATCH 1/2] efi_loader: Add SPI I/O protocol support Message-ID: <20220708202159.GT1146598@bill-the-cat> References: <20220708094556.841333-1-paul.barker@sancloud.com> <20220708094556.841333-2-paul.barker@sancloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GYmUW1e1h/ofmaQW" Content-Disposition: inline In-Reply-To: <20220708094556.841333-2-paul.barker@sancloud.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --GYmUW1e1h/ofmaQW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 08, 2022 at 10:45:55AM +0100, Paul Barker wrote: > This addition allows UEFI applications running under u-boot to access > peripherals on SPI busses. It is based on the UEFI Platform > Initialization (PI) Specification, Version 1.7 Errata A (April 2020). > Only the core functionality required to discover SPI peripherals and > communicate with them is currently implemented. Other functionality such > as the legacy SPI controller interface and the ability to update the SPI > peripheral object associated with a particular SPI I/O protocol object > is currently unimplemented. >=20 > Since there are no open source implementations of this protocol to use > as an example, educated guesses/hacks have been made in cases where the > UEFI PI specification is unclear and these are documented in comments. >=20 > This implementation has been tested on the SanCloud BBE Lite and allowed > a UEFI test application to successfully communicate with a Micron > Authenta flash device connected via the SPI bus. >=20 > Signed-off-by: Paul Barker Thanks for doing this. I'll defer to Heinrich for implementation comments but please for the next round don't enable it by default, enable it on your platform. It's good to add this, but we don't want to grow most platforms in code size for it. --=20 Tom --GYmUW1e1h/ofmaQW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLIkeQACgkQFHw5/5Y0 tyzK8gv9FhKo52oI49biNXu8QazPQgjxJ5l3mQqe8hJKiL+3vTuCKegPRxakuxIm jd4fQz3h29nacdj1TAnEz1c562JWA3sMGjanAlOdakkiVzEUJ4mkMswihjXRKwD0 VLanrvUEqzmOowTzEb8wLLKPn9rGmGJ0T64RHEvIHiXdf/ZmAnlA8Whv+jajavMF +R+x3rWRh7h+hLfIg4UdvcY9aOEajVsmRA2IKRyc+S6A0acY9nZg9ERLLDmJozfw BOvZHADgNjlLkAcyBCfCTZrcCqDda+k0n5hOKbM3qgCq9SIfhP0bSdFAOr/njAOe HQBGVHdYlaEOPiM87fqNCcJUiF5tE3tyaQgJGyY2pul5bpEuVUhqa8RgzzbtVfHX H6raDWxU8YjDqgjTmfasllk18iOgkpH4PElWzwc9Os82G0FCXvpGKr7ljmadDj8g hrP9rOdLkxBDK2Q80hTf2IrForbb8iXXZl/66xlK7EUiB33cUbniYmg3gsjLCH2k cPjEKmgn =xV5S -----END PGP SIGNATURE----- --GYmUW1e1h/ofmaQW--