Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 518E7CCA47B for ; Mon, 11 Jul 2022 12:57:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C37983F14; Mon, 11 Jul 2022 14:57:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CCB7882119; Mon, 11 Jul 2022 14:57:48 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 145368400A for ; Mon, 11 Jul 2022 14:57:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77AFC1576; Mon, 11 Jul 2022 05:57:44 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1284D3F70D; Mon, 11 Jul 2022 05:57:42 -0700 (PDT) Date: Mon, 11 Jul 2022 13:57:40 +0100 From: Andre Przywara To: Jesse Taube Cc: u-boot@lists.denx.de, trini@konsulko.com, sbabic@denx.de, festevam@gmail.com, festevam@denx.de, giulio.benetti@benettiengineering.com, sjg@chromium.org Subject: Re: [PATCH v1] arm: relocate: Replace ADR instruction with non-pseudo-instruction Message-ID: <20220711135740.0eb67b22@donnerap.cambridge.arm.com> In-Reply-To: <20220710070953.933688-1-Mr.Bossman075@gmail.com> References: <20220710070953.933688-1-Mr.Bossman075@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, 10 Jul 2022 03:09:53 -0400 Jesse Taube wrote: Hi Jesse, > In Binutils 2.37 the ADR instruction has changed > use alternate instructions. Can you elaborate on this? What has changed exactly, and why? Looking at the commit you mention below I don't see an immediate problem that would require code changes? Also it speaks of forward references, but this one is not one? And I didn't spot any difference between 2.38 and 2.35, at least not in my isolated test (but I didn't bother to compile a whole stage 1 GCC with newer binutils yet). > The change causes armv7-m to not boot. What does "causes armv7-m to not boot" mean? It compiles fine, but hangs or crashes? Can you show the relevant disassembly from both binutils versions? And from trying to reproduce this minimally, do we need a ".syntax unified" in the .S file? > Signed-off-by: Jesse Taube > --- > arch/arm/lib/relocate.S | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S > index 14b7f61c1a..22c419534f 100644 > --- a/arch/arm/lib/relocate.S > +++ b/arch/arm/lib/relocate.S > @@ -78,7 +78,13 @@ ENDPROC(relocate_vectors) > */ > > ENTRY(relocate_code) > - adr r3, relocate_code > +/* > + * Binutils doesn't comply with the arm docs for adr in thumb2 > + * from commit d3e52e120b68bf19552743fbc078e0a759f48cb7 onward > + * to remove ambiguity explicitly define the pseudo-instruction > + */ > + mov r3, pc > + subs r3, #4 But this will break ARM, won't it? Because it would require to subtract #8? I mean there is a reason for this adr instruction, because this offset calculation is best left to the assembler. Not to speak of the fragility of assuming that the relocate_code label is pointing to the very first instruction. The ENTRY macro could also insert instructions. Cheers, Andre > ldr r1, _image_copy_start_ofs > add r1, r3 /* r1 <- Run &__image_copy_start */ > subs r4, r0, r1 /* r4 <- Run to copy offset */