Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18BE3C43334 for ; Mon, 11 Jul 2022 23:23:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1616A8407D; Tue, 12 Jul 2022 01:23:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kw5yofyy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 738998407B; Tue, 12 Jul 2022 01:23:34 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2A6F83FCC for ; Tue, 12 Jul 2022 01:23:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id p14so1473599qvo.9 for ; Mon, 11 Jul 2022 16:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iRcCyPGISWQdPDzqvVjSzCVCevFv2JRmsk5wkwoHt2o=; b=kw5yofyy/Frk0fO+9pYjxZINpSfpOuBn0lwa47ilftjyw7yVnzr3ELQnSB+kCO7Eey 49KB5nrvxP0NqWKHjW81kku8VP88W/RONcpA1oBKrZzqiMJBNx2qtKoveG2wZ7+wfedM 2sVONzWUudmyGEsm452a0LTcPYAe08DQNjtaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iRcCyPGISWQdPDzqvVjSzCVCevFv2JRmsk5wkwoHt2o=; b=Ub5fkUyDQwC2PcdSFNn28ubNcP3VSnDwdSZwbI5f0s6y6EeRuxhB5nswBfyvOhKOMj mxEL4Rm7rrqw8l4QLgJpMIoiFLhBFRArJHUR3Y34G8SN3VDoYniIl5dIFh79yo0a83XR j9WDnRpGRuvpNWBiltGsriHWj2nOFZQ3qzkYRBuRE3PVLtlmyXzer9pTbxfnC00hK322 5lpTORZS/XsTbSGuLQr/iRLz/Tc3Qie2z/kDldhgs9sblBkqm5lF9l1DtrxEo+Nmqb7s +DLqe84NEq2CHAFBdX8R+Y6mCHS+cq9BmfnKHgjYGht6iTwJbxgIT4m7nAhhIUwxNOGV G6cQ== X-Gm-Message-State: AJIora8dj9xjLvOfnQWnZ5+O1PPoKZSNrfQdwHsfUpHGFn/bxPfi22z1 YZ3yovLp+9YLvZmKpDMVo+O8gw== X-Google-Smtp-Source: AGRyM1sAxd4xG+uKoDGY4L7h767eeKLDq0CFu513ARGfvtC2yIROkS8QZILPWXv4I0Vjg5gQVl6PPg== X-Received: by 2002:a0c:e0cf:0:b0:473:8509:57bb with SMTP id x15-20020a0ce0cf000000b00473850957bbmr206995qvk.10.1657581809482; Mon, 11 Jul 2022 16:23:29 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id s7-20020a05620a254700b006a6b374d8bbsm8091616qko.69.2022.07.11.16.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 16:23:28 -0700 (PDT) Date: Mon, 11 Jul 2022 19:23:26 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Troy Kisky , Joe Hershberger , Wolfgang Denk , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig Message-ID: <20220711232326.GD1146598@bill-the-cat> References: <20220710114256.27322-1-pali@kernel.org> <20220710114256.27322-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uzZgEYsRWtwBzvQo" Content-Disposition: inline In-Reply-To: <20220710114256.27322-2-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --uzZgEYsRWtwBzvQo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 10, 2022 at 01:42:56PM +0200, Pali Roh=E1r wrote: > CONFIG_PREBOOT just cause putting "preboot=3DCONFIG_PREBOOT" into env lis= t. > Value CONFIG_PREBOOT=3D"run preboot" in defconfig is just nonsense and do= es > not do anything useful (it is infinite recursion). Config file for this > board already contains default preboot=3D env variable with correct value, > which has higher priority than CONFIG_PREBOOT and this is reason why > nonsense CONFIG_PREBOOT is ignored. >=20 > Remove nonsense and unused CONFIG_PREBOOT from nokia_rx51_defconfig file. >=20 > Signed-off-by: Pali Roh=E1r > --- > configs/nokia_rx51_defconfig | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig > index 309cf28269c1..46b794f168d9 100644 > --- a/configs/nokia_rx51_defconfig > +++ b/configs/nokia_rx51_defconfig > @@ -24,7 +24,6 @@ CONFIG_AUTOBOOT_MENU_SHOW=3Dy > CONFIG_USE_BOOTCOMMAND=3Dy > CONFIG_BOOTCOMMAND=3D"run sdboot;run emmcboot;run attachboot;echo" > CONFIG_USE_PREBOOT=3Dy > -CONFIG_PREBOOT=3D"run preboot" > # CONFIG_SYS_DEVICE_NULLDEV is not set > CONFIG_HUSH_PARSER=3Dy > CONFIG_SYS_PROMPT=3D"Nokia RX-51 # " These changes are actually a bit puzzling. There are other platforms that set preboot in their default environment, rather than via CONFIG_PREBOOT, and their final value ends up being the one set in CONFIG_EXTRA_ENV_SETTINGS rather than the empty string that CONFIG_PREBOOT is. I assume you've confirmed that at run-time you end up with preboot=3D"run preboot" being set, and not preboot=3D"long command" ? The difference between nokia_rx51 and the other platforms is, I think, LTO being enabled and maybe that leads to a different final value in the resulting environment. --=20 Tom --uzZgEYsRWtwBzvQo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLMsOsACgkQFHw5/5Y0 tyxzowwAqiiBUd8PTj/n0ZgTI+K//bE/47ajnfh8vII9YWuyArSobeZMQvaawswb S6PnetN54rnSMu+aJTr6s0+oXGmujxrt3lNMneFftn05iXvgAfhaKNve8B2xK2di X3rOAUa0XKqMxaqgRz4wA3ff5M75nHOWww/zvOHbH5l/NRGbwVoGzWcaf6WWvPro QAjO9hbqo864ZbsuuauByRNHjzWGoTs6l7P1OLFOXkFu8/lnyOZTuJOB47HQiOg2 4/VUzrAsbF3ZHc8Jd8KuZ1QF1iN1IW1+9dWN/3hIbNQkOxUsQsvpipb0N5DJgXFr QljYAoM8vLYwZQ6mMPyZQsnL3oK4LeU2U/fwfqSpt71cD+a+pI7Dqt/AaNnx7tky ST5OfKoSANA40RW/vJ4e4daryiZA9D9lk24ogP8a6Rz5osnpN469Nh876GnsycHy 2/d+Qx4F0L3Bzoe5MULhwWz09rowkzyeN4HRQTn1kqaeSs/mPc6yA7ZcSzmc0qPz e+FebYZf =hKKu -----END PGP SIGNATURE----- --uzZgEYsRWtwBzvQo--