Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44776C433EF for ; Wed, 13 Jul 2022 18:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232266AbiGMS0j (ORCPT ); Wed, 13 Jul 2022 14:26:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236705AbiGMS0g (ORCPT ); Wed, 13 Jul 2022 14:26:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AC4C2ED40 for ; Wed, 13 Jul 2022 11:26:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2D0A4B8211B for ; Wed, 13 Jul 2022 18:26:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7550C34114; Wed, 13 Jul 2022 18:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657736792; bh=qW56AZWwvLQ9bTSAfYRj9IAHRuRldX9n3lg7XSN/d1Q=; h=Date:To:From:Subject:From; b=ahUFoZGwd/e+IVfIvLfPRHh3QEVCzyOCkPaXeAZnSdWKu+tgYbxBMGkMN8qqkG66+ TQhaH67rV+Hg58XU3TqbRuRpaWBKgv+sr2maZ9FAIiuuqwbQsZOlFMSweBm2YX76tl oJwe/0qk7GtBpHWdkeH/1EC3AFjhMxzK6PAz/IQ8= Date: Wed, 13 Jul 2022 11:26:32 -0700 To: mm-commits@vger.kernel.org, sre@kernel.org, skhan@linuxfoundation.org, ndesaulniers@google.com, nathan@kernel.org, michal.lkml@markovi.net, mcgrof@kernel.org, masahiroy@kernel.org, lucas.demarchi@intel.com, keescook@chromium.org, john.ogness@linutronix.de, jani.nikula@linux.intel.com, gregkh@linuxfoundation.org, gpiccoli@igalia.com, dlatypov@google.com, corbet@lwn.net, brendanhiggins@google.com, atomlin@redhat.com, andriy.shevchenko@linux.intel.com, davidgow@google.com, akpm@linux-foundation.org From: Andrew Morton Subject: [merged] kunit-taint-the-kernel-when-kunit-tests-are-run.patch removed from -mm tree Message-Id: <20220713182632.C7550C34114@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The quilt patch titled Subject: kunit: taint the kernel when KUnit tests are run has been removed from the -mm tree. Its filename was kunit-taint-the-kernel-when-kunit-tests-are-run.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: David Gow Subject: kunit: taint the kernel when KUnit tests are run Date: Fri, 8 Jul 2022 12:48:46 +0800 Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run. Due to KUnit tests not being intended to run on production systems, and potentially causing problems (or security issues like leaking kernel addresses), the kernel's state should not be considered safe for production use after KUnit tests are run. This both marks KUnit modules as test modules using MODULE_INFO() and manually taints the kernel when tests are run (which catches builtin tests). Link: https://lkml.kernel.org/r/20220708044847.531566-3-davidgow@google.com Signed-off-by: David Gow Acked-by: Luis Chamberlain Tested-by: Daniel Latypov Reviewed-by: Brendan Higgins Cc: Aaron Tomlin Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Guilherme G. Piccoli Cc: Jani Nikula Cc: John Ogness Cc: Jonathan Corbet Cc: Kees Cook Cc: Lucas De Marchi Cc: Masahiro Yamada Cc: Michal Marek Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Sebastian Reichel Cc: Shuah Khan Signed-off-by: Andrew Morton --- include/kunit/test.h | 3 ++- lib/kunit/test.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) --- a/include/kunit/test.h~kunit-taint-the-kernel-when-kunit-tests-are-run +++ a/include/kunit/test.h @@ -277,7 +277,8 @@ static inline int kunit_run_all_tests(vo { \ return __kunit_test_suites_exit(__suites); \ } \ - module_exit(kunit_test_suites_exit) + module_exit(kunit_test_suites_exit) \ + MODULE_INFO(test, "Y"); #else #define kunit_test_suites_for_module(__suites) #endif /* MODULE */ --- a/lib/kunit/test.c~kunit-taint-the-kernel-when-kunit-tests-are-run +++ a/lib/kunit/test.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -501,6 +502,9 @@ int kunit_run_tests(struct kunit_suite * struct kunit_result_stats suite_stats = { 0 }; struct kunit_result_stats total_stats = { 0 }; + /* Taint the kernel so we know we've run tests. */ + add_taint(TAINT_TEST, LOCKDEP_STILL_OK); + if (suite->suite_init) { suite->suite_init_err = suite->suite_init(suite); if (suite->suite_init_err) { _ Patches currently in -mm which might be from davidgow@google.com are selftest-taint-kernel-when-test-module-loaded.patch