Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B5F9C433EF for ; Thu, 14 Jul 2022 14:09:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A9B39840CA; Thu, 14 Jul 2022 16:09:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="fSASQjZn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4192E840FF; Thu, 14 Jul 2022 16:09:24 +0200 (CEST) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1058D84070 for ; Thu, 14 Jul 2022 16:09:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Message-Id:Date: Subject:Cc:To:From:Content-Type:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=Mj6mt5kCLi4hc2mbgM338+q+tHrFDkopWa/mtS0LcZk=; b=fS ASQjZngP5D6VunKp0BEKzwHccXLIoyp+0mErU1bEsLHnh9FPhqoUvH9T6HCrYh/6rQu1Q4+yt4nYa tRM2/B4KSgHtumR2XL0ejgAT2BWFjVidMhm3qN0ZbViNaKSx/vJF3shpWuuw7dE/1bAmE2ivZM9BM xk3JuktDboRFrnPznfNgiTUknsAZfM83UdGEuw+6NB8ANWL+MuFeCSxsxuvUQ4xgqXjH1AyDaG/FZ JescnFIDJV0a0BUHmCNK9f+cEc+Q2oqqhKXgaO9jmg94j+/ZxhnQQ/H904evOaYiy34wNQ0RE4I7P EZ+I9qtdY+ZirCmpQuN2rnCFRsRGrz2Q==; Received: from [81.174.171.191] (helo=donbot.metanate.com) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oBzWn-0000ef-VV; Thu, 14 Jul 2022 15:09:19 +0100 From: John Keeping To: Andy Yan Cc: u-boot@lists.denx.de, John Keeping Subject: [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc Date: Thu, 14 Jul 2022 15:09:12 +0100 Message-Id: <20220714140912.74203-1-john@metanate.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Commit 6aa4fe3912 ("dm: core: Rename and fix uclass_get_by_name_len()") changed uclass_get_device_by_name() to an exact match when previously it behaved as a prefix match. The roc-cc code relied on this prefix match by only specifying part of the device name. Fix this by using the full name including the address. Signed-off-by: John Keeping --- board/firefly/firefly-rk3308/roc_cc_rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/firefly/firefly-rk3308/roc_cc_rk3308.c b/board/firefly/firefly-rk3308/roc_cc_rk3308.c index 28dcc2a690..bdf3cc03dc 100644 --- a/board/firefly/firefly-rk3308/roc_cc_rk3308.c +++ b/board/firefly/firefly-rk3308/roc_cc_rk3308.c @@ -70,7 +70,7 @@ int rockchip_dnl_key_pressed(void) { unsigned int val; - if (adc_channel_single_shot("saradc", 1, &val)) { + if (adc_channel_single_shot("saradc@ff1e0000", 1, &val)) { printf("%s read adc key val failed\n", __func__); return false; } -- 2.37.1