Date: Thu, 14 Jul 2022 20:30:11 +0200 (CEST) Message-Id: <202207141830.26EIUB9k026753@...2054...> From: Gert Doering In-Reply-To: <20220707035151.25469-1-selva.nair@...277...> References: <20220707035151.25469-1-selva.nair@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: Fix crash in xkey-provider in msvc builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net Taking the agreement from Arne as formal ACK (checked on IRC). I'm not sure I grok all the details of this, but I can attest that unit_tests/test_provider still works (on a 3.0.x build), and that calls the "xkey_load_generic_key()" function being modified here. So, this is good. Lev promised to verify MSVC builds early next week. Your patch has been applied to the master branch. commit 2b2e4d0ad5c3a309af8425be8e6e605975fb2a43 Author: Selva Nair Date: Wed Jul 6 23:51:51 2022 -0400 Fix crash in xkey-provider in msvc builds Signed-off-by: Selva Nair Acked-by: Arne Schwabe Message-Id: <20220707035151.25469-1-selva.nair@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24664.html Signed-off-by: Gert Doering -- kind regards, Gert Doering