Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBFF2C433EF for ; Mon, 18 Jul 2022 12:08:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2ABFA84019; Mon, 18 Jul 2022 14:08:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ZPiwS6s7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 568A484030; Mon, 18 Jul 2022 14:08:26 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A74A9819FC for ; Mon, 18 Jul 2022 14:08:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id k7so5564042qkj.2 for ; Mon, 18 Jul 2022 05:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wCPwZ8aea/TTsmWtq9Eak0gveN1bwsO4jVTVqyUrqLc=; b=ZPiwS6s722aKahknilWwHW2bdT7WyGk9+Rqm3uIscXtdmQYi3mgGcWUYOQfoAVka8w TAwL8IHTUtuJO2tWGYoZ+Qi9Ec51F7Y1oufKQLCX5epRbLZcDQJkNCwi/GEOMY9Ht3od o55qIgU+ZNfhFe7jex2spJxiTkOAsn+E+2buk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wCPwZ8aea/TTsmWtq9Eak0gveN1bwsO4jVTVqyUrqLc=; b=I0oa1fAnyLa7G0OkfCoVhp1z41JbMveZjSZgZ4wFEnLX4SEKizL2ZpeegAp/8UX7zo PzemT+1FbRkcduCWmsVBGjGBOXWLnNVM4qB0svFCFfPCQPD3I6VqHl6ocH2tKsbWNM4G TUpznwTjYG8dUBrJP29zF325Tp+qcrFL4e81RGiLlk97EoEPZqVTvudtp5qbOAO+RmKd 9wkRhdjmC+XuIcx0vE531/KEolmdc0l+GCd+g/RPqVrrTETc7WeM4OJFaa46ICQrDdDM PU8paon5m9k+iR2jnNPYArEACVeH/gqHJXpNzUzyOuh5hwRnll6+4sQw/5eTuKDtS/KZ dTEw== X-Gm-Message-State: AJIora8oINrfMUF37PJjjKPvnmU0MLF93HPF7tJ2WCZfaNtuL7S8p7aH t66v31+FnRdv7ANLd8z4mQeyLA== X-Google-Smtp-Source: AGRyM1tMhOMNWgAORUh9mpp4O8RtXO9vvz5SqLEF0AEsOQ+RfJgqpd4xll++0smuprXfaDmQUWj29g== X-Received: by 2002:a05:620a:bd6:b0:6ab:8874:4cb4 with SMTP id s22-20020a05620a0bd600b006ab88744cb4mr16628211qki.378.1658146102249; Mon, 18 Jul 2022 05:08:22 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id do16-20020a05620a2b1000b006b5ab88e544sm11500936qkb.124.2022.07.18.05.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 05:08:21 -0700 (PDT) Date: Mon, 18 Jul 2022 08:08:19 -0400 From: Tom Rini To: Andrew Davis Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] spl: Move check for SPL_LIBCOMMON support to header Message-ID: <20220718120819.GP1146598@bill-the-cat> References: <20220715153500.15598-1-afd@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CHUDHBOInnVVR1Vz" Content-Disposition: inline In-Reply-To: <20220715153500.15598-1-afd@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --CHUDHBOInnVVR1Vz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2022 at 10:35:00AM -0500, Andrew Davis wrote: > From: "Andrew F. Davis" >=20 > Print statements in SPL depend on lib/common support, due to this many > such print statements are ifdef'd. Instead of checking at each call site > move the check to the common.h header and remove these inline checks. >=20 > Signed-off-by: Andrew F. Davis > Reviewed-by: Simon Glass I thought we had this already, but I guess not. That said: [snip] > diff --git a/include/stdio.h b/include/stdio.h > index 1939a48f0f..2fbc3da5f9 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -10,9 +10,8 @@ int tstc(void); > =20 > /* stdout */ > #if !defined(CONFIG_SPL_BUILD) || \ > - (defined(CONFIG_TPL_BUILD) && defined(CONFIG_TPL_SERIAL)) || \ > - (defined(CONFIG_SPL_BUILD) && !defined(CONFIG_TPL_BUILD) && \ > - defined(CONFIG_SPL_SERIAL)) > + (defined(CONFIG_TPL_BUILD) && defined(CONFIG_TPL_SERIAL) && defined(CON= FIG_TPL_LIBCOMMON_SUPPORT)) || \ > + (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_SERIAL) && defined(CON= FIG_SPL_LIBCOMMON_SUPPORT) && !defined(CONFIG_TPL_BUILD)) Can we write this as something like: #if !defined(CONFIG_SPL_BUILD) || \ (CONFIG_IS_ENABLED(BUILD) && CONFIG_IS_ENABLED(SERIAL) && CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT)) ? I'm not 100% sure it will work for CONFIG_SPL_BUILD / CONFIG_TPL_BUILD but it should for the rest and mean we can slightly clean it up. --=20 Tom --CHUDHBOInnVVR1Vz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLVTTMACgkQFHw5/5Y0 tywpXAv8Cv1VqcpEWLw62zzADriqp7ek70quPdGCfy+FG6h6FyoEJL1IkUvHzYfU 6mfGn+GBdioZwWu0cTR8lMCKTlC2P34L5OrbgvCWePQL4RqI/+vaNc2l+uXNZhGD +tUFTh+6DcD45KMu2PRvr81gCEr1JZY80DLegDy9UPm2YJuOiIgo6JfPJSL2afq5 Po8eD19TY7HSfFmLFo4q2qeE+jblP6orb+g3c7lM+Eqo5cAEWW0Y926I3N5+TBMm o77oFtb6cZB8S8VxKJHb4AVv0g8XbXyw3voQbBCMpKmo2Xw71/ZdVX6ko7lOHVNP 3AgHSjQADQ5+72Zar2OlC76gR2BsvSku7itFK0sMmiyCyR6cQqAY5KPEU11YXHTP Sf7eDtlmjQnfy5Yj8hb80Adc71ccYQGpH1yzOXxi8A5v/uCToXW35JyKxE3bYM7b eMPp07eJYrfL9owrJta4CfhVRqWNjKeRtX9XmK23qoowh8oiSFwUE5D1VBdiqAiC lNQiZHkW =JwLC -----END PGP SIGNATURE----- --CHUDHBOInnVVR1Vz--