Received: by 2002:ac2:596f:0:0:0:0:0 with SMTP id h15csp229797lfp; Fri, 22 Jul 2022 05:03:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vQuAqhpo3xUwu4M3zdhWLq0Z3URTPqd3F32+NPyXsce8vFXeqCPY6lMbO7iXXM6aE/97yr X-Received: by 2002:ab0:37d7:0:b0:384:47a1:eb8e with SMTP id e23-20020ab037d7000000b0038447a1eb8emr20626uav.23.1658491400952; Fri, 22 Jul 2022 05:03:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658491400; cv=none; d=google.com; s=arc-20160816; b=SFxfQ2rbv5twA9313TF0gLYhoQBFI2H9N8dSZlXBQtJpEtdpCVCg1684M0y89BJbgm bu+iCFHRbLg4upG3kVR+J4CwrF9iAtsMl2KeZnsz8ydX/UvUMMPnnSsvlrcwuWs/dSzN 64p8PmVCTFPB3oPI4zvEP7QpLTUjP4Ore7pdDMlgQ0+a/vjxq9FwMdlDdG1iSDySMIck tu4fELZa6klgQhBqyhdmw/bcDsc/vdKP4PrdcsDKlz2tcQqfAd/s5dkQkQ9hif5jxaT5 A/0cOjN7uYKHiLZfkKy5/dFPyqnxmFRKBixVUPidw6HLdaHyheppDjkjq0UNw0uWlOdb rT5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=MWwtli2inRFLcqVUGsbZCyqw0kGwjbsHqr/Q8Oo6uy4=; b=NN+QU1tdDYPW27KCwcScE/l0BFnlXntLhU7HfT8brhMpmpQq7fufvbbkJgb38MaYP3 kLb7tJ/HTGmtrc2Yisyd5YXdQ/UarO1LMITq0G9cdqk6ht0rvou0fPPHbe5e2LuCzbAz kMiRtjdhZHT138frVdb4bVIUkXCnFAUKPczNvHpZhVkyjNHpLhtNhWoO+44WFmeqX4Ws /X7jyVB9CWcKZTdYwZFNrM4KrJ9FlL6VRPuHjhG/X9mEx5M0eRvqo2g1CCtmHqT+LqiA 1t25gbxAIJdV8hCMIBwHckVI8S/tiMQ3SQz/KXpWlrbAyqETUCWFXA9l0ja4Z9ErgkRy /dQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f58BC4D0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q184-20020a6743c1000000b003583ec8c02csi128949vsa.630.2022.07.22.05.03.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Jul 2022 05:03:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f58BC4D0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:40852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oErNI-0000Ce-AN for alex.bennee@linaro.org; Fri, 22 Jul 2022 08:03:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oErMY-0008Jt-NY for qemu-arm@nongnu.org; Fri, 22 Jul 2022 08:02:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:31629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oErMX-0006G3-3O for qemu-arm@nongnu.org; Fri, 22 Jul 2022 08:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658491352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MWwtli2inRFLcqVUGsbZCyqw0kGwjbsHqr/Q8Oo6uy4=; b=f58BC4D0eNFXTXQpNU+tNlSV/yvDOkBOrdTztkEziKvJVKokE+oyV+9Py65yc0Mk3KozN7 QzbgWrfB5EEcf94NqlfPsSdgqRfxgi4J5e/lGn8hFbP8IPLVEhC5uGzunrJxaOvbLGSZw4 t0/huBYnP/b226XGHes+rychCXtd598= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-451-wcGu2R98O8-xGxnMBe8PGQ-1; Fri, 22 Jul 2022 08:02:27 -0400 X-MC-Unique: wcGu2R98O8-xGxnMBe8PGQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0144A803520; Fri, 22 Jul 2022 12:02:27 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 772391121314; Fri, 22 Jul 2022 12:02:25 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Richard Henderson , Peter Maydell , Thomas Huth , David Hildenbrand , qemu-arm@nongnu.org, Cornelia Huck , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 0/3] target: RFC: display deprecation flag for '-cpu help' Date: Fri, 22 Jul 2022 13:02:21 +0100 Message-Id: <20220722120224.2311982-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: ZWQkFNQKVrxb When querying '-cpu help' there is no presentation of fact that a CPU may be deprecated. The user just has to try it and see if they get a depecation message at runtime. The QMP command for querying CPUs report a deprecation bool flagreason. The Icelake-Client CPU (removed in 6df39f5e583ca0f67bd934d1327f9ead2e3bd49c) handled this by modifying the '.notes' section to add the word 'deprecated': { .version = 2, .note = "no TSX, deprecated", .alias = "Icelake-Client-noTSX", .props = (PropValue[]) { { "hle", "off" }, { "rtm", "off" }, { /* end of list */ } }, }, This relies on the person deprecating the CPU to remember to do this, and is redundant when this info is already expressed in the '.deprecation_note' field. This short series suggests just modifying the '-cpu help' formatter so that it displays '(deprecated)' next to any CPUs eg $ qemu-system-x86_64 -cpu help: Available CPUs: x86 486 (alias configured by machine type) (deprecated) This series touched x86_64, s390x, and aarch64 because that's all I personally needed from a downstream POV, but any & all of the targets would benefit from this. They have each implemented the '-cpu help' logic independantly though, and unifying that code is not entirely straightforward. Changed in v2: - Just include "deprecated" as a flag, not full description which made the output too verbose and long lines. Daniel P. Berrangé (3): target/i386: display deprecation status in '-cpu help' target/s390x: display deprecation status in '-cpu help' target/arm: display deprecation status in '-cpu help' target/arm/helper.c | 7 ++++++- target/i386/cpu.c | 5 +++++ target/s390x/cpu_models.c | 23 ++++++++++++++++++----- 3 files changed, 29 insertions(+), 6 deletions(-) -- 2.36.1