Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EA6DC43334 for ; Fri, 22 Jul 2022 15:14:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7CD84838DD; Fri, 22 Jul 2022 17:14:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="23/w9aiA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1ADCB838DD; Fri, 22 Jul 2022 17:14:07 +0200 (CEST) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4944E82142 for ; Fri, 22 Jul 2022 17:14:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Message-Id:Date: Subject:Cc:To:From:Content-Type:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=E2cR7csqhvZ7mceUazc22MWx3/8aT1/9lZ45XbIwjFw=; b=23 /w9aiA5+VMKyPF8RBiQG4EPdeX3IdpQH55G1dCNQNQxqgYhudPa3JVv6e9061GMvmKVdtmufVTtPP Nv4KTyAOON1DDi5lq97fhnzqa6GKkxf/u9+T46hFOl5zfYpZd/uz+vKA1p08otPVNigwTU9uwGPT3 JvIWsq2Z3bUL1zHT1FceOoQXNRSsWvnD4Bgf+PemPE0vw4kHkZdD+eoJS2EEZmZ8UBUTelTpHt37l 9dqeEzaGbdmbDTAeZVCDMEmJggZFU3i887cM35KAIU/YE9nxlxOD3f+pw1UgjhvOeFjYUXFJgoRUl +AsPPFzGCCyBjOMmvvvuhgLU+nNJhlyQ==; Received: from [81.174.171.191] (helo=donbot.metanate.com) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEuLo-0004q8-Fn; Fri, 22 Jul 2022 16:14:01 +0100 From: John Keeping To: Anatolij Gustschin Cc: u-boot@lists.denx.de, =?UTF-8?q?Yannick=20Fertr=C3=A9?= , John Keeping Subject: [PATCH] video: dw_mipi_dsi: fix vsync active vs back porch Date: Fri, 22 Jul 2022 16:13:53 +0100 Message-Id: <20220722151353.4722-1-john@metanate.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The wrong fields are pulled out of the timings here so the values programmed into the DSI_VID_VSA_LINES and DSI_VID_VBP_LINES registers are swapped. Use the right fields so that the correct values are programmed. Fixes: d4f7ea83fc ("video: add MIPI DSI host controller bridge") Signed-off-by: John Keeping --- drivers/video/dw_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c index a5b38acabd..c68dd66fdc 100644 --- a/drivers/video/dw_mipi_dsi.c +++ b/drivers/video/dw_mipi_dsi.c @@ -644,9 +644,9 @@ static void dw_mipi_dsi_vertical_timing_config(struct dw_mipi_dsi *dsi, u32 vactive, vsa, vfp, vbp; vactive = timings->vactive.typ; - vsa = timings->vback_porch.typ; + vsa = timings->vsync_len.typ; vfp = timings->vfront_porch.typ; - vbp = timings->vsync_len.typ; + vbp = timings->vback_porch.typ; dsi_write(dsi, DSI_VID_VACTIVE_LINES, vactive); dsi_write(dsi, DSI_VID_VSA_LINES, vsa); -- 2.37.1