Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94370C43334 for ; Fri, 22 Jul 2022 15:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=a8TNcKLES6L4ubrjR/2Tc7Kf/I53L9Yw0DiZ7XVgYyI=; b=u/zwXws3BTkBKG kATzCcC6qArrI3xO+cD45ueAOcI7Ee5FDe0bfUywQk7m6U9tIgUdM1axk2OmdlFn1pCBgX8Laj13u vYwFKnlnkKabZ+lFuMaAZ8ORyRswOtWDfFWFAHjLm0T0CEk6DCVvUZCc50eoOeg9zx3RZnqY2vrqW Wc1IJ6s6QGygqhSoGqgtRlNwZUskQpmqqBik/hG6zpQjlEr4+EIPl1wXFkH4I6t2itiuetZWorMYR wyMQUiQlVc/m5ZtloBxbbFKMZ/NWrKal7EFpUOKyAh2T0YCWLWqBFeCJ02QdbHL8fvufikmgw7mWt 9GwpJ1XIXCc5LyhHI1/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEuSz-007FQh-Uv; Fri, 22 Jul 2022 15:21:26 +0000 Received: from mail-m964.mail.126.com ([123.126.96.4]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEuSv-007FHC-O0 for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 15:21:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=s6f7Y 4RaUVQ4fhWMG74wrT+hWzyPS59lwiwV57lYQSQ=; b=ShOMWHTilZmBdEXTB5ydA UUnGLcjA8AyNVBIonQIPhvyIod1DgOXuibfmAolDlbw1o4RnJCzun5TqAB+3Mx9X 2bd11AIF8pnAbfQ2q7vekjJvChUvHXSRn9DiLbod+x2o9HlSwqa2Ij1ay2kLQaw+ 9VexJVQ1cM74PQuR0HN1Uw= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp9 (Coremail) with SMTP id NeRpCgDX_spQwNpiFtn9Gw--.28341S2; Fri, 22 Jul 2022 23:20:49 +0800 (CST) From: Liang He To: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, windhl@126.com Subject: [PATCH] net: thunder_bgx: Fix refcount leak bug in bgx_init_of_phy() Date: Fri, 22 Jul 2022 23:20:48 +0800 Message-Id: <20220722152048.1310499-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: NeRpCgDX_spQwNpiFtn9Gw--.28341S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw1xJF43AF4fAFW5XrWUArb_yoWDKrXE9w nrWr9xXay7AF1Ikw43Gw4UW3sFvr4ku3s3ZFs7trZxA3ZxKry5Xr1ktr9xKryUur4UZFyD GrnFyF4xZ3yjqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMuc_DUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbizhJGF18RPigEygAAsb X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_082122_253203_D87A16D5 X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We should call of_node_put() for the reference returned by of_parse_phandle() in fail path or when it is not used anymore. Fixes: eee326fd8334 ("net: thunderx: bgx: Use standard firmware node infrastructure.") Signed-off-by: Liang He --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index 2f6484dc186a..1e22cf76374f 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -1494,10 +1494,13 @@ static int bgx_init_of_phy(struct bgx *bgx) !of_device_is_compatible(phy_np, "cortina,cs4223-slice")) { /* Wait until the phy drivers are available */ pd = of_phy_find_device(phy_np); - if (!pd) + if (!pd) { + of_node_put(phy_np); goto defer; + } bgx->lmac[lmac].phydev = pd; } + of_node_put(phy_np); lmac++; if (lmac == bgx->max_lmac) { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel