Content-Type: multipart/mixed; boundary="===============7263641622065184469==" MIME-Version: 1.0 From: Dan Carpenter To: kbuild-all@lists.01.org Subject: Re: [PATCH] wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file_wmi()` Date: Mon, 25 Jul 2022 09:34:10 +0300 Message-ID: <20220725063410.GO2316@kadam> In-Reply-To: <20220724202452.61846-1-ammar.faizi@intel.com> List-Id: --===============7263641622065184469== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jul 25, 2022 at 03:26:18AM +0700, Ammar Faizi wrote: > Commit 7a4836560a61 changes simple_write_to_buffer() with memdup_user() > but it forgets to change the value to be returned that came from > simple_write_to_buffer() call. It results in the following warning: > = > warning: variable 'rc' is uninitialized when used here [-Wuninitialized] > return rc; > ^~ > = > Remove rc variable and just return the passed in length if the > memdup_user() succeeds. > = > Cc: Dan Carpenter > Reported-by: kernel test robot > Fixes: 7a4836560a6198d245d5732e26f94898b12eb760 ("wifi: wil6210: debugfs:= fix info leak in wil_write_file_wmi()") > Fixes: ff974e4083341383d3dd4079e52ed30f57f376f0 ("wil6210: debugfs interf= ace to send raw WMI command") > Signed-off-by: Ammar Faizi Oops. Sorry! Reviewed-by: Dan Carpenter regards, dan carpenter --===============7263641622065184469==--