Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52E47C433EF for ; Mon, 25 Jul 2022 15:29:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B8B6D8419E; Mon, 25 Jul 2022 17:29:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ri+L6tOE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A6CF1841B0; Mon, 25 Jul 2022 17:29:02 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53B24840F9 for ; Mon, 25 Jul 2022 17:29:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id c20so8459494qtw.8 for ; Mon, 25 Jul 2022 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PK+SSkH/sdFiZgZE9/aqb9e9z6Dzo7qe1McZEPYB/gI=; b=Ri+L6tOErQyhIVN0hU/JC/r7ZO17ZMaU+vntkM8LI4VI1Vuv/PuW4SxYalz8fym1pb +QwUjdnKbCDtK1vAELWeFELBH54q32dZeKS/WaNUZ4ilVqk/Zfmr7sWw5UqesSDQKRiu 1cubh/XHDF8IbL6H1v/2ClqIOIVa+1jJJ77Cs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PK+SSkH/sdFiZgZE9/aqb9e9z6Dzo7qe1McZEPYB/gI=; b=W68fHGXZjYu4wZ9/0t7XnfC45PKVe9QNYpISxgG2NGTeJOWNvxON9hx4OWhirVY7NS CQ5fbPZfTsfr9RWSaTcsQp0bAIdV1KGLvDFVfic6OqmjI61NnXSdBM42mxiFBdM849G0 gJNpwibIEIsX8D7wCj+s/H60gM5uXqCCl9WcMVgQJGDBZ99DGgRMrWjyewsnK8dFrKA/ YbG2ldbQBWKX6KYujKOUK65vwniZO7zCUtV5L0uq75DIWf52FCLKyk/Tk5F7vCPtergv oecuOyPmatZytCpUG4sWMuoIv89R9juklZCC2A0+OcXw1lPfSfuZRtQl+BP1E527eUxg IjBQ== X-Gm-Message-State: AJIora9FcU1OHh+oaoMVe+kTpNnrFCZt8Ur1094RrjBSt/ET+Ki3yM9V 4MOUQaZy+qjDhognzpUmdgGPS06sAJ2Mpg== X-Google-Smtp-Source: AGRyM1tkRfK+XSsaS6nkoYE0WszmyeSVJ7B1Q7Vp+hYZAJ7Zoym1mrWAsZDxIvFdhK13kGlypQARUw== X-Received: by 2002:ac8:5f14:0:b0:31f:1f5a:69a6 with SMTP id x20-20020ac85f14000000b0031f1f5a69a6mr10629748qta.657.1658762939136; Mon, 25 Jul 2022 08:28:59 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id bk4-20020a05620a1a0400b006b5fe4c333fsm9510725qkb.85.2022.07.25.08.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 08:28:58 -0700 (PDT) Date: Mon, 25 Jul 2022 11:28:56 -0400 From: Tom Rini To: Andrew Davis Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] spl: Move check for SPL_LIBCOMMON support to header Message-ID: <20220725152856.GA84716@bill-the-cat> References: <20220715153500.15598-1-afd@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20220715153500.15598-1-afd@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2022 at 10:35:00AM -0500, Andrew Davis wrote: > From: "Andrew F. Davis" >=20 > Print statements in SPL depend on lib/common support, due to this many > such print statements are ifdef'd. Instead of checking at each call site > move the check to the common.h header and remove these inline checks. >=20 > Signed-off-by: Andrew F. Davis > Reviewed-by: Simon Glass This leads to a number of different cases of build failure. Looking at evb-px30 and P1010RDB-PA_36BIT_NAND show I think two different ones. Using the public CI infrastructure to ensure a clean world build is strongly advised for the next iteration of this, thanks! --=20 Tom --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLetrUACgkQFHw5/5Y0 tyzmwAv/fuXvfgDRApC7tpdLuov1h4Occ0jqp4oL83y79tnEkQes67TUxUx30nuc nsJzEGF+14F2Bge93WCbPHLqyFiGsaMgtdUO1Agz9V+YLl/NJPOspKadhMvdx7k0 UhNidZrA9uzZSFYB40Aprm3bq2hpaU+sepOPvFFvgSHbJ+v1uTsf5bAaPT7//AKo LM0feCTiaGFwJsqw5P3QjdDOPbb3got11TTqcv73N5xktQuLszuulObM9QeQSobL Ig9aIkv0n13b8urcB9DTO94d3YA5ATcQkeJD+JlpbtNw+q9zr78gZ7B+aged+eUn iPcTM9U8mrhtzLoVoOPXumAZhsjyGs7IOo5PKlQF/wTEHaO/Cb+2PmlAySd5zh/L P47Swol8e4FtxOI/tcz0DkH1YY4NZCWdWwFMssee/E2pKCOAZ7fuL1zoJ4u1djND YRpiMrhomuL+/nqrxpSxTBDczggzZRujwDiTvYKk4MvPmQIMx66xtxvI2J8Qr0Ah KrqGTCvd =2WnC -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--