Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3991AC04A68 for ; Wed, 27 Jul 2022 18:48:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1DDC684038; Wed, 27 Jul 2022 20:48:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PO7OLuxf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03EBD8409F; Wed, 27 Jul 2022 20:48:30 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A00ED83F2D for ; Wed, 27 Jul 2022 20:48:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id a9so13266324qtw.10 for ; Wed, 27 Jul 2022 11:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dfSheMJiibugIMghhGP+WOjpV5ikFOXSGo4ODGmXu04=; b=PO7OLuxfhwOqM+nLg+XXbI0aEpj1pg6dcXDQpku8Z/9fEmsxmSY4doYBP9RACzRP9e bjLMVVVxnwMdb/gFHOg0vdTvWOjTVtMNEZsnIBblwyI9ZqP7BrH8Ijn9hkO/KOReK2So Emk1M9RB1IjV1ziYhd+3dRxHL5yzIAIWXHi+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dfSheMJiibugIMghhGP+WOjpV5ikFOXSGo4ODGmXu04=; b=FvBXM5T6T9p+aT6eEit2bTuMWkfpGKVthCRP86TUPrc8Se4KxuwpT930fghTHBulVu Tb5plsckhWfEo37l/3VJAkcO2yKYhZ4FU53IrxCZgfnfFMnnKvtqHWid7SafqJCqU+Zg RezmS+hSA2iPAbYltmQ3n7AJ9KeQAKBXjDfyopq3HXdlBoKW51TsunjmnLqv+1SRVPR6 Sshu99usZHPY/Ejf4Qp3r1gimIGPpVorJnsC547mjGKbGNkiak9aP9RCtgmvrVS8qZtt XfeFg+F7UHW0GCQ/bCmMbXX+pVz0RA/EZ0Tu+hdoNcMjLKhqZN8suqYSpBcvq2nHc8gx /bvA== X-Gm-Message-State: AJIora83w6xG4kSggqTkQntkZTHtosdm0w5BOdh7g9c21Mwh88m6ZcfU 7ShXf2hve7LtRovuXc0xrjlIOQ== X-Google-Smtp-Source: AGRyM1tqC+g+9rZtgXJjtusXYmK6MaNXaABxqSi1IeGtwW1LaFqV0G7b4uyYuoQWqLt0xZXZNomFpg== X-Received: by 2002:a05:622a:110d:b0:31f:1c18:eb1a with SMTP id e13-20020a05622a110d00b0031f1c18eb1amr19789514qty.292.1658947706326; Wed, 27 Jul 2022 11:48:26 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id v33-20020a05622a18a100b0031f0b43629dsm12214208qtc.23.2022.07.27.11.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 11:48:25 -0700 (PDT) Date: Wed, 27 Jul 2022 14:48:23 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Troy Kisky , Joe Hershberger , Wolfgang Denk , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 2/2] Nokia RX-51: Remove CONFIG_PREBOOT from defconfig Message-ID: <20220727184823.GA1146598@bill-the-cat> References: <20220710114256.27322-1-pali@kernel.org> <20220710114256.27322-2-pali@kernel.org> <20220725212100.GG1146598@bill-the-cat> <20220727183441.hkyz2q333kvht2dw@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O8z+UjI18ldMd74w" Content-Disposition: inline In-Reply-To: <20220727183441.hkyz2q333kvht2dw@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --O8z+UjI18ldMd74w Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2022 at 08:34:41PM +0200, Pali Roh=E1r wrote: > On Monday 25 July 2022 17:21:00 Tom Rini wrote: > > On Sun, Jul 10, 2022 at 01:42:56PM +0200, Pali Roh=E1r wrote: > >=20 > > > CONFIG_PREBOOT just cause putting "preboot=3DCONFIG_PREBOOT" into env= list. > > > Value CONFIG_PREBOOT=3D"run preboot" in defconfig is just nonsense an= d does > > > not do anything useful (it is infinite recursion). Config file for th= is > > > board already contains default preboot=3D env variable with correct v= alue, > > > which has higher priority than CONFIG_PREBOOT and this is reason why > > > nonsense CONFIG_PREBOOT is ignored. > > >=20 > > > Remove nonsense and unused CONFIG_PREBOOT from nokia_rx51_defconfig f= ile. > > >=20 > > > Signed-off-by: Pali Roh=E1r > >=20 > > Applied to u-boot/master, thanks! >=20 > Patch 1/2 is missing. Sorry if I was unclear enough in the rest of the emails, I'm not applying 1/2. The empty string is fine enough (again, other variables have this issue). Unless I missed something and there's a run-time failure that 1/2 resolves? --=20 Tom --O8z+UjI18ldMd74w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLhiHMACgkQFHw5/5Y0 tyy7VQv7Bls5b+M3uZTiXxtIZuGr1op0EceOjttnjD0CpwdiqbbOtYsVemI0JmzY VZ6jR/cDppFTdj6Mz/oNyXAb9sg9us3lnwaPBx3o8ZcZbk8jne0W2Vukh5KdJx7Y S76GKC4/MD2ROfYVv0UKHcGhjD/5xU+8XEiqSmUzLBbiJYrqz5nKoiaBCttldVnD JDZdJbvnlnYqgbKeWJCOiVstIN6M1u4cjCgfASHQZoZvq2uAvx52vQAi6nIOtBFZ rlBQJ2v2PgM4kYHr93nudXO2fLJTh7rdJfTrA35Nbu8DZo175iaf66/sPmPUGvmW 5rZozmkJUxLMRbGt9jfYvPoc9XQ6IriGwXAaCv7FQIdI3Orz6FyCmd7HhD3HsLtl rUqQIRleewYcttpNMhQOp7cTYUowCNOaj+Xy0VQobrklzbO1Lshc00PBAwIXeKTI t9GXzsRHC9D7G/M5NQpSA3nJGX4sh5ta+LmsPYRyOmIS56IKzXhK5JrMGms6fKfa rCzq5iOF =QR/Y -----END PGP SIGNATURE----- --O8z+UjI18ldMd74w--