Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D22B5C19F2B for ; Mon, 1 Aug 2022 14:02:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BEB2D844E4; Mon, 1 Aug 2022 16:02:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="eN/v6xRC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 14462844E4; Mon, 1 Aug 2022 16:02:21 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B058D8407A for ; Mon, 1 Aug 2022 16:02:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id m16so8382617qka.12 for ; Mon, 01 Aug 2022 07:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LIZL/M2tLpYZ3VyGI+7FnUrVOnmcVR27yEpz2BvQLRI=; b=eN/v6xRCuTDrrKwyo4QcOgw5zkqhz2lpzMMz376ajwYKtwmzc+9+gjSDEdFRZ4njMY DRV4UBfWSJBswY89JV1Il3FiyY4jqmVjodVzuRc3m3tMUdVE9eJ065iH9Afhg15tURND lqBh5UOPSkZ5j1yy/iBfWVzNZOaZKkj0O08EE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LIZL/M2tLpYZ3VyGI+7FnUrVOnmcVR27yEpz2BvQLRI=; b=B3JYIhtfPwVsdRJFrUD3PDyNwb3ZHQsngGF4P9wCluGj9K6LIKKjYKwQvTPhOSoXIV 0AOI/btfBbx8UA21lyqHlkqjWtcqZk1VV6yOCPZJgXgoD+ncS4RkwnIcI/8jqegHhE7V kMUWjIrhx25GvoXF5sp9bVG7DJ/T1qiVPNhpWmclHT/ZQL2+ZtW124AFjLr38ZMBDKfD cqebUaonbcDyH1uXE4LbcyF50MHaGq+YuUblONG/lHCOHQ6hdtwpPO9Y8H8evx8FJTWq o8upWZKG4RX49xzPyFVFyxvqx5paaXl8AS5BcEIZnRhg0k1HRYltrr++LwcxxTPnaTMO ujpw== X-Gm-Message-State: AJIora+PKX0pa/oqhRiLf4Ufe5lAhjlC+tGlFsrxc7DdRkPIau2A9Vzj haS4TMe1P7Idm7WG8I80m53P8w== X-Google-Smtp-Source: AGRyM1sF8eQdT4G05LrZj8VWPajR7qEdsrooNvHsxkts/s94+wH0Nh6aDEZ9ed3QOJ22gj+RfXmKyw== X-Received: by 2002:a05:620a:12a8:b0:6b6:59a:5458 with SMTP id x8-20020a05620a12a800b006b6059a5458mr12127350qki.308.1659362537367; Mon, 01 Aug 2022 07:02:17 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id w20-20020a05620a0e9400b006a75a0ffc97sm8080649qkm.3.2022.08.01.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 07:02:16 -0700 (PDT) Date: Mon, 1 Aug 2022 10:02:14 -0400 From: Tom Rini To: William Zhang Cc: U-Boot Mailing List , dan.beygelman@broadcom.com, anand.gore@broadcom.com, kursad.oney@broadcom.com, philippe.reynes@softathome.com, joel.peshkin@broadcom.com, Andre Przywara , Christian Hewitt , Fabio Estevam , Marek Vasut , Samuel Holland , Simon Glass , Tomer Yacoby , "Ying-Chun Liu (PaulLiu)" Subject: Re: [PATCH 1/5] arm: bcmbca: add bcm63178 SoC support Message-ID: <20220801140214.GD1146598@bill-the-cat> References: <20220729194847.18854-1-william.zhang@broadcom.com> <20220729124534.1.I49e41e791b038a159729c535e9dcfc4a7d59e95c@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRi36hHvDFKiDvvS" Content-Disposition: inline In-Reply-To: <20220729124534.1.I49e41e791b038a159729c535e9dcfc4a7d59e95c@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --jRi36hHvDFKiDvvS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 29, 2022 at 12:48:43PM -0700, William Zhang wrote: > BCM63178 is an ARM A7 based DSL Broadband SoC. It is part of the BCA > (Broadband Carrier Access origin) chipset family so it's added under > ARCH_BCMBCA platform. This initial support includes a bare-bone > implementation and dts with CPU subsystem, memory and ARM PL011 uart. >=20 > This SoC is supported in the linux-next git repository so the dts and > dtsi files are copied from linux with minor fix-up that needs to be > upstreamed to linux as well. >=20 > The u-boot image can be loaded from flash or network to the entry > point address in the memory and boot from there. >=20 > Signed-off-by: William Zhang [snip] > diff --git a/include/configs/bcm963178.h b/include/configs/bcm963178.h > new file mode 100644 > index 000000000000..3ee2011b3a2d > --- /dev/null > +++ b/include/configs/bcm963178.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * (C) Copyright 2022 Broadcom Ltd. > + */ > + > +#ifndef __BCM963178_H > +#define __BCM963178_H > + > +#define CONFIG_SYS_SDRAM_BASE 0x00000000 > +#define COUNTER_FREQUENCY 50000000 > + > +#endif The one problem I have is that we need to put COUNTER_FREQUENCY somewhere else, if it needs to be defined. I see the top-level README has outdated information about COUNTER_FREQUENCY, which is most often CONFIG_COUNTER_FREQUENCY instead, as well. --=20 Tom --jRi36hHvDFKiDvvS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLn3OIACgkQFHw5/5Y0 tyxpfwv/ZSxYkyaFDnW0VrQUgfTt+c/jj9QZuCM/uxefyujNhGb8I49GHlTCUxob pqqQJhvBGXBHjCAnFwpEj70EjHbWvaw27lqSH8FKxOBD2iedTPa2QzNejWsDuuVY MjvxRvHl3wXodtdD4TsVZx7VWadMPfPSo3HrQ0beJmjAnAlNgIiRWQU60cOPvBN5 TSTojOBOk38y3IFdq7en953OrJBqsn0fCWc+ZWXLewku8PymxFhEcjEOhHIAZRlT R16QgZ0Pc+jWX8U5dsVlXeugM+u53hmFgg2bPQTRLEMnEgjHxNco8+XPCn4W+W40 KoRDlvgh9+9soENgFB8f0BOY/J/fZzRW7ydHvnTgAalQ9g+N1jCyLpbnrBmGQSxd NHrwIlKIBTmsN9R/pLQEohwQcjdDezIo5u4tQ/MzSRhNQfypUMKqXIACYOtAUIug QdA6sdmzVReaNYerCZkpBynTwQ52I6XXRGcsUHORX2EPHee6skgTMEtDgyqig1YZ 72ZQQaU9 =mBjI -----END PGP SIGNATURE----- --jRi36hHvDFKiDvvS--