Date: Mon, 1 Aug 2022 17:10:26 +0200 (CEST) Message-Id: <202208011510.271FAQjZ051726@...2054...> From: Gert Doering In-Reply-To: <20220727221830.31861-1-selva.nair@...277...> References: <20220727221830.31861-1-selva.nair@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: xkey_provider: fix building with --disable-management List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net Thanks for v2, and "too many #ifdef" indeed. Uncrustify complained that one of the #endif wants a comment, but with the new commit hooks this is easily fixed. (Maybe we want to have a deep look into "do we really want to keep ENABLE_MANAGEMENT?" one day... how much extra code size does that bring to the binaries? It's not *that* much code, is it?) I have fed the code to buildbot, and it pacified all these modern instances (fedora-36 etc.) ;-) Your patch has been applied to the master branch. commit fc75ab33401718fab3a79b19698eefb70a617a83 Author: Selva Nair Date: Wed Jul 27 18:18:30 2022 -0400 xkey_provider: fix building with --disable-management Signed-off-by: Selva Nair Acked-by: Frank Lichtenheld Message-Id: <20220727221830.31861-1-selva.nair@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24749.html Signed-off-by: Gert Doering -- kind regards, Gert Doering