Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4FD8C00140 for ; Tue, 2 Aug 2022 10:57:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E17F8404A; Tue, 2 Aug 2022 12:57:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="igZSFVQ2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 639FE8404A; Tue, 2 Aug 2022 12:57:24 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 188E183E4C for ; Tue, 2 Aug 2022 12:57:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id w6so335589qkf.3 for ; Tue, 02 Aug 2022 03:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ovPbpP5yXFSBqEX/83GeXthEP9ZeFThA4zCv9P43AUk=; b=igZSFVQ2saEDopT4U4Mh3uFgXqE0/lTm8nva6wxKRgwNX5EE5goLrEQWY8dmhlrtY0 bEXbiAiAyEuG6bv5kcgkpO7BXwl25Yf7HljwQUZ6OZnsA1Kq0nC5T9qz4ojORnkyqUil 4NgTgzWhGWNqX6tzVyRdBCIKS5kXh21ww0ceI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ovPbpP5yXFSBqEX/83GeXthEP9ZeFThA4zCv9P43AUk=; b=CEXQ7bmmb4qtEYpTnBiuphyvnN3hTOSOsL8pmVrtsJmqZePYG6YJHE7U3xfe6/0lCY 06QCphEcFoS0zA1GE0AW5c/hBoHAVkOU2LZ4neLGwzRxBTjhAb+2F/Bj/5d9Kf2C72JF ewE9u7YJNAR7IvUgGQTq/0ppN5b6Fwkb8Q4DmGen+B++CCdIT2xCutRF6wnt0cJxzvpu cdxMustsFaHNPHG2oFxPijeBb6/gj6jXBtc7DwQyPGomU/bnSkYEw/0dzKTRlt/6oWOE WAUIiIhIhQTLgBZhn1D+ov4/XC2wL32KhYx5xWqbtQ/6irYHzo4upB+WW/uT7h1t6anc b2Ag== X-Gm-Message-State: AJIora8ahUL8athsfMER+El/05M15dkUJS24m38wlldDESaYI+4QGTyR eKZkOUemfMWB6AsTpyegdJupEA== X-Google-Smtp-Source: AGRyM1sAN69B+pSdXKqeAxgXz6o5LOPrBkxQ+ruPFdcf5bA476xdlXMoZrkQV/zD4wamhgqGp6IruA== X-Received: by 2002:a05:620a:1987:b0:6b5:f06c:c850 with SMTP id bm7-20020a05620a198700b006b5f06cc850mr14423898qkb.188.1659437839755; Tue, 02 Aug 2022 03:57:19 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id i8-20020a05620a248800b006b5683ee311sm11013226qkn.100.2022.08.02.03.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 03:57:19 -0700 (PDT) Date: Tue, 2 Aug 2022 06:57:17 -0400 From: Tom Rini To: Dmytro Firsov Cc: "u-boot@lists.denx.de" Subject: Re: [PATCH] drivers: xen: events: fix build issues with disabled Xen HVC Message-ID: <20220802105717.GA1146598@bill-the-cat> References: <20220704120533.42168-1-dmytro_firsov@epam.com> <5c2feb29-3404-9c54-2dec-c52fefde8d88@epam.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LKCi4Bwid4O6NadQ" Content-Disposition: inline In-Reply-To: <5c2feb29-3404-9c54-2dec-c52fefde8d88@epam.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --LKCi4Bwid4O6NadQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 02, 2022 at 08:48:51AM +0000, Dmytro Firsov wrote: > Can moderators, please, take a look on this patch? What about it? https://patchwork.ozlabs.org/project/uboot/patch/20220704120533.42168-1-dmy= tro_firsov@epam.com/ >=20 > On 20.07.22 23:43, Nastya Vicodin wrote: > Reviewed-by: Anastasiia Lukianenko > >=20 > On Mon, Jul 4, 2022 at 3:05 PM Dmytro Firsov > wrote: > Some setups do not use Xen hypervisor console for logging, e.g. they > use emulated PL011 hardware or shared peripherals (real UART). In such > cases Xen HVC will be disabled on a build time and will cause issues in > current driver implementation. >=20 > This commit fixes build issues in Xen event channel driver, caused > by absense of console event channel, that is not available when console > config is disabled. Now console related code will be removed when > Xen HVC is turned off. >=20 > Signed-off-by: Dmytro Firsov > > --- > drivers/xen/events.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/xen/events.c b/drivers/xen/events.c > index 5e90a65846..532216fece 100644 > --- a/drivers/xen/events.c > +++ b/drivers/xen/events.c > @@ -23,7 +23,9 @@ > #include > #include >=20 > +#if CONFIG_IS_ENABLED(XEN_SERIAL) > extern u32 console_evtchn; > +#endif /* CONFIG_IS_ENABLED(XEN_SERIAL) */ >=20 > #define NR_EVS 1024 >=20 > @@ -51,8 +53,11 @@ void unbind_all_ports(void) > struct vcpu_info *vcpu_info =3D &s->vcpu_info[cpu]; >=20 > for (i =3D 0; i < NR_EVS; i++) { > +#if CONFIG_IS_ENABLED(XEN_SERIAL) > if (i =3D=3D console_evtchn) > continue; > +#endif /* CONFIG_IS_ENABLED(XEN_SERIAL) */ > + > if (test_and_clear_bit(i, bound_ports)) { > printf("port %d still bound!\n", i); > unbind_evtchn(i); > -- > 2.25.1 --=20 Tom --LKCi4Bwid4O6NadQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLpAwYACgkQFHw5/5Y0 tyzYPwwAgT0q4VHim/GYJ1hPBEGaFQgPfRzF5GcZBCM4lusX50qVPPHiI+OCT7po m+3nMHGqrALvLKbObkpSxqNZuFVoh0k7YEOQcQWXxY8ghWvOmoNWqy63hCP8WquD l03ZuFzLR83IZSgeOpAtZvibnxKTKjzr+ASRHE2oxa3D4I/zL8PuI63My95zPk7z KxFpE8S9qrlxdvr4zsR3onxy4xUm0EjEEJzUU5I1rBt7kaUB8pVV/mTZUy9XyoDG dRDLCa95DpBWq+yEYS+yySuNXG1reVjbYN+OOnP0ineKFT1eC3FGFczlgeyNd5mW gQvGTSed1MY3d1SzLgRPxC8JNsECmNMxMzf63xJtgrR3P24zyAcEWpppFCMciKmW GrHKDllEDhc5zBjkqatSjpE5zsPRrHulJiRcHL1g3VN50eZ16RA7Ocq+jp6zMlUs 7VRG4/CAWCyt1kCNTBAQ99IVbRuNRnB0lmZGJe9r1I4dZ2Yfst5BmmQnfYXVSy8B rHphrcLS =9hFD -----END PGP SIGNATURE----- --LKCi4Bwid4O6NadQ--