Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97AD7C00140 for ; Mon, 8 Aug 2022 13:35:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 31D2984822; Mon, 8 Aug 2022 15:35:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NRiqEnCT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E986F84567; Mon, 8 Aug 2022 15:35:14 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3C00B84841 for ; Mon, 8 Aug 2022 15:35:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id v14so868584qkf.4 for ; Mon, 08 Aug 2022 06:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=w++vmv6EVky/LP3ZmwMrLg05IpmsCTenBl2kePDJBAQ=; b=NRiqEnCTYScZlfpjRuivW1ZuhrTf5cP6lGWnRZpbqCJs9+K4wP8uGigu0g7ftfiCAH 9xoJQtIu3bwVH7JPXfACGH0nck5FVxxBVxAwKP0eFY3zoqX2MdX8Z2a+8YVe0fFtfuJt LqalZqfiOSv51ilWT1D9s6zhcNAc7qPrWKXpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=w++vmv6EVky/LP3ZmwMrLg05IpmsCTenBl2kePDJBAQ=; b=ZsgZCtozke3sUnx1qtwKg8CHU5XXRW2LASQZDjtfToYFHyERQXhhVtWQOPpscQVW1I oYZUpLJNpaZ178MjUxiMSUJnSA0QgcS9Pi1/QIuLTlOfQ80x/vEjl+tjlHVo+A1iUQ58 uksB18TfR8YxUUPdMw8hCOSdZ0+yYqOpbevT43mODbVqJH+rRX7ZIEhdLCKk5LZmYdWd X7pu8KpyZX9uGjWhZgy4ZKSVdUGjM0WeMCYQ5pMQ4LjktP3eLy3ssWqGpEINP7m/eouy epZ421xQ7+VQOZTNxu7SFgr7JvI5UkP3sdeTvGSQMUdFPpbbr1uuydIpGk14S4QGoQgF 0LKg== X-Gm-Message-State: ACgBeo1sgWkwnWyrvRcXutZFdmT4M/OT7GBeGfIbdKHgb9LRFlA/yDKm Vvltsn68Dm/1c31k7Vj2WFJKVQ== X-Google-Smtp-Source: AA6agR4lUTMNtPgVq3ER4/zwWfgHEAKzUmIrbk5cJJtAYAJ2ErUuJt+HP7xnO9OwXBgZweGiviQ0bg== X-Received: by 2002:a05:620a:4154:b0:6b9:6563:daa1 with SMTP id k20-20020a05620a415400b006b96563daa1mr1278079qko.563.1659965707890; Mon, 08 Aug 2022 06:35:07 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id e28-20020ac84b5c000000b00342f7beccd0sm2639166qts.45.2022.08.08.06.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 06:35:06 -0700 (PDT) Date: Mon, 8 Aug 2022 09:35:04 -0400 From: Tom Rini To: Philip Oberfichtner Cc: Marek Vasut , u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Dzmitry Sankouski , Sean Anderson , Stefan Roese Subject: Re: [PATCH v2 1/2] ARM: cache: Allow SPL to build cache-pl310.c Message-ID: <20220808133504.GL1146598@bill-the-cat> References: <20220804105646.2285428-1-pro@denx.de> <20220804110527.GY1146598@bill-the-cat> <45d5b4eb9e81a074377cfeefa520a7b315d77f53.camel@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OdtbCJ+0rbMAiUcH" Content-Disposition: inline In-Reply-To: <45d5b4eb9e81a074377cfeefa520a7b315d77f53.camel@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --OdtbCJ+0rbMAiUcH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 08, 2022 at 02:29:02PM +0200, Philip Oberfichtner wrote: >=20 >=20 > On Thu, 2022-08-04 at 07:05 -0400, Tom Rini wrote: > > On Thu, Aug 04, 2022 at 12:56:45PM +0200, Philip Oberfichtner wrote: > >=20 > > > Before this commit, the SPL could enable the PL310 L2 cache [1], > > > but the > > > cache maintenance functions from cache-pl310.c were only useable > > > for > > > non-SPL builds. > > >=20 > > > After enabling the cache one must be able to flush it, too. Thus > > > this > > > commit allows cache-pl310.c to be included in the SPL build. > > >=20 > > > [1] See for example arch/arm/mach-imx/cache.c: > > > v7_outer_cache_enable() > > >=20 > > > Signed-off-by: Philip Oberfichtner > >=20 > > It should be rather direct to migrate this to Kconfig, please do that > > first, and introduce CONFIG_SPL_SYS_L2_PL310. Thanks! > >=20 >=20 > Hi, >=20 > converting CONFIG_SYS_L2_PL310 - no problem. For SYS_PL310_BASE the > moveconfig tool just hangs indefinitely on every defconfig that needs > conversion. Do you have any hints on this issue? >=20 > Below the Kconfig entry, that I used. >=20 > config SYS_PL310_BASE > depends on SYS_L2_PL310 > hex "Base address of PL310" > help > Physical base address of PL310 controller register space We can just skip that one for the moment, it's a bit tricky. It shouldn't be asked for as it's not configurable, it needs to be a list of default X if ARCH_Y. Thanks for looking at this one too! --=20 Tom --OdtbCJ+0rbMAiUcH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLxEQQACgkQFHw5/5Y0 tyzfLwv/TewdeMhl17phvSDfsSODPyCf3eexQBE7uTt5tCXy5ucr2jAZHDI+0PtC zYsKNc30kssomszlXIpdkgyAVL6XHpd52gOSwF9QlAv+vV9DQVXyzTZOPYQoZrxx 43dhVfwlZKXVWPG2z/a9EsFJ0PaYLRAWbWZlK6e549dXpMLCt+PlZO0E/oUDtebk aD4DLzwUgcMSqyzhqmlO9CxNvG0lm+IqO62VJAxnogHyLBNNtJkD+8cU3XYfUtSE i+EokIRd96J9bCs1mvKig9tCa4zJqO4R02AIpgvmOKcLuDM8uizy3uizMple2ZLL 9M513mgTSz4hiaLOImCshfA+1tilCz90ttqZpG2Lk6CmrNm/R5dS+T4BUCVKEh36 HS8jFSj84Y+Lvu5RZaSL58Md30U3lkOf1q7/VzE874uhoI4CPsgMSgL4X+Ovy7/B 116SBE8SxM6enLhI0X5sYLM8HDUi73aKJsxiDwVMxWq4803c/vFE/wXArKZ1qoq1 QhQMl3y9 =s4Qb -----END PGP SIGNATURE----- --OdtbCJ+0rbMAiUcH--