Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB5CDC19F2A for ; Thu, 11 Aug 2022 16:02:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AF0D18AF22; Thu, 11 Aug 2022 16:02:32 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA31010F952; Thu, 11 Aug 2022 16:02:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31FB56137C; Thu, 11 Aug 2022 16:02:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56BEEC433C1; Thu, 11 Aug 2022 16:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660233733; bh=rzdAzLrpMW9Jg5EEs7PVdTHeceWVECVmu/G0Pm4ZQys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RHvTKGfMpySWi8ryWhZOTQlGwVeWna+zwzLCVJCWzuqVOOD7BHoEmLltJt9GEBsNQ EOzQmQDtAnFoEg3TbQjj3/7lBNj31oX4EDaVbacMCEjSXdyjDSDU8kO0X/MQcG678D EzL7YvFhP62Ox4dfZIP9Ht8BcIE73sbUJQ/52Ch2uL8XmksHGqeFsWWAnaRAS/Aa8j UAmweXZP5lBdictYwpnBjrri1ypG/1GCRb0m+sYEQ5WP9ethoY3DKh/6Lcs4giUrFr OwuQOBLK+XWlHnmPGUhhMtj7VWfoFRoBEx7g97v1RcR7pUwtbEzH000e3/3NFY4P5S 5+encPizWfj8A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 11 Aug 2022 11:55:59 -0400 Message-Id: <20220811155632.1536867-50-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220811155632.1536867-1-sashal@kernel.org> References: <20220811155632.1536867-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Subject: [Nouveau] [PATCH AUTOSEL 5.15 50/69] drm/nouveau/nvkm: use list_add_tail() when building object tree X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , airlied@linux.ie, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Ben Skeggs , daniel@ffwll.ch, Dave Airlie Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" From: Ben Skeggs [ Upstream commit 61c1f340bc809a1ca1e3c8794207a91cde1a7c78 ] Fixes resume from hibernate failing on (at least) TU102, where cursor channel init failed due to being performed before the core channel. Not solid idea why suspend-to-ram worked, but, presumably HW being in an entirely clean state has something to do with it. Signed-off-by: Ben Skeggs Reviewed-by: Dave Airlie Signed-off-by: Dave Airlie Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/core/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c b/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c index 735cb6816f10..06b2f675f5da 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c @@ -128,7 +128,7 @@ nvkm_ioctl_new(struct nvkm_client *client, if (ret == 0) { ret = nvkm_object_init(object); if (ret == 0) { - list_add(&object->head, &parent->tree); + list_add_tail(&object->head, &parent->tree); if (nvkm_object_insert(object)) { client->data = object; return 0; -- 2.35.1