Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF5AC00140 for ; Fri, 12 Aug 2022 23:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234136AbiHLXJ5 (ORCPT ); Fri, 12 Aug 2022 19:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbiHLXJ4 (ORCPT ); Fri, 12 Aug 2022 19:09:56 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE3039BB47 for ; Fri, 12 Aug 2022 16:09:54 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id bu13-20020a056902090d00b00671743601f1so1826431ybb.0 for ; Fri, 12 Aug 2022 16:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=xXzpXjvRspHe6EqAJ0peWZDoMV+SEU1E7aT46p0dEiM=; b=TyWfgnmLLl7dTdjM1raYv8gMUESt6Aj574QPgYwVLf2vMvMgGeRBcHTn4a+F28Zysm 8+lFUYM0uTOu7+ZQHwVJLB9Q/lxTCzNZpN0Y7GhNNxsY2h+fOkEmLbE8y2pb38FbhiOb laHlPAo7l3JePG3RZcReoLMrHc9eLpLdqZ/Yqa8c2k895dazcC3w31dIHJg9FoHh8WkC Bx/EuVlH4SbyeofrDsTqVQVM5gs8WX+QhE1rzKNKVgwXx6ey6B74iZjoSBFHKj+rl9M+ EuxyyDdzqcAczAAb5Mj5p5QdIRbDsg0A42yTkz6ui/7K8LZ01ncIH/72NV/G+EewbS0i H8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=xXzpXjvRspHe6EqAJ0peWZDoMV+SEU1E7aT46p0dEiM=; b=A7WKfHMbKaj9FiHbVPRMGsSuWD3X490FAWOlYXERjxKoUOzol3s3xslGgHhPg2bOYF EMXl/GW9iGldamRrPtEkPiCEOOVuviXhkaXnOFjASilKrjplQld3c2IpYoJPJFwDREC5 ZJs1Fxvk1/pMRd50qYnQNf9ofzYpYZyD6yP7bcvf3oasQjNbSc1Q/5WHHcfzPv3Z5p3u FA/I6l3o1x9Wjlih4vWCB0gnTnkHoA76KYDAvoZJbDOG34MBCDB+P/awg0ZAurFuVlbq yYoFuzJ8GSnAChwlUfpG44+371fYktmCYrhR7GIcRt92J9eqVtF8+vzVddpiaISgnKoR PASA== X-Gm-Message-State: ACgBeo1T257FBMoGKXjx3t1hQVs/wwBVF+CR+c7kXA/Qy973ORKRP9RL +3/ZJneNW4HUHbBOsZNxLl+4a5LNKKBf X-Google-Smtp-Source: AA6agR4LutrHhrE6oQnlgGroLFarxMNNHW2HnxKZNw5B1WQq0kn0vV42MbXicpOjvjfxnhUeBm9qhm7Ooqzc X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:d668:2937:8218:c5ec]) (user=irogers job=sendgmr) by 2002:a25:230d:0:b0:677:116d:afdb with SMTP id j13-20020a25230d000000b00677116dafdbmr5100760ybj.551.1660345793786; Fri, 12 Aug 2022 16:09:53 -0700 (PDT) Date: Fri, 12 Aug 2022 16:09:35 -0700 Message-Id: <20220812230949.683239-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: [PATCH v5 00/14] Compress the pmu_event tables From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org jevents.py creates a number of large arrays from the json events. The arrays contain pointers to strings that need relocating. The relocations have file size, run time and memory costs. These changes refactor the pmu_events API so that the storage of the pmu_event struct isn't exposed. The format is then changed to an offset within a combined big string, with adjacent pmu_event struct variables being next to each other in the string separated by \0 - meaning only the first variable of the struct needs its offset recording. Some related fixes are contained with the patches. The architecture jevents.py creates tables for can now be set by the JEVENTS_ARCH make variable, with a new 'all' that generates the events and metrics for all architectures. An example of the improvement to the file size on x86 is: no jevents - the same 19,788,464bytes x86 jevents - ~16.7% file size saving 23,744,288bytes vs 28,502,632bytes all jevents - ~19.5% file size saving 24,469,056bytes vs 30,379,920bytes default build options plus NO_LIBBFD=1. I originally suggested fixing this problem in: https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/ v5. Renamed two functions to be more inline with the code and added extra commit message detail on the event sorting order as suggested by John Garry . v4. Fixed an issue with the empty-pmu-events.c spotted by John Garry . v3. Fix an ARM build issue with a missed weak symbol. Perform some pytype clean up. v2. Split the substring folding optimization to its own patch and comment tweaks as suggested by Namhyung Kim . Recompute the file size savings with the latest json events and metrics. Ian Rogers (14): perf jevent: Add an 'all' architecture argument perf jevents: Remove the type/version variables perf jevents: Provide path to json file on error perf jevents: Sort json files entries perf pmu-events: Hide pmu_sys_event_tables perf pmu-events: Avoid passing pmu_events_map perf pmu-events: Hide pmu_events_map perf test: Use full metric resolution perf pmu-events: Move test events/metrics to json perf pmu-events: Don't assume pmu_event is an array perf pmu-events: Hide the pmu_events perf metrics: Copy entire pmu_event in find metric perf jevents: Compress the pmu_events_table perf jevents: Fold strings optimization tools/perf/arch/arm64/util/pmu.c | 4 +- .../arch/test/test_soc/cpu/metrics.json | 64 +++ tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++- tools/perf/pmu-events/jevents.py | 478 +++++++++++++++--- tools/perf/pmu-events/pmu-events.h | 40 +- tools/perf/tests/expand-cgroup.c | 25 +- tools/perf/tests/parse-metric.c | 77 +-- tools/perf/tests/pmu-events.c | 466 +++++++---------- tools/perf/util/metricgroup.c | 275 ++++++---- tools/perf/util/metricgroup.h | 5 +- tools/perf/util/pmu.c | 139 ++--- tools/perf/util/pmu.h | 10 +- tools/perf/util/s390-sample-raw.c | 50 +- 13 files changed, 1131 insertions(+), 706 deletions(-) create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json -- 2.37.1.595.g718a3a8f04-goog