Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12651C3F6B0 for ; Wed, 17 Aug 2022 06:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238878AbiHQGOR (ORCPT ); Wed, 17 Aug 2022 02:14:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbiHQGOQ (ORCPT ); Wed, 17 Aug 2022 02:14:16 -0400 Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63EF501A2 for ; Tue, 16 Aug 2022 23:14:14 -0700 (PDT) Received: by mail-ed1-x54a.google.com with SMTP id w17-20020a056402269100b0043da2189b71so7933315edd.6 for ; Tue, 16 Aug 2022 23:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc; bh=Xa1Am8o4teQaaL9RutMPnLbxqHkDGkecVOS2SmaoyIs=; b=s/1uTUYyEaFlNWqfnApEYsQdesm4fvMpnKQOdzNeq15EnC9twMzAmYS27DYIEpoQNV ONiulQIKOyEaJN7vwBiVA52A3T4fcNXzcO2EhlNUv27SahrpI8qf2TkmB06MCRaqefwF /yeummP9sXq7fbGE66YggRyUl+gsDQWhxLKEisD400L//ndUoKIQVHn5cqERyZdfGqzW MxIJmnSbDnDTsusWT3OxOGRFuDKrQGwlnv+xVRnPv6dCaBuTy0G5ycxfUPP9Z6vnw8Dw XiMmWQtzqjM7hXitZzNVNFnrMdeE/E2XvAKW/O257aO7bzFySiL/TErWqyTrtHttYnlB qbFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc; bh=Xa1Am8o4teQaaL9RutMPnLbxqHkDGkecVOS2SmaoyIs=; b=WVnOEqdCRVu25JuRI9MTuLi5JPerV2ua3wIL5++TxCty3yjjrHBqF592SyFK18faMe wGgW2V8/ir/gUqQK2zNlGJ3XrVv0uNXMiKunOUfa5Pz6lCl4bhdvWClLjbzjuaIAh7Tr QBzNMNTrpKE4IIa7KAkNGx1x4O67YcvCJfyNBWZ5PPUvA17op5v/ypJ3Jx+t+0R++l8h tF7ilf0L7VL9aeQz9CM/SOHaXlXDBNdyBS1u6D9p/4uoJO1Q9x1v10akudxHlStSUAe1 E44OqO9HZwjdPk5KSEN3iZJgT7Psw3697OH5cKBo8yhlBclsUwPpRBjrlUoACSKmW+jr SIhg== X-Gm-Message-State: ACgBeo3cG9qOySSGmKRRH8pyXfPIngWqck3QeIEJqYiFSAQpJTyikpnB g9xJrkqkzK3Y0FzH2v3h8u0vViRSOR25 X-Google-Smtp-Source: AA6agR4jDLAGqFGFVp5dCXkX1JHnJoN5Z+/KOffoN15vAxyETRy5Eo2fSEJJ2790+2dor5kkVeI0mn+NTGTR X-Received: from dvyukov-desk.muc.corp.google.com ([2a00:79e0:9c:201:6b03:2ace:af3d:2660]) (user=dvyukov job=sendgmr) by 2002:a17:907:608f:b0:734:b422:42f4 with SMTP id ht15-20020a170907608f00b00734b42242f4mr14937896ejc.491.1660716853316; Tue, 16 Aug 2022 23:14:13 -0700 (PDT) Date: Wed, 17 Aug 2022 08:13:59 +0200 In-Reply-To: <20220815170444-mutt-send-email-mst@kernel.org> Message-Id: <20220817061359.200970-1-dvyukov@google.com> Mime-Version: 1.0 References: <20220815170444-mutt-send-email-mst@kernel.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: Re: upstream kernel crashes From: Dmitry Vyukov To: mst@redhat.com Cc: James.Bottomley@hansenpartnership.com, andres@anarazel.de, axboe@kernel.dk, c@redhat.com, davem@davemloft.net, edumazet@google.com, gregkh@linuxfoundation.org, jasowang@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, martin.petersen@oracle.com, netdev@vger.kernel.org, pabeni@redhat.com, torvalds@linux-foundation.org, virtualization@lists.linux-foundation.org, xuanzhuo@linux.alibaba.com, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 15 Aug 2022 17:32:06 -0400, Michael wrote: > So if you pass the size parameter for a legacy device it will > try to make the ring smaller and that is not legal with > legacy at all. But the driver treats legacy and modern > the same, it allocates a smaller queue anyway. > > Lo and behold, I pass disable-modern=on to qemu and it happily > corrupts memory exactly the same as GCP does. Ouch! I understand that the host does the actual corruption, but could you think of any additional debug checking in the guest that would caught this in future? Potentially only when KASAN is enabled which can verify validity of memory ranges. Some kind of additional layer of sanity checking. This caused a bit of a havoc for syzbot with almost 100 unique crash signatures, so would be useful to catch such issues more reliably in future. Thanks