Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D2DC32772 for ; Sun, 21 Aug 2022 10:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbiHUKi4 (ORCPT ); Sun, 21 Aug 2022 06:38:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiHUKiY (ORCPT ); Sun, 21 Aug 2022 06:38:24 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 777101101 for ; Sun, 21 Aug 2022 03:38:22 -0700 (PDT) From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nf] netfilter: nft_fwd: really validate family Date: Sun, 21 Aug 2022 12:38:13 +0200 Message-Id: <20220821103813.734773-2-pablo@netfilter.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220821103813.734773-1-pablo@netfilter.org> References: <20220821103813.734773-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org This only supports for the netdev family, report EOPNOTSUPP otherwise. Fixes: 76a109fac206 ("netfilter: nft_fwd_netdev: validate family and chain type") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_fwd_netdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/nft_fwd_netdev.c b/net/netfilter/nft_fwd_netdev.c index 7c5876dc9ff2..138313123da6 100644 --- a/net/netfilter/nft_fwd_netdev.c +++ b/net/netfilter/nft_fwd_netdev.c @@ -205,6 +205,9 @@ static int nft_fwd_validate(const struct nft_ctx *ctx, const struct nft_expr *expr, const struct nft_data **data) { + if (ctx->family != NFPROTO_NETDEV) + return -EOPNOTSUPP; + return nft_chain_validate_hooks(ctx->chain, (1 << NF_NETDEV_INGRESS) | (1 << NF_NETDEV_EGRESS)); } -- 2.30.2