Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oR607-00012P-Ah for mharc-grub-devel@gnu.org; Thu, 25 Aug 2022 02:05:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR5zw-0000z2-LO for grub-devel@gnu.org; Thu, 25 Aug 2022 02:05:55 -0400 Received: from mail-db8eur05on2080.outbound.protection.outlook.com ([40.107.20.80]:59777 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oR5zo-0003Ki-OD for grub-devel@gnu.org; Thu, 25 Aug 2022 02:05:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nrnTJmev2lMx1oPZuIgKnL/cPCvq3Iy1LHaGGRfFrt1+xUysp6CsgFICvX81h10cWQKiUCxpzNNafpgxlBB/R8Hn/AaHXXo1cJxFQWQjISmqkiY9sHqicnCrGbmKOin29kBhG74nTBVxmjcMEi9+y+g8HogHvjezuTkg/tqbaUtfyV17eMautfYyUDe9+kIeU0RB8wfaPoVpr8HSCU7Net6an1/OhK6uZGrg5ZseXPG7Cs3fQVBSelkSO9eG27l2mGr0ffiTTmtEehcGDbE8xBFUuEgiluD80pi/GLrjo1oplznrx0acLN7I6gUQPwvE0IhLg72fYSKW3WrxL0mcEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TK1oP3E9XfakZIyHFoqfpavHJumc+58vPrZ6RhSuEZA=; b=lS8mIn7Uguyy+hmtsqTf7JdDZuX1assI7L0koinBFhYCiyRtKBvaLZdMzla/TgzlrHNnab9JOME1CLmXXbCisSb85tb9W+vEWUDhRB9RyKAVFtp88SVgTTTmbOEaY9UDvMcV4vdsK5ZNnExZ1LsI3k+li0Nh0Hx3UF/lMBAva4DrvfZMi2GcCjQBOIfNSk6BxqSspZ7qRemu77XQecVU/1dW4n7dcU6HFknaYIyjPGCIjlFizbzshwWY/e7gOrQjO28nMUUcP0qu24RBPlYJyKauAYMTkCLsLzToeoiR36F0WcKFg8ZbVsMu/7zIcXp5P0SdpUDHGAcyX/LyCT+b3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TK1oP3E9XfakZIyHFoqfpavHJumc+58vPrZ6RhSuEZA=; b=DsKpBFARV3THdesYG4/hbSlAuEVtcHAfTLHiN1vuwH+O7jxC4bIy9HZ/iWRoH4cr24ZwzNZIRkY3b28k97aAVzG4GGiGejlRVwHNPdg5DO2u1tBqeTlPZ04fx0R1MC0UijZKaStnE7PGKRTtVJTk6TmBiMLOXwbIl4Zip1BqIZbHCZ108bGUNHSbLq28KCA91EuoIJC6s/p0pQ6L8DyNFRrEzy4TFLiXYnAEsljpDj6eBEJ5c3lE+3jwd0uZnCHvQWKh6CuaFOdg/634GNO1nHA/n3ZyBe+6y804+XgtdY/dURpsC3y9nlh7BiJDqC7+BVbHR6j5OM6WLuLQdS9zrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by DB7PR04MB4732.eurprd04.prod.outlook.com (2603:10a6:10:23::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 25 Aug 2022 06:05:10 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::b589:af91:d7ea:3f48]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::b589:af91:d7ea:3f48%9]) with mapi id 15.20.5546.022; Thu, 25 Aug 2022 06:05:10 +0000 From: Michael Chang To: The development of GNU GRUB Subject: [PATCH] grub-install: set point of no return for powerpc-ieee1275 install Date: Thu, 25 Aug 2022 14:05:01 +0800 Message-Id: <20220825060501.21710-1-mchang@suse.com> X-Mailer: git-send-email 2.35.3 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TYWPR01CA0040.jpnprd01.prod.outlook.com (2603:1096:400:17f::9) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84aaea02-3f4d-4f77-5c8a-08da865fc4ac X-MS-TrafficTypeDiagnostic: DB7PR04MB4732:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QzlMOJXHUyqrsWNKaqfx3mi8IhzLpW3qpJJ2FFS2msI20aqKE8a3iERM0Fm+nJtTmdEVglTSb3LxUEbzlL/UJb9yTWf0uDi5VQvggpFysCgL6UKGZFL0bNqNI/8g8YtWE+mg3ssgsobJ2xeIi5Yv407rh8ws12+Eep/a+3CETFEfr6NX5R25QpAhPrdAXk4x7QGzCUhKGgVmRruQydWeTm+F4DZ1w0brQmzbmERyEToCxkfzR/13yeqjN2YwSbXVKPo5kJfEZdYKzjZ5MrBuMND/7Lpzrewxd4MpPrYMPghKJh5ArSIVwU1uVX7q0GYFjoVhX8Nu7UV8j+itHtuHXqeoyNrKU/VWMd7e1VokgZdaeW+HzS0a1IMYlsjKu1oNMHyxPgdpSaWNAaKbw8+49NJQy3b4VVtEGv8AaD3FwDjeacv2HtVkgKIqS+Cvj4wjGzzeYMhHS/EIWLhONWQHgeSkQPWSWY0wcFSWHrxV5HdGCeNf267WUnu+uMaHDmuAqM8gYoqLeRkfrn7+1dK7bPViQ+V/oGdT8dxiP3VXym9BiLapKqMxyODIdmzgfT9tHvL4hGQhvjKO5A0T3shUMHO7vcIH0+MtnMygdYHZShAmHtDlNWE8WxYszffUZrFwI+Gu4fzIrui9adQXztNRX1jei3eXYtJlsM5AT7YvsEy3UF/XmDS/LJUwUA267Oz5K8iO1ofPevdXvHKJonPFSg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(376002)(39860400002)(366004)(346002)(6666004)(6506007)(6486002)(41300700001)(478600001)(83380400001)(6512007)(2616005)(8676002)(186003)(1076003)(2906002)(8936002)(4744005)(5660300002)(316002)(6916009)(66476007)(66556008)(66946007)(36756003)(86362001)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LsdSekspzM2+vEa+i/cG2MxeWwR2RLedtY937/pNmG7IyXi+E26pYBCN+xzj?= =?us-ascii?Q?VV4P4o9eWhi9+I9DFuqz3PwxjVolCiibvuHw4V+qPT0a569DlPD8UaEblypQ?= =?us-ascii?Q?TJ17DX03voF1hSZKEDfoHt3QnWAanf5usL4RQYybSGq5iLUvWrdc1QDPas/x?= =?us-ascii?Q?kJQQVys61dfI40u2I/W94SUJ0LBx3AXywG3urby+q4sN0Q4jRlWpSttlSCt0?= =?us-ascii?Q?TvoXFkHKzomXEa/ZB4JbvFEPgFH8NOQB5hmz8i2Shd4oiZtb0GHreG9wHIcT?= =?us-ascii?Q?6Ubpx408cE7L3VPMhrx2wtM6OfK8SlkQ5O8XfRI1vbu2Tm0ZIncsoHkKHyR6?= =?us-ascii?Q?Mhpvtjtf6DK8V1VETDZPKbH0z26zHBGl8hU8QCwTyuAO4NMBPy09bwycImKa?= =?us-ascii?Q?2x/E2V7E0+VRZ3UlWuWle+fFOA663W0mQKpyxxTUnJOTnPUm+ZwGL4yXmnw/?= =?us-ascii?Q?akcQVcPB4WnLGv0Of62XWIA4b5G/MTw/CGmCNl82sGJ36pBZiebh1I63bBF5?= =?us-ascii?Q?v4VPwkKhtD2UJZe9DhKhLpiWonRmdw2cLQ/qOE47I4Te9vt/8mCDhmRE2uvV?= =?us-ascii?Q?O6aUrzJa2+oaqE/hwCjwv6jrzJysERdoMLsN/1s3AlfNGJJMDmrVv5DyI38B?= =?us-ascii?Q?+EWKpBAYkfZkTec/Z3ZZh7xicqgGJ0kz7HIwE8bqnwdrgz3IIbw6cq/QK/oF?= =?us-ascii?Q?wHGaiH8KHs4noVw+gwgion865htr7UEQyZU8VvJZyhPUL25h3K0Q4TMytUmv?= =?us-ascii?Q?7TCoaSJRfmJ42AEKe4U+HiTfXucywxvXxi7H++A2Z8Y49pMnG2TfTz0+aQig?= =?us-ascii?Q?SXZM7JoQylrfPHWbdkRQF/llvS+1dnZPI0LxsPITofh9qnFX/QuoqjntAhAL?= =?us-ascii?Q?f9Y0JRU4us1VDUOC3TUf0GYphbLuQtLzy+ZLjRVyluNxnjLSPi9TBr+ka260?= =?us-ascii?Q?PYXdg6/2au8YaaeJZ8dQvCY6KykayUXk9/TdnHT1KGcheasdPeOvF4gH8TWI?= =?us-ascii?Q?OPB7PyeR0U9HrLms1363GQuyPpgot26m/xXlRSWmF7H8uF1lXCE3lwmlgojr?= =?us-ascii?Q?BKzw2jK8o/5BKKYmKnoHo4YkdPVY4ukpZRfUjRDn8iia6+xfRUZTroXkH8+N?= =?us-ascii?Q?uI6u79wVd+J5GGE78GnsdGweRak/NH93uvbhUqg8H7nhgMKtvu+21i1nzSAH?= =?us-ascii?Q?Z/+ub+Re036uUkqi/QJwFDkPDzZMIY59NOKznbp/gqwHScQBJgO6Rd95465w?= =?us-ascii?Q?OODomu/gR5v10yo+nwYQCEtQOq6LFNeIABNJdkSdjlUs/vd8CKEr6FnzeH3y?= =?us-ascii?Q?BFpNGqyXvwBXp+UesC+Mqk2eCaSPi7hZCT9jhtsfVlIn+Iz//qtssuNF+oBi?= =?us-ascii?Q?siZqGtHr860+GaPMrX9Ezat9Ih8q7LmdjnVLl1wuIgTosh1f50sGVDDQvEoc?= =?us-ascii?Q?tmEp3phHARJQeJAYDqhyBUnomd/XoWGyBdEY9lKB6XxfAwxghPuKhg9qOZhX?= =?us-ascii?Q?moH+U/VVlnmRZlXt2bXqhhY1yw0QvE1rPZmO3sXjH7uUdgSojz1cbQRlgy1L?= =?us-ascii?Q?I6v9F5485UEtNBatnPNnymDEdj3Yp9921cTMZkhx1RG3ymggojfHX9VjBcor?= =?us-ascii?Q?x7MRD6OpJRdql0yJnSWKMNwfU+1Rr+JvH07Smaegj44y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84aaea02-3f4d-4f77-5c8a-08da865fc4ac X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 06:05:10.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vkL4u9VPt5hGnCdsKTxeFyXNmrEABEV6A1fR4P2BK4R+9azZK0WUJ3rRUW2zJnOP X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4732 Received-SPF: pass client-ip=40.107.20.80; envelope-from=MChang@suse.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2022 06:05:58 -0000 The point of no return is used to define a point where no change should be reverted in a wake of fatal error that consequently aborts the process. The powerpc-ieee1275 install apparently missed this point of no return defintion that newly installed modules could be inadvertently reverted after successful image embedding so that boot failure is incurred due to inconsistent state. Signed-off-by: Michael Chang --- util/grub-install.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/grub-install.c b/util/grub-install.c index 7b04bd3c53..1c0ece7f19 100644 --- a/util/grub-install.c +++ b/util/grub-install.c @@ -1835,6 +1835,7 @@ main (int argc, char *argv[]) { if (write_to_disk (ins_dev, imgfile)) grub_util_error ("%s", _("failed to copy Grub to the PReP partition")); + grub_set_install_backup_ponr (); } else { -- 2.35.3