Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3F77ECAAA3 for ; Fri, 26 Aug 2022 15:28:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 39D1A848DC; Fri, 26 Aug 2022 17:28:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="sMSE9HhO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2D2F2848C1; Fri, 26 Aug 2022 17:28:13 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B5B2F848C1 for ; Fri, 26 Aug 2022 17:28:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id u6so1313778qvp.5 for ; Fri, 26 Aug 2022 08:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=WyItDD7rSuutiBEIWjS5sZiZDcG+RUdZbafoUt6FR/U=; b=sMSE9HhO06WbuDdQ5StCID0eAgb20C7WThsXw+MEq29vrYGfD4yBR+N9nZl5eDYVas oUbX69r1W1nlWYurO2LeYI8eGSZXolNXoUv/3LI400RCFm/KbB3juzcMA6Ue64VsNaUl wIb0yW0nSlmrEWypaxOEjkM+UncVrSp6646u4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=WyItDD7rSuutiBEIWjS5sZiZDcG+RUdZbafoUt6FR/U=; b=jNmzxdwMangWvD2RM+HW3JnqgZ15iyamErePp2o+NJdIfn/JrToCDQ0H/tsAlwdZOp f94cCvX0lQrVBIRdQC2q2O9avNb+GboPUb/FJDf34JzSN+nLA9fPVuGbAO5CVPww4rBp 70fOPU2M0BCgoX7iWWkuF+KXaF7HQ0XCIxDwdlUivucO02kUHuE47OH5i4BcI6G06Lw4 L+XMEVSBY0lII3xOUaO7Ru9lXV2jJAQtfw5JrSUe5zzC49bbgICWn6VM4hj9QQoxo4Ye Il4Ys4UCIxwOH+e+MRFeqUaU/UWYhGT9ZLXjlSkgAEf0ta0FtLgRRfizoh0hL/dLrVvI Nakg== X-Gm-Message-State: ACgBeo3AV/3khW0uID/r3E83M+FxVc31E7jUru+Tuv2ul5ljGjJeTXzt JT8RkhL7NisdBitJecM9NeyKxw== X-Google-Smtp-Source: AA6agR5mnMrxTpvnnWi3Fcs53wS+v64/PoXr/Y+GC00LmjZJT3qYo6Kpzz23LblaStAHlpPmIizsYA== X-Received: by 2002:a05:6214:20e9:b0:496:f1e3:60d8 with SMTP id 9-20020a05621420e900b00496f1e360d8mr97630qvk.57.1661527689356; Fri, 26 Aug 2022 08:28:09 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id l15-20020a05620a28cf00b006b5c061844fsm2134475qkp.49.2022.08.26.08.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 08:28:08 -0700 (PDT) Date: Fri, 26 Aug 2022 11:28:06 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] distroboot: ubifs: Add support for specifying UBI header offset Message-ID: <20220826152806.GH7942@bill-the-cat> References: <20220807190422.20157-1-pali@kernel.org> <20220808161027.GU1146598@bill-the-cat> <20220825135220.i765o2uyiggcrrdh@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CGDBiGfvSTbxKZlW" Content-Disposition: inline In-Reply-To: <20220825135220.i765o2uyiggcrrdh@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --CGDBiGfvSTbxKZlW Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 25, 2022 at 03:52:20PM +0200, Pali Roh=E1r wrote: > On Monday 08 August 2022 12:10:27 Tom Rini wrote: > > On Sun, Aug 07, 2022 at 09:04:22PM +0200, Pali Roh=E1r wrote: > >=20 > > > Some UBI partitions may use non-standard UBI header offset. For attac= hing > > > these UBI partitions it is required to pass second argument with offs= et to > > > "ubi part" command. > > >=20 > > > Therefore extend distroboot to allow specifying additional optional 6= th > > > argument with UBI header offset. This offset is set in new distroboot > > > variable ${bootubioff} which may be used by distroboot script to e.g. > > > properly pass this value to linux kernel command line for proper moun= ting > > > of rootfs by kernel. This variable is set to empty string (cleared) w= hen > > > UBI header offset is not specified into distroboot BOOT_TARGET_DEVICES > > > macro. > > >=20 > > > Usage of helper macro BOOTENV_DEV_UBIFS_BOOTUBIOFF in this change is = there > > > as a type check. It ensures that in BOOT_TARGET_DEVICES macro was spe= cified > > > UBIFS func with either 5 or 6 arguments. If not then cpp throws compi= le > > > error. > > >=20 > > > Signed-off-by: Pali Roh=E1r > >=20 > > Reviewed-by: Tom Rini > >=20 > > --=20 > > Tom >=20 > Tom, who can take this patch? I'll take it, as part of putting together a number of small fixes for this release. --=20 Tom --CGDBiGfvSTbxKZlW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMI5n8ACgkQFHw5/5Y0 tywYjgwAp/RQtKqks3/qIV4mtouF6Q25SCIiK5h/HLzzCpv92TybXTleTmzfXQx8 /GpXXPAFIqZON3MvwCQ3fm/yjQVYMuXquRA6xJPXRY+IOTWe+uJrP5OTNDOG+T9T osKLy0REcPByHPVqvb7awXXbD3EThDknWGEfVMcS9d9PrPuogTvfcPF5FLc1pEqW dUNkRfDnNtQnMUAYPK8aTQ9EJ+/tQxdCYXPgbfY+Wb66GHWWBpb19weeXsKknS1s bpwyp6Qx15iV3cv+64fCxFtA2B+qInohGi8KQUfycYUYp+l+gX6ctSW/yh87ClqU eecBvz641DUS7/n207LOpEt/8PaIjiQ+hA8k+Eb/AqHCsAaFUOQh5pte/EA8K9PL WOOGiu9kAVPzFEOyk404b6d7d61raUOnzWI57OZPH9lMhCgeFfs9nF8noO5kWy9R d0XTnexgpPbsRyvCqcSrLAVXsyPgzmCm27/3B6zyrV8cepG29H1nIqiHeBqMvQI+ mm0nV/Py =Y93V -----END PGP SIGNATURE----- --CGDBiGfvSTbxKZlW--