Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FF89C0502A for ; Sat, 27 Aug 2022 12:06:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 92BFC84913; Sat, 27 Aug 2022 14:06:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DL3dem9i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 692E584916; Sat, 27 Aug 2022 14:06:27 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A7FE848F6 for ; Sat, 27 Aug 2022 14:06:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id kh8so3038100qvb.1 for ; Sat, 27 Aug 2022 05:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=luAb7SoFnL0DsOqNUaYdyVmqF9pTJbCLBYOHx4vW6fk=; b=DL3dem9iD10w3vbfKg9oIJ+Kh5Km6dqB5wdEFEurF2wFEPHw09uAh9o9ghh6G5kQwS tOn68Lm1ymqwPeAeZ1sUp0iMSCMyBe1azPOMqQXqQl+d5a6CumPd5HIjCkqQT2wQHK6n NeG6pKy4KTizE+U1un0JTN3K/kjWrcTuD9A7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=luAb7SoFnL0DsOqNUaYdyVmqF9pTJbCLBYOHx4vW6fk=; b=f/loUxehme52z1IgC0gxksvdsye+ISw+G3qYeR2dCHrw2DshJTGNmhLBDZ5aZAx/q5 ojGscXEcO6wNFOdajrTYtVoIpSGYP+kTL5VxnRffBz/Ugx7uTbZSOkKuD8g4ninQFQHh Ux+r8r96svoMkGsXckRfx2IcPbs0vhlGDDBPnxaGbSyVZdshfMehKrXbor9lEL/aGqLa joPsRjSkQ/O10MFcNKxfjwB39z+b9HjtmskNIHNyjyDC+Z7uCSvMzbl5dlVcNeznP7xW s781zVcx44T5m7ysTxXjXsARP/QAdAGXpvSvkhcsI3BrK3iMV5t/efQCyVxF4JGN8b31 iKnA== X-Gm-Message-State: ACgBeo0jdvyoWAwgANQa3HzY6pJdZGIr7GvuPLg9ozyJfzw4a2+ny2oY f2HJ831CBAoEGMvdbqrv0lVxzZ2fmq7d/Q== X-Google-Smtp-Source: AA6agR76aUiBTRtMRfGdXjGX7dYQwZbxrasAUeCGW1cwEOgJxm/BrWcqwPc4cNR4Jeeh3AlbUCaPEQ== X-Received: by 2002:a05:6214:27ed:b0:497:87d:e876 with SMTP id jt13-20020a05621427ed00b00497087de876mr3169074qvb.121.1661601981968; Sat, 27 Aug 2022 05:06:21 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id bj4-20020a05620a190400b006b5c061844fsm1781229qkb.49.2022.08.27.05.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 05:06:21 -0700 (PDT) Date: Sat, 27 Aug 2022 08:06:19 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] distroboot: ubifs: Add support for specifying UBI header offset Message-ID: <20220827120619.GH7942@bill-the-cat> References: <20220807190422.20157-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TXtjXAp+Y+VkYOQB" Content-Disposition: inline In-Reply-To: <20220807190422.20157-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --TXtjXAp+Y+VkYOQB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 07, 2022 at 09:04:22PM +0200, Pali Roh=E1r wrote: > Some UBI partitions may use non-standard UBI header offset. For attaching > these UBI partitions it is required to pass second argument with offset to > "ubi part" command. >=20 > Therefore extend distroboot to allow specifying additional optional 6th > argument with UBI header offset. This offset is set in new distroboot > variable ${bootubioff} which may be used by distroboot script to e.g. > properly pass this value to linux kernel command line for proper mounting > of rootfs by kernel. This variable is set to empty string (cleared) when > UBI header offset is not specified into distroboot BOOT_TARGET_DEVICES > macro. >=20 > Usage of helper macro BOOTENV_DEV_UBIFS_BOOTUBIOFF in this change is there > as a type check. It ensures that in BOOT_TARGET_DEVICES macro was specifi= ed > UBIFS func with either 5 or 6 arguments. If not then cpp throws compile > error. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! --=20 Tom --TXtjXAp+Y+VkYOQB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMKCLsACgkQFHw5/5Y0 tyx2Hgv/eVBUBVB0Ml7S4PXPvn+WHXll2KMi3MrTYLZ43Py+htisl/Th4uhMWbst Q2c+eba50KR2dHrwOhtUVQ8d6+SeP6U/Xwc72KHfhNlOYdwSzZ3179rS7NK9uuRg 9dD8mw4Iqzja14ylhe1faOhIb5PmCkafHGw8dVaiFedl9EmIDSezpAT1WVAl8kNB T6QFxM2JaAjWw5uks/v8AF3yzPhc9jAOKL7kijoNT3FjG7RUDFa1BGVFOZaVPChT oS3w6erzkythlRVEEDi7nLKU7w+SVL8ggbM0HwwalpzDTywAJdssM3wKgkzQeTDF o3wqoHR0ZUndIwofeU1bN7cz5nIaAB3mZ8AqGpuC55RHHH9+HNh0PJjyRxdF4EuY X3m4kfwo+VrVnpbf/c5aOQUBtPebIj9cL8YiQtdf0RddRYsPFew73yNNKTycwPZS 286392l4f3pvfkmOdahCaTpEU8FRDeodhbph6GwbmTnSPBj4mgovQ3mYyKlZaDY0 984/m3j3 =x5AM -----END PGP SIGNATURE----- --TXtjXAp+Y+VkYOQB--