Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DC49C0502A for ; Sat, 27 Aug 2022 14:41:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C8CBC8412C; Sat, 27 Aug 2022 16:41:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cr+c1+RD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42F868401C; Sat, 27 Aug 2022 16:41:06 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A800A8412C for ; Sat, 27 Aug 2022 16:41:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id cb8so3306669qtb.0 for ; Sat, 27 Aug 2022 07:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=OmexA42wWbVt5a/kh0b/qzPk5AoplwtHW+8hgUJSIqA=; b=cr+c1+RDSYrk5NsbMm0jlIKPwZhAmhXip6jFnTPmif30oNiVxPNSMTnCFheflXZ1tM E1t3Eesl16nU8O/ECkrlq11w5BWIFSlrdEs2Uw/hmrqm475jgGVoyeVedmbqvFCKW6Rh oQHJn3PijGpTctW35Yq8B8KSUcSIpQ5gvOHDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=OmexA42wWbVt5a/kh0b/qzPk5AoplwtHW+8hgUJSIqA=; b=2+FPutRfobvWSJ+ueAWZyp0aFmpYDvyRaqbffesxf8cadcQigKe8F8K7t/S9qRVMWe anwxnXlFtGY39LvO+pqOUVrXLdul6EnUxlyUO7Dk7yHBT2Itqr2HGDGm5isOzH/H3vd0 R5/jO+fxqCYxkaAGHC2Aoh5Nc0Lrs+n0a1VtaOXc9pMZu/h6YbdssK5dQkC2L11CpLDF kk3n5gaGJT8HdgWomevI/XfkreYWG2Gj5dYHuY/Z9/RbdNSc1HO/fXPXCEitwO33PTt4 KcheIeAkYcKoFSySxKyk7pTU1M0786O6hBP5qFnqj4CJhP4C1yk3p60haZISPugnVlEN pJiw== X-Gm-Message-State: ACgBeo3G7YEMHMdPpNtPwfM5RpggGWtFSwa99iJgFLH//6QNMx2yIqzR rx6ecZu3pMeDQl3qHipQDby7KzlpqU8vDg== X-Google-Smtp-Source: AA6agR4nuUPato9yBNcw/eFPUgNmWTbsJv1WKf1plXI4A6/voQYk/DL6eHo4argZMr9L7fAinho2EQ== X-Received: by 2002:ac8:4e91:0:b0:344:7cfb:9437 with SMTP id 17-20020ac84e91000000b003447cfb9437mr3886833qtp.230.1661611262455; Sat, 27 Aug 2022 07:41:02 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id v17-20020a05620a0f1100b006b58d8f6181sm1947186qkl.72.2022.08.27.07.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 07:41:01 -0700 (PDT) Date: Sat, 27 Aug 2022 10:41:00 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Wolfgang Denk , Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de Subject: Re: [PATCH v2] xyz-modem: Allow to configure initial timeout for loadx and loady Message-ID: <20220827144100.GK7942@bill-the-cat> References: <20210910204653.3066-1-pali@kernel.org> <20220827114835.22584-1-pali@kernel.org> <20220827125308.GI7942@bill-the-cat> <20220827125615.t4obqj43vb53raiy@pali> <20220827143005.GJ7942@bill-the-cat> <20220827143237.gxkn4zu4c5avuwpp@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tH81YkO9bF1TqYxP" Content-Disposition: inline In-Reply-To: <20220827143237.gxkn4zu4c5avuwpp@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --tH81YkO9bF1TqYxP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 27, 2022 at 04:32:37PM +0200, Pali Roh=E1r wrote: > On Saturday 27 August 2022 10:30:05 Tom Rini wrote: > > On Sat, Aug 27, 2022 at 02:56:15PM +0200, Pali Roh=E1r wrote: > > > On Saturday 27 August 2022 08:53:08 Tom Rini wrote: > > > > On Sat, Aug 27, 2022 at 01:48:35PM +0200, Pali Roh=E1r wrote: > > > >=20 > > > > > Now when loadx and loady commands could be aborted / cancelled by= CTRL+C, > > > > > allow to configure timeout for initial x/y-modem packet via env v= ariable > > > > > $loadxy_timeout and by default use value from new compile-time co= nfig > > > > > option CONFIG_CMD_LOADXY_TIMEOUT. Value is in seconds and zero va= lue means > > > > > infinite timeout. Default value is 90s which is the measured valu= e used > > > > > before this change for loadx and loady commands. > > > > >=20 > > > > > Other load commands loadb and loads already waits infinitely. Sam= e behavior > > > > > for loadx and loady commands can be achieved by setting $loadxy_t= imeout or > > > > > CONFIG_CMD_LOADXY_TIMEOUT to 0. > > > > >=20 > > > > > Signed-off-by: Pali Roh=E1r > > > > > --- > > > > > Changes in v2: > > > > > * Allow to set timeout via env instead of permanent infinite time= out > > > >=20 > > > > This breaks platforms like "porter" where we have SPL_YMODEM suppor= t but > > > > do not have environment support. > > >=20 > > > By "breaks" do you mean compile error? Because if env is not set then > > > CONFIG_CMD_LOADXY_TIMEOUT is used. Just I'm not sure if env_get() > > > function returns NULL or what when there is no environment support. > >=20 > > Yes, it fails to link. >=20 > Then just #ifdef for env is needed. I will prepare v3. Which defconfig it= is? It's the "porter" defconfig, sorry I thought it would be clearer. There's probably others too in the case of SPL_YMODEM without SPL_ENV, it was just the first one I guessed. --=20 Tom --tH81YkO9bF1TqYxP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMKLPgACgkQFHw5/5Y0 tywD9gwAo+xnVl7vuZtieFtC+9BEkuAQzycWU3sFdGxNkRXp0jl7F404yURIOtnM 6MzeHUwYk++pvOcDbJHuhBZpgraDA+KjpuQhB1snyI2B2omKQCJLyMXYBtonjuT6 ++TqYruGrHJzCcHJmrx4hZotW2vyHFOyeVwpjoiIHAoVxCnUr0vTOrzhysg7bdMN qMtZ3Een7eXJqh/knCZySB5+OHc8/QgEzVpZOtJhqs9nwH9c0H89IOeyyxP7H3Bj E/9TS+FD4OXe+GSBUEeKQJfcU0lRvaUh2CZ6/EF/Mh2MUn7QD2ugpDTOi015mELy 1reT/fiAbKZJqdWnd8R2ltTpilAt8fuyLQ6ah9aa/FWYGzEufxXzJCNqPWhy37Mu 4ceQIPYSdnq8hdlbowkx/CyaBAFMmaSETZi1gxkL8KsOVbIdevkgKb0GCG/vOBgr DwXpLeP8H2QWDamT/GgN/5UlLjuOkvIJvaOBhcowTLNPnnYd0D3TiKqObQc8LnnG vQjhkMW5 =NX6s -----END PGP SIGNATURE----- --tH81YkO9bF1TqYxP--