Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8339ECAAD8 for ; Tue, 30 Aug 2022 17:27:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFCFB10E2C9; Tue, 30 Aug 2022 17:27:37 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4F7810E2C8 for ; Tue, 30 Aug 2022 17:27:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F070617A0; Tue, 30 Aug 2022 17:27:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D7E1C433C1; Tue, 30 Aug 2022 17:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661880442; bh=KBLX5qXfyk5/dpxUQdEN56xZBiuWMnNl5Lfub9yUOrE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ILl//zQYsR1crfAWeQqzAeN3hxcYmiyXmVnZt9wxCAaBs8Xy4bvZ5bzE4Pz5F9DIO 5WeLSwhy+Gx3f6BmXn2+U2lQWnNAQzesjzvV6GFq9OcRGy01/1nd7idZ+tlp7Onyxb xq5DgATqw5uGl8PrMQk+fswgDmGoqqkQrbYh+t4z7Jc/8xadpBcv//EsAIy7RCcN3d gx1Dd4C123/Zl2KEW/RjYQ40yprOmAcAp7ujrP6fgZLJ6mgnXvuipfI8NNiPiLp6sM 2gStRAkqLkc09mxEdI2XnRJMq5JJV1+6F+GaVjHJXBh6c5tfX8wiqpBiW2jSXaK+4s Z13oMop6FYP0g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 5/6] fbdev: fb_pm2fb: Avoid potential divide by zero error Date: Tue, 30 Aug 2022 13:27:05 -0400 Message-Id: <20220830172706.582088-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220830172706.582088-1-sashal@kernel.org> References: <20220830172706.582088-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-fbdev@vger.kernel.org, Letu Ren , baihaowen@meizu.com, Helge Deller , Zheyu Ma , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Letu Ren [ Upstream commit 19f953e7435644b81332dd632ba1b2d80b1e37af ] In `do_fb_ioctl()` of fbmem.c, if cmd is FBIOPUT_VSCREENINFO, var will be copied from user, then go through `fb_set_var()` and `info->fbops->fb_check_var()` which could may be `pm2fb_check_var()`. Along the path, `var->pixclock` won't be modified. This function checks whether reciprocal of `var->pixclock` is too high. If `var->pixclock` is zero, there will be a divide by zero error. So, it is necessary to check whether denominator is zero to avoid crash. As this bug is found by Syzkaller, logs are listed below. divide error in pm2fb_check_var Call Trace: fb_set_var+0x367/0xeb0 drivers/video/fbdev/core/fbmem.c:1015 do_fb_ioctl+0x234/0x670 drivers/video/fbdev/core/fbmem.c:1110 fb_ioctl+0xdd/0x130 drivers/video/fbdev/core/fbmem.c:1189 Reported-by: Zheyu Ma Signed-off-by: Letu Ren Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/pm2fb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c index 1a4070f719c29..9b32b9fc44a5c 100644 --- a/drivers/video/fbdev/pm2fb.c +++ b/drivers/video/fbdev/pm2fb.c @@ -614,6 +614,11 @@ static int pm2fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) return -EINVAL; } + if (!var->pixclock) { + DPRINTK("pixclock is zero\n"); + return -EINVAL; + } + if (PICOS2KHZ(var->pixclock) > PM2_MAX_PIXCLOCK) { DPRINTK("pixclock too high (%ldKHz)\n", PICOS2KHZ(var->pixclock)); -- 2.35.1