Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11FA2ECAAD4 for ; Wed, 31 Aug 2022 23:35:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2357884A1A; Thu, 1 Sep 2022 01:34:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="S1MMusaz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94F2E84A0D; Thu, 1 Sep 2022 01:34:27 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E116D849E3 for ; Thu, 1 Sep 2022 01:34:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id h22so12249628qtu.2 for ; Wed, 31 Aug 2022 16:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=TrK+VvvWAvPcEVXdpONrsZhJ5MvUj0Qjmzhnxb63BC8=; b=S1MMusazDZJ9gRj+X0RqwmjX7/yS2arzFAZ+JXCfn1T/HQSlWRXUc5QGr4SteGrymu 55XQdaG/3JIBlf7YVWTAM+7KeFnIw/Ej9oM+c0HEQRUkCY/YMBx3GcssMelYoL3qaiPE qxWvtMLoXJSbZ0y6qcFUxho6MX9Mlu01h+Pu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=TrK+VvvWAvPcEVXdpONrsZhJ5MvUj0Qjmzhnxb63BC8=; b=wk2RajOobUnXNRYydrz4lLYPPOHpfEHCfRQiUVs0pw6j2iXrvUDBWw/0VUnoQnJMMZ t9d5XktiiC+aChzVyRcKnrO+Tn/lHRhUMbuC00vXQqwDKswO7SwRtCUJyBPP3PD1WfeT Od7iK7qJBcXGgrZPasGsMh7j2LC/st2vP7rwGXD16894zk7NXvIQl5wbkZUbL4BRRQ5G ufO7ZZe/09QCI+KLm6q6IQbGxHuKkZlWsHCngczsLpWNm2MIHV1Nby7MpVF6fpNadAZY KdNLEohbT8JVnk+4UmS0AoX2yYf4xtYz04LtVVVedHMfg4vlrPXXjFuYPYyAruZ2nJRt tECw== X-Gm-Message-State: ACgBeo2AhkPVs9pPEIftn7YXRp8VBoHGfIZrqfRAlQQ0JEfvZXMyQkMd cuLkAcRqTfr4UokvncjV8c1N1Q== X-Google-Smtp-Source: AA6agR4PGeu+ApUdWEeAGUtC/abRJajMOdqJXyVbx+2mGxk9uBn+P8L1KIW1w4haw5FjS1bI4un0zg== X-Received: by 2002:ac8:5b15:0:b0:343:6789:193a with SMTP id m21-20020ac85b15000000b003436789193amr20828038qtw.647.1661988862198; Wed, 31 Aug 2022 16:34:22 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id c8-20020ac87d88000000b003435983a263sm9898496qtd.46.2022.08.31.16.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 16:34:21 -0700 (PDT) Date: Wed, 31 Aug 2022 19:34:19 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Heiko Schocher , Nicolas Iooss , Simon Glass , Tim Harvey Subject: Re: [PATCH 1/2] Revert "i2c: fix stack buffer overflow vulnerability in i2c md command" Message-ID: <20220831233419.GV7942@bill-the-cat> References: <20220826211556.23100-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+cTHE2B7cPyeMCYH" Content-Disposition: inline In-Reply-To: <20220826211556.23100-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --+cTHE2B7cPyeMCYH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 26, 2022 at 11:15:55PM +0200, Marek Vasut wrote: > This reverts commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409. >=20 > The commit is largely wrong and breaks most of i2c command functionality. > The problem described in the aforementioned commit commit message is vali= d, > however the commit itself does many more changes unrelated to fixing that > one problem it describes. Those extra changes, namely the handling of i2c > device address length as unsigned instead of signed integer, breaks the > expectation that address length may be negative value. The negative value > is used by DM to indicate that address length of device does not change. >=20 > The actual bug documented in commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5= 409 > can be fixed by extra sanitization in separate patch. >=20 > Signed-off-by: Marek Vasut > Cc: Heiko Schocher > Cc: Nicolas Iooss > Cc: Simon Glass > Cc: Tim Harvey > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --+cTHE2B7cPyeMCYH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMP7/sACgkQFHw5/5Y0 tywg5wwAj4TEVhhX7Z3jCLYqP0FFkMR/QOaUmyJXq3ohYqSCYC8xhph/gkMHMmss /HMp6ipwFdb37+mg8BwYJtN3qNci+nNoqwSUqLHqvRIMrLFe4DPZBMUhi5K+prt8 +kckE37bE1Ah5zNcN8qjW1u9dispB1WBeEiIIukZyGFBVFlL4BEcvgRIL0MZo2LV /IL65O943IkkZG/MJEKU4AbIM4vgslECL06gZEli3vJyoziCKu54hSWKlI3RTTdn 5nDFYuTacsfYxVaM1JYoXBnR6LJ+qjXAPZGO6PYpPwwTljDXSv8V21zZYL9AAIVg exL6vBQFCW4C8N2Mo8u0waiVhtbhal6m26QllNyUikyzddaEP3JwpKzL6RlRr/yz EKplA42TA8bfz10vX4bNSUn1Fl3uqMLbU3/mcdLPRIGioV5BEmOpH+I5Wvtd+CIk Xepc3ZTOvtgMhGWgS9wSCQ+CWtp2WOpjlAmbqq0ThddC1/vtzmINiFc8Ro9WL/1O zD7rSq8X =Z1Ke -----END PGP SIGNATURE----- --+cTHE2B7cPyeMCYH--